From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EDE3470429 for ; Thu, 30 Jul 2026 23:13:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785453210; cv=none; b=Xy1JIaVlsLjb7WiLw0GYuvHrGvkJSNSW4xcQuf5mjCxiEj09YBHUeaSmQ7MqM3zBOA2hmpUz167sMLA9SVgWhcZmL1d5OA0b9AifL9xlWUvXxrK+D2IwVo1O3iVUwv5RA/dgELqf+zkn+7TsEN7Lo7PEeZIi3LCSvYv4qR1oRck= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785453210; c=relaxed/simple; bh=EHvfDpfxxWUHYnVRRayq7I+H5XtU9cbfpd1Wv3pIpgs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tTgbB/1SkDJM6VzXq/2uI/92G/tbf9nsbp/7CDUvWW+6m7rtf6XvCw/QmnrjMox4LNIa983hRcpipKT1JljdpebKF8pXScN9te4uOHTVQNkqrWOrVAkXGkGwabclyVqhHhfutRo1xF8Ata5C7qO+Ws92FvZSlKoWwpl03Uvq/Yo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SWcV6Lxs; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SWcV6Lxs" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-84830c774a0so473749b3a.1 for ; Thu, 30 Jul 2026 16:13:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785453209; x=1786058009; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=RXdvAClsqaKvl5me0t3HAq930Gjdl6GY+XY0N1BhN0E=; b=SWcV6Lxsx52znK2L9GAxRG6K7yjRSBgi+HiJj12eJNz2uIMLwXMrgBsQTo3pDcA6Dd h/awnRxfc7sT1B+idIjfu2hcdbrvbLeRrECDwrer28pc9wzFXxhSkuPfyGt+94L4wz/v p9EtHa491kECRPWFJ6g6r+r0CsxdlZc1oSNxVEVaIihZLJ5evKNnLcK7sPEyaEuXP4in 9kjx/WT8zLsBh4WUAzvvMTPcCXuVvJnIeG3GYS6RHxU1SYjDoVP23Gg9h4DbQ6MCpZHf Mt4RE7NjMp6yQK+qLLmdEzg5m4D/zHQgFO1um0lBuvOCgCROfss8bNiPMSR3rYTXeXXj ymwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785453209; x=1786058009; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RXdvAClsqaKvl5me0t3HAq930Gjdl6GY+XY0N1BhN0E=; b=S+O1ntzYiQi1EP7uLzKOK1RhS8kafO4wbF2U0OBA9laidm/niQxk5yT/edLt5jCGtX NcHleS9VkgQIv1219QYuAwgdY8n5QGh/mrsMDOgTd3xSTGEVPLcLBTjHzOUKe2QsAZAD Ep0Tfurr+VUSlVEszZFUy2HoQ6I4IscQAkFZxkGzVw3S8vSn57kZI0Gq5OY4+JveFXr0 y4Fthb6b7i9XlhsoR/1kuDdDQ0UyZa3qBK6L8l1n5w8gar4XK8cVuhgwrpx22TDjniEM jFcJ7xuZpj5EZjmJs8XhPE+yh6KRwN8AALm8s3NZHIxbUAHrb32rtzFYdahng6mW6ZpW BHIg== X-Forwarded-Encrypted: i=1; AHgh+Rqv7C3me0SQBUPiUADAL1swisdg+gRIB9K/cUgp6XadSc+c+d9TRTU0Bg7LDk+18qTx+Ht0kYpeeNwLTeQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4thadTBX7aHzegqhFs/L8win2tioLmYybkaP3ArFdUO9c/Erw j8ileEe6GmoqnTnW9nRYmNE9gj6wHFBlFaQU9+q3OV3h1x1BJQpbACz4 X-Gm-Gg: AR+sD12tQTelhrJwamknrK7l4Xr6U2AEvVJ6V1cj1WyL1na4djTQ6kVmCzXWgPQ3IiC zupI7I6ajVhnNhq5N+sx/xCP0MP+1wSensKNIALZ4gWoYP3l/roLtU9VHTN0AeFO85gRUz/oTd0 Vw7XqvSzl371jzGEt+x+w3hJ/q4Sr30enNZnzvAw4CKdg73n79gWAf6FL8u2B1ERpN09r7dPBcY xUf7wr5K1jlfAj7PFiMxeUf7v4cJRnCLE6DanCaeMTA7LNLzl9cvtdyTSQuDJFpDkI/AvgezE49 4r8kM7yC1VW36UcpUiDWpQIGg1kUi8XiMH3FuRGYYRA9KDv4l0Bmaf6u10FfU9CWyjR4eVln+cp N5ojCYB3FxxGUqIy9+jlAKSiKV9MCEGpSTKsmKVR0SuotaSqTo6RfcGuYNZZUapSX0uFiyv7dbi YK+ThgyBI28+EXejPynOf1y9KgXo/n0lyMapTCNgNfOFhN4Vs0glxXGQLdyEEXIbB9MUo5uOm2S ISPYzQowL2l+U/FomDXLuCPBvXsIsz8fiYB87jNqQCYtd8NcOEx5dsedn8ZoKcysOezHhw= X-Received: by 2002:a05:6a00:3cd4:b0:845:e9e8:6458 with SMTP id d2e1a72fcca58-84ebc2256aemr4201058b3a.20.1785453208623; Thu, 30 Jul 2026 16:13:28 -0700 (PDT) Received: from bloom.localdomain ([2604:3d09:178e:e100::6868]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e9fe20e35sm3686246b3a.1.2026.07.30.16.13.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 16:13:27 -0700 (PDT) From: Ivy Lopez To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ivy Lopez Subject: [PATCH] staging: rtl8723bs: use kfree_sensitive() for key material in rtw_set_key() Date: Thu, 30 Jul 2026 17:13:15 -0600 Message-ID: <20260730231315.79688-1-skunkolee@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit psetkeyparm holds WEP/TKIP/AES key material copied in via memcpy from psecuritypriv before being freed. Use kfree_sensitive() instead of kfree() so the key bytes are zeroed before the memory is released, consistent with how psetstakey_para is already handled elsewhere in this driver. Signed-off-by: Ivy Lopez --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 1196ec011455..fb45f7295386 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -1926,14 +1926,14 @@ signed int rtw_set_key(struct adapter *adapter, struct security_priv *psecurityp break; default: res = _FAIL; - kfree(psetkeyparm); + kfree_sensitive(psetkeyparm); goto exit; } if (enqueue) { pcmd = kzalloc_obj(*pcmd); if (!pcmd) { - kfree(psetkeyparm); + kfree_sensitive(psetkeyparm); res = _FAIL; /* try again */ goto exit; } @@ -1949,7 +1949,7 @@ signed int rtw_set_key(struct adapter *adapter, struct security_priv *psecurityp res = rtw_enqueue_cmd(pcmdpriv, pcmd); } else { setkey_hdl(adapter, (u8 *)psetkeyparm); - kfree(psetkeyparm); + kfree_sensitive(psetkeyparm); } exit: return res; -- 2.55.0