From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07DF6309F08; Thu, 30 Jul 2026 23:29:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785454153; cv=none; b=Nj9eKWjUKZzcfc3dtA1XPSKgJVwctkEvNK/e8hgV1wK5F1fx3ggzH7MPyZbG2o7gwQUr2kQ8TP0Pj+r83Et19pa7dWUVaVrwRRgBEHbVLNvTZweEgnJZ3EyrzUcHc7104OImtHOolwwEq8HVSHbwcB63nnLFnUC41qJsriBaeIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785454153; c=relaxed/simple; bh=TLEybU8RbQkyzN0WI44ggs/PpkN9LN5f3L7RTIkDaCE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iQ5B10a6Hqlk6BWlA31bPYnW2zuKcC8dWq6iFNTXRgIpJfxWrPuPJwKdKKXichnqSFE9SC1toTRqfSZ+4SGVZm2nziBcsGJViJcOoAHKGuDkScNXsrFmj2KHis0Ip/fKGhes24AuZ9SdTHzmhkHLatO2ZZR52UJIxSS+RqLQrp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=XPDvqptm; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="XPDvqptm" Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 15AF82E9; Fri, 31 Jul 2026 01:28:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1785454082; bh=TLEybU8RbQkyzN0WI44ggs/PpkN9LN5f3L7RTIkDaCE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XPDvqptmjr2Vs3Mk9GJMVmgUOmiC1ccfBBdVutsxU42TDIh9rxHX/CZiI6ue0GgJ0 uwy0M/Li+lNwmJwDdtDe/DTZ72PoemcjvBKc8EWokkIvkrKYftWw0CA9BiXJHjxAa9 FIUWdBS8ByjtC7YJOp7Bmy/Trp0LdilrZHD6I0xc= Date: Fri, 31 Jul 2026 02:29:06 +0300 From: Laurent Pinchart To: Guoniu Zhou Cc: Mauro Carvalho Chehab , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Christian Hemp , Stefan Riedmueller , Jacopo Mondi , Loic Poulain , Bryan O'Donoghue , Dong Aisheng , Guoniu Zhou , linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Chiras Subject: Re: [PATCH v5 4/4] media: nxp: imx8-isi: Add additional 32-bit RGB format support Message-ID: <20260730232906.GD1600813@killaraus.ideasonboard.com> References: <20260728-isi-v5-0-1d22ab91602a@oss.nxp.com> <20260728-isi-v5-4-1d22ab91602a@oss.nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260728-isi-v5-4-1d22ab91602a@oss.nxp.com> On Tue, Jul 28, 2026 at 02:58:59PM +0800, Guoniu Zhou wrote: > Add support for additional 32-bit RGB pixel formats (BGRA32, RGBA32, > BGRX32, RGBX32, ARGB2101010). > > Formats with alpha channel (BGRA32, RGBA32) only support capture as > ISI ignores alpha bits when reading from memory. > > Signed-off-by: Robert Chiras > Reviewed-by: Frank Li > Tested-by: Laurent Pinchart > Signed-off-by: Guoniu Zhou Reviewed-by: Laurent Pinchart > --- > Changes in v3: > - Drop M2M_OUT for ABGR32/BGRA32/RGBA32 as ISI ignores alpha bits (Laurent) > - Remove Android requirements from commit message as alpha formats > cannot be used as M2M input (Laurent) > - Add Tested-by tag from Laurent Pinchart > > Changes in v2: > - Add Reviewed-by tag from Frank Li > --- > .../media/platform/nxp/imx8-isi/imx8-isi-video.c | 51 ++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c > index a6e044056762..f45c2aae59ce 100644 > --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c > +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c > @@ -166,6 +166,57 @@ static const struct mxc_isi_format_info mxc_isi_formats[] = { > .color_planes = 1, > .depth = { 32 }, > .encoding = MXC_ISI_ENC_RGB, > + }, { > + .mbus_code = MEDIA_BUS_FMT_RGB888_1X24, > + .fourcc = V4L2_PIX_FMT_BGRA32, > + .type = MXC_ISI_VIDEO_CAP | MXC_ISI_VIDEO_M2M_CAP, > + .isi_out_format = CHNL_IMG_CTRL_FORMAT_RGBA8888, > + .mem_planes = 1, > + .color_planes = 1, > + .depth = { 32 }, > + .encoding = MXC_ISI_ENC_RGB, > + }, { > + .mbus_code = MEDIA_BUS_FMT_RGB888_1X24, > + .fourcc = V4L2_PIX_FMT_RGBA32, > + .type = MXC_ISI_VIDEO_CAP | MXC_ISI_VIDEO_M2M_CAP, > + .isi_out_format = CHNL_IMG_CTRL_FORMAT_ABGR8888, > + .mem_planes = 1, > + .color_planes = 1, > + .depth = { 32 }, > + .encoding = MXC_ISI_ENC_RGB, > + }, { > + .mbus_code = MEDIA_BUS_FMT_RGB888_1X24, > + .fourcc = V4L2_PIX_FMT_BGRX32, > + .type = MXC_ISI_VIDEO_CAP | MXC_ISI_VIDEO_M2M_OUT > + | MXC_ISI_VIDEO_M2M_CAP, > + .isi_in_format = CHNL_MEM_RD_CTRL_IMG_TYPE_RGBX8, > + .isi_out_format = CHNL_IMG_CTRL_FORMAT_RGBX888, > + .mem_planes = 1, > + .color_planes = 1, > + .depth = { 32 }, > + .encoding = MXC_ISI_ENC_RGB, > + }, { > + .mbus_code = MEDIA_BUS_FMT_RGB888_1X24, > + .fourcc = V4L2_PIX_FMT_RGBX32, > + .type = MXC_ISI_VIDEO_CAP | MXC_ISI_VIDEO_M2M_OUT > + | MXC_ISI_VIDEO_M2M_CAP, > + .isi_in_format = CHNL_MEM_RD_CTRL_IMG_TYPE_XBGR8, > + .isi_out_format = CHNL_IMG_CTRL_FORMAT_XBGR888, > + .mem_planes = 1, > + .color_planes = 1, > + .depth = { 32 }, > + .encoding = MXC_ISI_ENC_RGB, > + }, { > + .mbus_code = MEDIA_BUS_FMT_RGB888_1X24, > + .fourcc = V4L2_PIX_FMT_ARGB2101010, > + .type = MXC_ISI_VIDEO_CAP | MXC_ISI_VIDEO_M2M_OUT > + | MXC_ISI_VIDEO_M2M_CAP, > + .isi_in_format = CHNL_MEM_RD_CTRL_IMG_TYPE_A2RGB10, > + .isi_out_format = CHNL_IMG_CTRL_FORMAT_A2RGB10, > + .mem_planes = 1, > + .color_planes = 1, > + .depth = { 32 }, > + .encoding = MXC_ISI_ENC_RGB, > }, > /* > * RAW formats -- Regards, Laurent Pinchart