From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2358D3DB303 for ; Fri, 31 Jul 2026 11:20:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785496832; cv=none; b=bA/PhHAH+eyx6Cu0Ydwl7mcT5OYPFNn8dLOFo91VOZRC3DXT8aR0Xaeh4PT2Z6O5qdtwjBtq8BlLvb6rjp8DwDvhqaLgpoCtYlbV1WozlQhNSV+bo+wK8z0DKLngnqTPQqZicdKmUmmoaxDTIx5Ke4kFLNtUfTImnvWNYyl4l6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785496832; c=relaxed/simple; bh=nCZXJ+rSyzocitV6rl8YQH2YL5OfHKGAPnlyR9Gbf68=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PLdHUnN4dQVCBlrm6RGorqp3UeEzESIxGEsO8IJzLBM4xMhdf8UXfE/Zvt2kwdi3HWLWJQXgZN7ZR09f9RQD8GSY65vcspaC0q8wI5vdtvieTw9bI4Cup8efg1XXAPls5YMEEnjsRxwNoAqqhXiBhVC+lT103RXkxDwPVwaQiR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=niyl1I8j; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="niyl1I8j" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FB6D1F000E9; Fri, 31 Jul 2026 11:20:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785496830; bh=nCZXJ+rSyzocitV6rl8YQH2YL5OfHKGAPnlyR9Gbf68=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=niyl1I8jIH83aCDzk/LNvrcBu4SE3au8tQGYPxVd4MDYDoumdGcGG4ea/7F0xjoRz uCROLNS/ntTUL2b0rvDF30B3KPWnvme8ccNoDImlK6mlB8z/mO8uLRmMlPvhyHEUoR jmtuaFw/0F4zO+lCFRGiv8fb7htJSfc7IJbHq1pY= Date: Fri, 31 Jul 2026 13:20:16 +0200 From: Greg KH To: Pei Xiao Cc: vireshk@kernel.org, johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: fix coccinelle false positive on potential NULL dereference Message-ID: <2026073103-ecard-substance-3fa4@gregkh> References: <58151f69faefc2145954b95261506e3e7c14ca89.1785228166.git.xiaopei01@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58151f69faefc2145954b95261506e3e7c14ca89.1785228166.git.xiaopei01@kylinos.cn> On Tue, Jul 28, 2026 at 04:44:52PM +0800, Pei Xiao wrote: > In gb_bootrom_get_firmware(), when fw is NULL, ret is already set to > ERRNO before jumping to the queue_work label, so !ret is always > false and fw->size is never dereferenced. Add an explicit NULL check > to silence a coccinelle false positive warning. Why not fix the coccinelle tool/script instead? thanks, greg k-h