From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2743633F599 for ; Fri, 31 Jul 2026 03:09:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785467398; cv=none; b=Vi4Dxk/8ZYKpNaBbNnbli/2fzuhHgYepWUk6UuXftNM5fzsCCJ+tyZKgJowsEHnDHq4r8DWUf4tJG+6XBE+gdx7iZn4QFENuA1B5gwmw/v83WQonAb4I6sJzCHIDPfuFfxPPDGfmjHRjHnaSgttPck2X24NTRgAXbki/KYa5glY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785467398; c=relaxed/simple; bh=Fa/+gfQ3SzEgi11qWxA09O6FM4GPY4YkSzC3+KOzEZU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=InGFwjvm8PyqvaEfSmT2K07Cl92y65SwwhMQlBiDEJhh1jgHqUQOb7Q/RrVuJr4RmcQfJ+6jiLC3Lx1qIFDIynzsKZg0eNCZMwvfxx/dUoD3eUgNOFWtUPep8Ebl/VnkS4bPH2LJeuY0uXEQ7dp3WGEM5flmdtDTYfG6gG3/Un4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mKImLUzR; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mKImLUzR" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2cf6d65d8a7so6770135ad.0 for ; Thu, 30 Jul 2026 20:09:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785467396; x=1786072196; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aWHLEKCAQ5mV1sF9yyFHSMFUTDOduAtPgNwQ5RGsXm4=; b=mKImLUzRxA0uk5pfsvrn65IkfNC4eMvwIEAHmsI4R/oe/Ua0cxKnveDg842iyAaNlF OEsFPZTg03LBFnpOjOl2CYH5Wq8yqyZ61dmNAsVLh7Z9rwUEm9zMIDi7izq+JGX3G2tb VheIeTmp4mXJ0SWMxvKNGxTr+4zEdbn5FaZdw+qSUa/zaxqJStujebnNOwHwz4hzMq5q mY2th90vf32SWHkDLKnY4s/NEYQPISTYw4zo/Ca804UL2ADVgIY0at4sMHZsQAYgVjU2 cjJINxI7ejPTr9eoC4iyS3GqAiI7Gw+PRfuTB/kygn5HwYVTGjuO27fLz/EyaxGnV0C+ Yckw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785467396; x=1786072196; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=aWHLEKCAQ5mV1sF9yyFHSMFUTDOduAtPgNwQ5RGsXm4=; b=JBbam+MDVRmIxFee4/kkTBMdZVXp/kyOPdHmwPqbkhTNwhVUCWA6ZzdvCpelJlCWY8 34ZKDbil0IMLh+IZWnVu+AWAqcNNe2TfOGG2gwfFcsdxtu26T0lINDSWCBDA+HNeLfKA iWX86Wv+WwU4EQ4Aw+inQxtq363k9H8qI2ZQrwu6bxqwvt9zU39iCT76wl8jjSFuw9tz MFC/QqZ/sIp/KXiFG+3lDFM+1zVx70cRU6W7A0J6/6MuoKoAbZgICgEaLrDBfm9cWkGF KVfW44VYvoEigNrwUwDxeR5yF3fvTVEzUv7hOUHM2AFviSVKswn+rkdoLoKUkwvzdJN/ fGTw== X-Forwarded-Encrypted: i=1; AHgh+RqGDfw+KFckmjKcbdzPdbr3iLDPY0+m1oAE3A4DubP70paoUO1oMjmDjVgJf5YvHHY+dyC1I7i5mLhZqRU=@vger.kernel.org X-Gm-Message-State: AOJu0Yxx49xTg8NN1UyZZjSRwKTqdZvh0t7Y/70J5oX1aPjaBPCy4VbP sYhyEzRFsHFJkPa0GY0fUWJzHv+POZ7niWQpOJbO+s7wkQHr3wFvYRX3 X-Gm-Gg: AR+sD13KWMKmaTFOwodb/729eyGSdsKWh3lpm4ePfYGJLiHb772cihEexBs5CwyPsaR rt1j8UZ8AvVQAxQP9+v1p3wcCbPUB0Qh6vRYmumwvfa206IphMSyvFiLQ8N2jicaLCvK38vR1ZA IL2Yl0RTjQHHAN0YBSuhpWkFN1VlPaC3SU612/z77HGQyPy22gtf/LTdeIjA0AgFLstlGVnsWGX +VaRJpkpH1LkNjXbto9k7gyplkt2/AZFnHEwYN+xcRuM3bTupMYEwsOMk5UyBBmU9IIfuDHCS8i jrnt6AaIai8UdZfaRqgkxduJ8zx8BbddNiis63Gj9WYn97lFDIxZyd//EDu7GVAJOT5PsPTsjpF rxnBOXykxOY906QSjzmo6fiMCxbrKGK7+BeaQQLtONB6RWSJ8joadjwXe2JAO2CN4LylyrW/iD1 72Aa4HJSV4Kz5Qy2a2r6KfiBxHgc7wyPNwVvflMMPfbDu51PqtmnQG9yt+AioyMFhNUbzYtLuE8 KWql7ZJ13T4xSdsbAR0M61GFqwaTQlua0VUstla4GXz33Itgnq3EAhX40471mX0v5oI+S2qrtBO d1mSYF8h+Ok70+01 X-Received: by 2002:a17:902:c94a:b0:2bf:dd0:c8b1 with SMTP id d9443c01a7336-2d046b34b50mr4660025ad.0.1785467396392; Thu, 30 Jul 2026 20:09:56 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d047ae9f31sm737595ad.60.2026.07.30.20.09.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 20:09:56 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Lars-Peter Clausen , nuno.sa@analog.com, Shenghao Ding , Kevin Lu , Cezary Rojewski , Richard Fitzgerald Cc: Baojun Xu , Sen Wang , Steven Eckhoff , Srinivas Kandagatla , Kuninori Morimoto , Charles Keepax , Linus Walleij , u.kleine-koenig@baylibre.com, Thorsten Blum , Kees Cook , Chen Ni , Bartosz Golaszewski , Shengjiu Wang , Sebastian Krzyszkowiak , Pengpeng Hou , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, bui duc phuc Subject: [PATCH v3 01/26] ASoC: codecs: sigmadsp: Use guard() for mutex locks Date: Fri, 31 Jul 2026 10:06:23 +0700 Message-ID: <20260731030648.8706-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731030648.8706-1-phucduc.bui@gmail.com> References: <20260731030648.8706-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Clean up the code using guard() for mutex locks. Merely code refactoring, and no behavior change. Signed-off-by: bui duc phuc --- sound/soc/codecs/sigmadsp.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/sound/soc/codecs/sigmadsp.c b/sound/soc/codecs/sigmadsp.c index 2e08fde3989c..b7dbeb237447 100644 --- a/sound/soc/codecs/sigmadsp.c +++ b/sound/soc/codecs/sigmadsp.c @@ -5,6 +5,7 @@ * Copyright 2009-2014 Analog Devices Inc. */ +#include #include #include #include @@ -135,7 +136,7 @@ static int sigmadsp_ctrl_put(struct snd_kcontrol *kcontrol, uint8_t *data; int ret = 0; - mutex_lock(&sigmadsp->lock); + guard(mutex)(&sigmadsp->lock); data = ucontrol->value.bytes.data; @@ -148,8 +149,6 @@ static int sigmadsp_ctrl_put(struct snd_kcontrol *kcontrol, ctrl->cached = true; } - mutex_unlock(&sigmadsp->lock); - return ret; } @@ -160,7 +159,7 @@ static int sigmadsp_ctrl_get(struct snd_kcontrol *kcontrol, struct sigmadsp *sigmadsp = snd_kcontrol_chip(kcontrol); int ret = 0; - mutex_lock(&sigmadsp->lock); + guard(mutex)(&sigmadsp->lock); if (!ctrl->cached) { ret = sigmadsp_read(sigmadsp, ctrl->addr, ctrl->cache, @@ -174,8 +173,6 @@ static int sigmadsp_ctrl_get(struct snd_kcontrol *kcontrol, ctrl->num_bytes); } - mutex_unlock(&sigmadsp->lock); - return ret; } @@ -677,10 +674,10 @@ static void sigmadsp_activate_ctrl(struct sigmadsp *sigmadsp, return; changed = snd_ctl_activate_id(card, &ctrl->kcontrol->id, active); if (active && changed > 0) { - mutex_lock(&sigmadsp->lock); - if (ctrl->cached) - sigmadsp_ctrl_write(sigmadsp, ctrl, ctrl->cache); - mutex_unlock(&sigmadsp->lock); + scoped_guard(mutex, &sigmadsp->lock) { + if (ctrl->cached) + sigmadsp_ctrl_write(sigmadsp, ctrl, ctrl->cache); + } } } -- 2.43.0