From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F14FC38839E for ; Fri, 31 Jul 2026 07:49:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785484160; cv=none; b=pvVfKFZm0kiTH9ezVVvylzA0uI+85PMZqhhG41EmSUuC5ZHVhFFCx3ETAA6ll1EcJw6YHO6q/lL+5zUXAEAyMi+ALkm0rNvt0DXivF6KlDFF1HLUPtMVUS6fHn/j7sP6tc5FN2htfTSBO9aBIwt6WCstjMqX986DPPOxhS5JY+w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785484160; c=relaxed/simple; bh=bS/CRKVVoQdAkaStuerHlYKMhi3opFXvVsPmcBA81Yk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FglnrKHcFrjHBY4JYzZRqEojY1LxNzxoAQ8Ov+QOcp7E5ZFTF7xrWdhnC8aB0aFn9iv1pFxg+1BGLJmn51MfPQwh8GWr8LdmnEzgS9AE52NaEmgStslq4yDPv0B+i2pX6TdCi2K0lOTyNeC+o+DyAN8/BkCrtx4+xl/+Q/6EDuI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qizLkiWa; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qizLkiWa" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-47f752b3423so545288f8f.3 for ; Fri, 31 Jul 2026 00:49:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785484156; x=1786088956; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bS/CRKVVoQdAkaStuerHlYKMhi3opFXvVsPmcBA81Yk=; b=qizLkiWagGmgDoYyTiHBpoXcCTYUx1geCpzWbBsiNKf7xI+YGVk8diW73nhHsrDfJn 0VY44aPFiwpa1uTPXGSQM6x7y0789c03k6dM5gcSMZtNp/fD3KaOUS6Ylb+jCgHcqtNP kUhIuZVVeuW0B/yLXjBvOG0ntH59XZiQK6zUTd2zKxS9OxCmZ4N1DuEfnxEBSQuOgEKz ifDoTf7eD6FtoPESF4tpCXVPT1t4qsNR59RzIBZv4hbMsqY8xhMcXRtkrYoZcTW4FP8f bJQA1nODMVQm+U0SCO+Wo0liGeSJQDyUxacs+ZPXB+X2HUQARGAU+Dt3ItFoamuDMNq9 rRRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785484156; x=1786088956; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=bS/CRKVVoQdAkaStuerHlYKMhi3opFXvVsPmcBA81Yk=; b=jNICHZKGWe3s1d0KK7V7Qj62Oo9H7QFRsB3bSclRkuSsYXWpTG81nNf8wZM07BydmX UTypciByGWpSVl0H9Nady5jekDi+0rAEvEujGVRYMRCIMpejnW55fhA68tucx3RsrJYp kXKE3kYEtkd0dOp7hwR1RHBMaP2LW7OBcuW0WSSwCTDRZGI39VwYGKxFOF/Qi4RPwQqs tNC0JAis2GfcOU7hxAchb58PAq0pP7yHUz3Z5SPhInbWS6s1+ixhYPEopC907mY7/eu3 fRgwKE+2UXTlepQ42FHshTBYGDx4ohuq5ecUswzCC7/tcIcl95/kUFF2xfNJ+IlRA3oV 2orA== X-Forwarded-Encrypted: i=1; AHgh+RqboRzDsYHZd2SPHwmGh1DhWXz7kzs4D33a8x0oaXJcHKKceHq5vLqKwH4MmbstGew4DVMvTjvHAA3c5X8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxu1qlRiwHTonIi9J+RB+bL0H1gGlM5KGZUyiovmeup8h4+p2j8 1Z6broIkfujmdEPOK2JKtivYC0aES3mVj9cLzCrl+GRTWahoyRLEnV64 X-Gm-Gg: AR+sD11icTzmLt0b8wUArtprUOXavvOkgW1bHflrRckEeqQcmtW7U++M5N0r/axza1E AlOfyXh+WKJK/4MgyNvHzD5vGo5cFATOABkOwMWWb0r6vwLZIHA6wLcVMFx6ZYD28G3KIX5AE55 Ph93TxDohHM17+hqw74Dk3Yyk/xHwiaFHCI2NQzyCMKoO1l0/b23lUTJ0cAMswE5zIgI9c0Jxns g2Lh03OffZ2NfJ7fxiLSXZOppkouQ4o/7lnqBhzemL/KBni07Dy1ffrtRnmhDGEc7NDNsJi5VbL NS4A4SLWEyvbjPMgFNo1DvGwK0w66bHOd0/LHSFapfMnYmfQheZ9ARUXq/34DyiHiUDZnHWC8WY QRDoypjF4SRc4JxcSHfoLvAS1pzHBI4RjiGcpit8r71KCaUYFzv51b5nbRBBtSq7oqjWNF7qfTv 1bqlkNBA/iI07G4K0PXdl4LQ6XghI/cJEyWwGy90toyniMcJswwG331oKOF6ckN6AfSroYL/P85 Ex6qLoc6qLbA8OSnGQPg6zXuqHsQLEHHnOghqUd X-Received: by 2002:a05:6000:1ac5:b0:47e:aa3e:e75e with SMTP id ffacd0b85a97d-47fd2abbb6amr2533204f8f.10.1785484155487; Fri, 31 Jul 2026 00:49:15 -0700 (PDT) Received: from INBSWN167928.ad.harman.com (bba-86-96-6-50.alshamil.net.ae. [86.96.6.50]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd41cfdc6sm2009280f8f.8.2026.07.31.00.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 00:49:15 -0700 (PDT) From: Abid Ali To: qingfang.deng@linux.dev Cc: alexandre.torgue@foss.st.com, andrew+netdev@lunn.ch, davem@davemloft.net, dev.taqnialabs@gmail.com, edumazet@google.com, kuba@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, pabeni@redhat.com Subject: Re: [PATCH v2] net: stmmac: enable MAC rx/tx after DMA start Date: Fri, 31 Jul 2026 07:49:01 +0000 Message-ID: <20260731074901.1163-1-dev.taqnialabs@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <507ad6a6-52a2-4c68-9ba2-5cc4f92e192d@linux.dev> References: <507ad6a6-52a2-4c68-9ba2-5cc4f92e192d@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Fri, 31 Jul 2026 10:11:40 +0800 Qingfang Deng wrote: > This is _not_ correct. Instead it's a bit more complicated, according to > their programming guidelines: > > So the correct order is: stop TX DMA -> stop MAC RX/TX -> stop RX DMA. You're right, the XGMAC TRM with me documents the same sequence. IMO this looks like a fix on its own as the current teardown logic doesn't take care of any of this. The proper shutdown sequence is a larger change that needs per-channel status polling and timeout handling. I'll remove the teardown change from v3 if that makes sense and keep only the startup reorder addressing the RX hang.