From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4983740B10E for ; Fri, 31 Jul 2026 10:16:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785492987; cv=none; b=IhmrrOkLHsxMJCg1O8k3MvWDwUJiFD8+/n7mJ7vPMbLoqnprpwJrAXWtV9vGOyhQT0r8AfZ3DGB3MRygmepKN9PJWSNUvCGiA+dj1tz5O5+poJ2qYlbnEYG6m4iD3AJ0TjdZDvBF6hNqRBauTdrSfOunGDA5VmWf2Hxe+nxfcrI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785492987; c=relaxed/simple; bh=tIZl0SczIAIEGn6ulaKByJ4cIgNcPn8uPvyKgIjiEDc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cSSHkm+65+21jpRMRPvrWvbBGaUBzRVHQp7GMvxYiL+sHVJ6Zh+1izjXtv4gzNY3oXBXRgdddTHXO3ouG8Oa/VZXlfOuFe4dGTRJfooZpaQoCmbeGbtXwKzl5tOwTlaWiWSEbDxMMKIdhar9t0X6CzWYbb6aGVJs2pkCSwnteqQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bsrcDyWn; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bsrcDyWn" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-3810c5d691bso708830a91.1 for ; Fri, 31 Jul 2026 03:16:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785492972; x=1786097772; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VAZMksOYurF3tSXLo/jShDOr9iNsQwZ9titE58N+ejE=; b=bsrcDyWnFB7QMJ8pAiJ+Rj+/PNpfhnN3j9oTePeL+L6LgUml9MpoOQDRWRtf0SsiiF yiA+/p2Fx0o+pJFQLgb5ebi1S5oGOlclGGPejPPyi9fICrg5gVICZYOR7IxgP0dv+YI6 NPUfMYCILy9zI5RyDjhrILFPIQu1Mxs0+yFWXwnDjC8w1X6tnApcB4u4Kfbp/8QjALnU HbE1aumDfT+ib1Jo8j8/lXtFE/tGUpzMGPasbNvy+p86mCNUcMI/kWctshVPUj1YN+lC 4/qzRzt3bmMf3wbVmK5iOYzs28Ca8rXQ6MXIdBIY71HXuVgFRCCjqrB6xC9jpF3WUiwR fmJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785492972; x=1786097772; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=VAZMksOYurF3tSXLo/jShDOr9iNsQwZ9titE58N+ejE=; b=d93TGzQkcWremCT9eYClaxvPQ/BYmYDj+8bGTVIGwCsf9A/08LAIXfT/A3JLHCchNd JK6MUvSoJHDl9NA9BdTGsZpvGKCD8/gqi1rTUYeyFcu1z/MRtLJ6sWqynSHTY7/0oRBz EvrJkpXJmJgZmJbRJE8kromnEJ6VMacdIDR6gWfJLT9YnXCgZxl0Ws6+3X5n5CUhue++ lRSIYYlwkrZz/5x2Pk5F7dXtKKwSLVsC0NunzzO431ggiKv05bDUrp0H9OdxYxK7joxG nBcJV9aXh3Gwh1g2OLqE8cqg6XVTsqM3CTYa7hHsye3DO43XeQ/E0yDK6psht4670/U8 pm2Q== X-Forwarded-Encrypted: i=1; AHgh+RpLep7zWIEAidolsRH8qBk5LyWdOXtH4vD9QrYbdK0+l24XtlzENI41pc7g0gLXgXSjt9gbcDur2WcwSlw=@vger.kernel.org X-Gm-Message-State: AOJu0YyGl7tcjdvtHqzILz9M5aTaZgZPRBiDJ5T6SpNDpwU7hAvGwK3e /Si1oqGTtwy2e1zjo0O24OC17Ce7yHfiH7UJs1mYOGq68LCdo/dx/Z60 X-Gm-Gg: AR+sD12vbHTJdjB/NFK6ewvch7al4YXr+XvBj9QKlx+ezPvjfeCZj66TBesePjO8+1I NvwH7iY1MxlchlX81GUPO+sqolJVqPK5SNb5U4yKHifyAoabIqNFavT6UlkSefOSioQJyUs6xTI dD7VrdkXcP6JYgSdFU/cgO7EiK+cNzZGks6xntaqgb8EmLy9i5ADLTQm9y2x4zNXMzbGwmMyhsD zu8XT3gvaGWAdj7r1fGuwtRxl2st9YthB0A1YVhapKaC+YlP5JFuN2mI48peLJIVEhXAtRbM48+ r+BHC4I27bDC/g6VnzPLgncoGNrzuPn6PVquNuu6kZGRZv2ZDNYyGmlkmzTWcVtqZsk6lBl1wJE os2cpmqROQu0VpQTr5ta+Ll/0oHryTh4HOelqLoqPP9gxwx+lB0pAVb6p7dRccHwABRMRGl2ocs k0jYeRsBV0OyoIxUMK9L8CCJyPG4Ov7gTWdta3QlkTGTZU1yeYwAGukjXr/UDF7wmbplI96GlHJ Pcjdtvuo6GErCtzvpWlz81W7KFC4lnIs25NFty77dnYexjkfYRKyjL26BoseYmz+ij3KE76axTt J4i2 X-Received: by 2002:a17:90b:4cce:b0:381:cef1:11bb with SMTP id 98e67ed59e1d1-38fb13e74femr1383086a91.22.1785492972150; Fri, 31 Jul 2026 03:16:12 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38fb2ce28c7sm509733a91.16.2026.07.31.03.16.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 03:16:11 -0700 (PDT) From: phucduc.bui@gmail.com To: Yixun Lan , Takashi Iwai , Mark Brown , Jaroslav Kysela , Liam Girdwood Cc: Troy Mitchell , Goko Mell , Jinmei Wei , Kuninori Morimoto , linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 2/2] ASoC: spacemit: init *dp to NULL before error paths Date: Fri, 31 Jul 2026 17:15:39 +0700 Message-ID: <20260731101539.36290-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731101539.36290-1-phucduc.bui@gmail.com> References: <20260731101539.36290-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc spacemit_i2s_init_dai() takes an optional output parameter dp, but only assigns *dp on the success path. If devm_kmemdup() fails, *dp is left untouched. The current caller does check the return value before using dp, so this isn't an active bug. Still, initialize *dp to NULL upfront as a defensive measure, consistent with how core helpers like _snd_pcm_new() handle their optional output parameters. Signed-off-by: bui duc phuc --- sound/soc/spacemit/k1_i2s.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/spacemit/k1_i2s.c b/sound/soc/spacemit/k1_i2s.c index 64510c9a1a89..23037fa4233c 100644 --- a/sound/soc/spacemit/k1_i2s.c +++ b/sound/soc/spacemit/k1_i2s.c @@ -382,6 +382,9 @@ static int spacemit_i2s_init_dai(struct spacemit_i2s_dev *i2s, struct property *dma_names; const char *dma_name; + if (dp) + *dp = NULL; + of_property_for_each_string(node, "dma-names", dma_names, dma_name) { if (!strcmp(dma_name, "tx")) i2s->has_playback = true; -- 2.43.0