From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B00B13CFF4C for ; Fri, 31 Jul 2026 09:53:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785491605; cv=none; b=TMIM3n5AWq6O1SjVZDq6tZujflbFwxf83soKPf4VhCdRCZkW6oyZ5heXQWetTSxJN3b/k2hIqXv8tb2WEZsnm8sQ284xHpwbq5HP8U/xJRqd9sQelFGTQnra/nqvGnJaBHcBVoF8vJ40IDs4e/bTfjeEbZmwHgZCL3RMaGm7EIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785491605; c=relaxed/simple; bh=O2hr3mgkWv9ZH0QPbcAjngEx9k1/2RVfWmF8S8xTYno=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hbnF8miAquMDgtB37GZpe/SH4vrzKWoFZkU+28vgy1iFbgYXEuges4nYLxr3uwuI7L43MLIsLQy9qu1JKL+ryowMQiKY1T9kQ1r2lJm+bSAUPmGMRsdczkBLuGsiV521l4WSxb8bpSlo36nu25fMH+6hOlL5YC3jAl7zDYgRN4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=peRiO/aj; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="peRiO/aj" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-47f904e80eeso699687f8f.1 for ; Fri, 31 Jul 2026 02:53:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785491591; x=1786096391; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=fwbZejQtpnuo86QdZNkvfiwPzfIoi9keDu3oZjpOvc0=; b=peRiO/ajL9HZlJB4kLNz2iyYZ5sS/d9c7VptVlBfxGBBWLKcTx9jlm1G0AdNrz+/Da U6L6LXKeohO81z+I4ZtbsoYg4q0b0nUgqfiWEqYLmsQN9dEWvV1Uqg4qKlNEVCVZJkbt u7TEL/bw0OwJyVU1jA5E37FZIKEnNTQGOmex+KdgUHPyPK8MWt/sbMDuE4siuEMeQxKJ pZXMJw2+E57XmDZv+9fbHh3c1TwD5jR1kscw8aFwIK7wXRETlrUVFc47mLWk5ZAP7A90 QPYUEe9/ATNo/502NgCyke64jg/Zkud6JS9JfLWjQs6iwjsOtim6sYYoh0TgQZ8ssZKY 8Z3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785491591; x=1786096391; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fwbZejQtpnuo86QdZNkvfiwPzfIoi9keDu3oZjpOvc0=; b=rKEoLXroodCP4qnqCatP7sNl6pMQwE3+2+Bmvw5haFj0RRu45hgx+g6k1j0ww9w47w uC3hPOApyGi3aqh/+A9OANBBTpm38l+m6ca2lTKUjx6IHDwKlQhVAp9vdiiRzU3sWttg f3QxKIBee0a9QuI/iDgV8jbawYwEL8ejzrur+RjTVTmXcXCfga5BRGCFB6z/998d67OM bup9McYyAZhOQI7LQrn+Ips6kmny8NFGpCstEKWBRgolRw8PnnfIptvpK4T2i5IUMRgw nMNopUdEysmRcPZNmG68lVhEDXuAW3aYzmA0f5acJm6rm6ntGTvSny9oEskQ4YYggcBD UY1g== X-Forwarded-Encrypted: i=1; AHgh+Ro5+ma7+VHwg4mNR0UdvuJ48JLLaPEtXY/TlsaETkfZhcTtZJzycVr8TEFFz9OR2qkr4nZcZ0+U/w33rAY=@vger.kernel.org X-Gm-Message-State: AOJu0YyeSbAVnzkt9CFWs8JJgXtgvQuOfTI4KHp8nvVgrIIwEaJamET4 ESl1uJjQm5YUgGViG5/IlhdVyQITumeoQrGwD1fgpdJ1/kLAiHD2vAp7 X-Gm-Gg: AR+sD10/ygd902n68jhAfOKvJV086fcLMbYws92dh0YDr1H8TbbrLrj9fSAZDIMmfkX 5qx7WKbT6qMuBT9TI7nt5Mg785/QO+7boU+1eeB2yf+3dbJbKpraN6jxReHal0miyO+vEiqRdLk sho7NtwYcYqnIEN0ND4Y0ydYo3csMfc+3x+BgqRMRYetilCXt9/f5qIVEXk6P81Zkoz7sbiZidp IXjQMk7Bhyn1ZAocTJEqimBsxwD+sUmr4HplncZBrXbr0PXVejK6dBBK7g6NqvOXY446Sz0wqZb yaLHaNbErDOMgbNtK2uAAOdfvRmmlgCiT91JntnRsnouyM3tZujT7zgDJXvkWoAVewWEFlN3VR4 wGK6UJkDwmuT1pNA15U4QEs8uAX27d7angFn43h77b++CmbVoea0hjirCpzSBVVMfUH0Hgpz2NJ c3z54to0zairUvpmcifpw3aBArW/8ZJ6NdZikV5p/1o0hkj+gBwYjTwTpI+4eZm5xCsVFRFP50k x4fRH7IV6OJcEUv7VFyv5+rd1h8wbJU0XHABeF/s/G9BzHAjysmhgyS7KWq6xaPkRS96noswhnu IjoTUTs+G6nuXvkxZo7ONdq/B48ZNjCtvihWRpeZesBPXxVrcnVTrmy5p5kXZ3x3qP2Xhtd+5wQ Kyag0LSbmFcL5VIOPNyreAcVvwejs9amfK/91UzkyH7WPWnmrFupXeyWB92x522t34YnRNKo= X-Received: by 2002:a05:6000:712:b0:47f:9254:d453 with SMTP id ffacd0b85a97d-47fd2abbdf4mr3203164f8f.8.1785491591146; Fri, 31 Jul 2026 02:53:11 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd45a0ae0sm2757970f8f.33.2026.07.31.02.53.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 02:53:10 -0700 (PDT) Date: Fri, 31 Jul 2026 11:53:09 +0200 From: Joshua Crofts To: mdshahid03@gmail.com Cc: Jonathan Cameron , Andy Shevchenko , Broadcom internal kernel review list , David Lechner , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nuno =?ISO-8859-1?Q?S=E1?= , Ray Jui , Scott Branden Subject: Re: [RESEND PATCH v2] iio: adc: bcm_iproc_adc: Convert probe() to use dev_err_probe() Message-ID: <20260731115309.000073a3@gmail.com> In-Reply-To: <20260730155712.374464-1-mdshahid03@gmail.com> References: <20260730155712.374464-1-mdshahid03@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 30 Jul 2026 21:27:12 +0530 mdshahid03@gmail.com wrote: > From: Mohammad Shahid > > Replace open-coded probe error handling with dev_err_probe() for > resource acquisition and initialization failures. > > This simplifies the error paths, avoids repetitive error handling, > and automatically suppresses duplicate messages when -EPROBE_DEFER is > returned while preserving the existing error messages. > > Also remove the redundant error message after iproc_adc_enable(), > allowing the error to be propagated without additional logging. Separate patch for this along with the removal of dev_err() at devm_request_threaded_irq(), see below. > > Signed-off-by: Mohammad Shahid > --- > v2: > - Convert remaining probe error paths to use dev_err_probe(). > - Remove redundant error message after iproc_adc_enable() > drivers/iio/adc/bcm_iproc_adc.c | 52 +++++++++++++++------------------ > 1 file changed, 24 insertions(+), 28 deletions(-) > > diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c > index cf4738b16e62..08e056468d8e 100644 > --- a/drivers/iio/adc/bcm_iproc_adc.c > +++ b/drivers/iio/adc/bcm_iproc_adc.c > @@ -522,52 +522,48 @@ static int iproc_adc_probe(struct platform_device *pdev) > > adc_priv->regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, > "adc-syscon"); > - if (IS_ERR(adc_priv->regmap)) { > - dev_err(&pdev->dev, "failed to get handle for tsc syscon\n"); > - ret = PTR_ERR(adc_priv->regmap); > - return ret; > - } > + if (IS_ERR(adc_priv->regmap)) > + return dev_err_probe(&pdev->dev, Given the amount of &pdev->dev calls, it would be a good idea to introduce a local `struct device *dev = &pdev->dev;` in a separate patch which would go before the dev_err_probe() patch. > + PTR_ERR(adc_priv->regmap), > + "failed to get handle for tsc syscon\n"); > > adc_priv->adc_clk = devm_clk_get(&pdev->dev, "tsc_clk"); > - if (IS_ERR(adc_priv->adc_clk)) { > - dev_err(&pdev->dev, > - "failed getting clock tsc_clk\n"); > - ret = PTR_ERR(adc_priv->adc_clk); > - return ret; > - } > + if (IS_ERR(adc_priv->adc_clk)) > + return dev_err_probe(&pdev->dev, > + PTR_ERR(adc_priv->adc_clk), > + "failed getting clock tsc_clk\n"); > > adc_priv->irqno = platform_get_irq(pdev, 0); > if (adc_priv->irqno < 0) > - return adc_priv->irqno; > + return dev_err_probe(&pdev->dev, > + adc_priv->irqno, > + "failed to get IRQ\n"); Remove this, platform_get_irq() already prints an error message, keep the original. > > ret = regmap_clear_bits(adc_priv->regmap, IPROC_REGCTL2, > IPROC_ADC_AUXIN_SCAN_ENA); > - if (ret) { > - dev_err(&pdev->dev, "failed to write IPROC_REGCTL2 %d\n", ret); > - return ret; > - } > + if (ret) > + return dev_err_probe(&pdev->dev, > + ret, > + "failed to write IPROC_REGCTL2\n"); > > ret = devm_request_threaded_irq(&pdev->dev, adc_priv->irqno, > iproc_adc_interrupt_handler, > iproc_adc_interrupt_thread, > IRQF_SHARED, "iproc-adc", indio_dev); > - if (ret) { > - dev_err(&pdev->dev, "request_irq error %d\n", ret); > - return ret; > - } > + if (ret) > + return dev_err_probe(&pdev->dev, > + ret, > + "failed to request IRQ\n"); You only need to return ret here, devm_request_threaded_irq() already prints an error message on failure. Separate patch for the removal please (ideally the first patch in your series to reduce churn). > > ret = clk_prepare_enable(adc_priv->adc_clk); > - if (ret) { > - dev_err(&pdev->dev, > - "clk_prepare_enable failed %d\n", ret); > - return ret; > - } > + if (ret) > + return dev_err_probe(&pdev->dev, > + ret, > + "failed to enable clock\n"); > > ret = iproc_adc_enable(indio_dev); > - if (ret) { > - dev_err(&pdev->dev, "failed to enable adc %d\n", ret); > + if (ret) > goto err_adc_enable; > - } > > indio_dev->name = "iproc-static-adc"; > indio_dev->info = &iproc_adc_iio_info; Also, you've missed an additional dev_err() in the iio_device_register() check, you can change that one as well. -- Kind regards, Joshua Crofts