From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E050F44C666 for ; Fri, 31 Jul 2026 15:49:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785512976; cv=none; b=S2XjYodanavTSV43krTIF4AjzdOeAuOY4VGr2UhaWDtPmFs4El5bmJKvzQqbftQCeC/bxhQRj4iDhiJekzw267tvzAnKIsvtRd/0tRaefDIHVSWkjQhLLL7GAjnkiBUjK0fWc0yVTJqNotv4xc0xWhl2FJsG3BoKRhrN8xGLBhc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785512976; c=relaxed/simple; bh=/RZ3/Y/ZlOJg5G1yVeQGiGHh8zDUuB5gPSaN4Pn9iwc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UJJ+gLLgNe6ny914ZHdzpCyZ+1JbqGqiu1mGOc8NASTMmJjuWZF0D6NSnqU32NVzgfGCuwK1MuUeX9nHSWEjXn7evMzCiLfH/PMRGMoxy+iiLMSxOvIbCXPKstU2XBBivsUCheY0cqTP15yWQ0/BI0Gwq8SnXxT0r/uJOCBVlmY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=prCfQF4C; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="prCfQF4C" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-384422b05b5so151706a91.2 for ; Fri, 31 Jul 2026 08:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785512974; x=1786117774; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rtE+fcyTa/nEHTvbkkFzvfqX94g1NeErZWdBjlXHpz8=; b=prCfQF4Cw7OWxaJPDxrTn6vvTO0Q+IrSY4RYaRd497q8OHEB6yjpX9V5+VfokNmdRn 6VL5xeSXManjLzcvGl5bj0M++h5XQ1mQDI84NBxJJbsSRI/x9+1riBL5b6+gx4fSY89W FpqdSMKAekKD731M8KfNKwYdVPcEpNKDn2kBJh2A4TbXF8nZoJt/OEOAD7TrqVnZm7Y2 4YYLouBJZ+C0rHa+n77p1biRWxihsIMt/vTM2erran+o8+tUGx2E5c4PB24jLyE5ajNA K1BhEEQ5SxP80TDbGTyQ/a2rlI4O1X1MR7fK27/DAu6MDzQaZtw32G9yftsIc9/QIi9M /05w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785512974; x=1786117774; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=rtE+fcyTa/nEHTvbkkFzvfqX94g1NeErZWdBjlXHpz8=; b=ONwrt21vqWfdlaPM0MjTS+slXHrEfNsgAZWIGv5ZjrR7EnS0PgCX6NTnPhi2g51INw 3BqxlKcxN9E/iDsLnDTZkdgKFCzVRxCOOojAlb8l80dK3HWeDPruoYaalOwLizlck+at BXW52upoUrkzjGHfl8OLGxqRBwEdydeC4+Wvj+4aafdJ3BLFqxgtIKYeY4vv3U8UtKrS 90K18XPj1la8PzyEFfMMXmDLEyYbYtEOLmdQjo9vIe7wJeYGOSgdarpD/UfkVV4+Nrj8 YMMXvYeIripk/7sC+Gy1bvDNN1H3H6inh4JEmrSeaYQahmDHTR8qH3BqD78dx0IKeWj0 mq6w== X-Forwarded-Encrypted: i=1; AHgh+RqVWixbjmQMQnJSF8deMM0rycXOH/5LRNeKpdll9MvCeqYeDv6xB7w/fHJjJNNNsqSjS7NXtEzif1aYlww=@vger.kernel.org X-Gm-Message-State: AOJu0YzVEmX5ySTRth2+9FX1B5NWXe/roz2SzjzK+6tdom73aSW4pQtv T0m4p3oSUMf6valfpRak8qGj0rMe00Qfc4EPUA2VkvVL9us2YtcQHpgFxsDwDM9qD5w= X-Gm-Gg: AR+sD11yXJX2kjDL2+qoFnSxFhfvCOdC2q/Tt1dhdabX43jvkMcHk5d5gtiotXRepP6 Cgl9SIW+yuV6dAs0gT0F00FWQ+6XpTpicZPOxxmSdr+Mmg4stq2jJ674x8vvrwfwOJdJ/mWt3nh /OL+GQ0joOCHqKPp1OK7t3+Uw7mxMdUgZy1EBVimMs6lLGtl5i2hqHSVOLlPVhy29GqSxiQrBxY g1upEKUV9yHZsZqMlZ9H/Rlw4ZjOfw7zUI3UP+2a1H9Rc/CQ+Fe4wu1MIy8rFPlscRyghqaz2qU JKS6JFFTkN7/iwqI5SpHbA4xwSgMkRK2+0TW7NSFrl6NS2Z63SuizUzb1mnsOXzOfOqm6ugWbEg aMQ0vVFjzXBHnUmJ5q9drHKqQAB/1NhS6cqmRFVhQ/DoVvjw/jHMvR9ROjKgdNJJAUfOqtkRDKy pMVkms5JRPOK/UqHCDmphQ6g0bjj2vbvwszjk5VNpBpiChXbWByeIJw8tQA1H98agefu50TxMQs KqDumzwHy7IzQ== X-Received: by 2002:a17:90b:3cce:b0:383:5a16:bd67 with SMTP id 98e67ed59e1d1-38fbc58abc2mr441543a91.4.1785512973970; Fri, 31 Jul 2026 08:49:33 -0700 (PDT) Received: from Potato.tail66a299.ts.net ([171.76.83.76]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153e045016sm11852510eec.19.2026.07.31.08.49.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 08:49:33 -0700 (PDT) From: Shivesh X-Google-Original-From: Shivesh To: arend.vanspriel@broadcom.com Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, Shivesh Subject: [PATCH v3 8/8] wifi: brcmsmac: ampdu: clarify standard compliance on QoS change Date: Fri, 31 Jul 2026 15:48:40 +0000 Message-ID: <20260731154901.1822-9-shivesh@example.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260731154901.1822-1-shivesh@example.com> References: <20260731154901.1822-1-shivesh@example.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Shivesh Updates XXX comment to properly reference IEEE 802.11n requirements that all MPDUs in an A-MPDU must share the same TID. Signed-off-by: Shivesh --- .../net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c index fc7a5dd2e5d8..3fd8bdbd35e5 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c @@ -516,12 +516,11 @@ int brcms_c_ampdu_add_frame(struct brcms_ampdu_session *session, return -ENOSPC; /* - * We aren't really out of space if the new frame is of - * a different priority, but we want the same behaviour - * so return -ENOSPC anyway. - * - * XXX: The old AMPDU code did this, but is it really - * necessary? + * IEEE 802.11n standard requires that all MPDUs within an + * A-MPDU belong to the same TID (Traffic Identifier). + * Since priority maps to TID, a different priority means + * we must close the current aggregate and start a new one, + * so we return -ENOSPC here. */ first = skb_peek(&session->skb_list); if (p->priority != first->priority) -- 2.53.0