From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC9FC44781A for ; Fri, 31 Jul 2026 16:07:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785514036; cv=none; b=rHtmjW77PbmL/KEIrCdW8lb8yyDfZkLALQClHSS7KCL7V/JH7Gz6vGYiC8egkqFVNS8O0bSoebEQbTIJa93wEUE9I1lw/oAwe0ll0gxJUve5DuAkWNS4ut6+s7z4y3sTxY12pNCUf7l/SZJwhm2fS5dFxHW8h8CT2n/xoQwO7vM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785514036; c=relaxed/simple; bh=X64FuFu6MQR0e9YLwzcqtBlBGkOJCZbkezV6SD9jPJQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E7yzJn68I1wIci2uoL4tx8/SjIA6/4Vr0qAKeySbl3cGAIUcmTpmGnjoZSd2j4TWRqjwkzbBACmJ16PKbsNFRAaymjCOaxgwrDPV/dlgI8nfWj2Q//vaG+h+08sVNYzwA3lk0inqyAaN1iKgSAwYG/6bvUCbpwQi8P518q/sYZ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nnzfgbrs; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nnzfgbrs" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-384422b05b5so154017a91.2 for ; Fri, 31 Jul 2026 09:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785514033; x=1786118833; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CVffTg0thpytBoHWaWeNh2vyHkkqNffHnf4NKS93HWw=; b=nnzfgbrsDHEjTm+KtOiHlc2oaDafOoXy76kkLEj+D9Q0vLeqlOTAbjvT1gx1sXV1t2 4a/zD4kNhMVhsHUVyDgWaDPeucuwleym4rPhC7F+9dwSdeYIemLV+TrILBJHqSash00b a6VoC6TBCWNEqSptqhI8u/2kxsO4t0Cph98xXZCn6w3cMuR8QGUQKJcTkkdZGEqasHSm q9RW5JwW9x3fxX46lRrJLHwZt57iZVqPvBXi+wwkt5L9OOPRhIeJ9OOZb/EC/2LFE7I+ TKK1j907e0tUCKF/kdUOt6i9WcWi4dtXDT6qIykoIRn0SX8PTM2OFmdo+ZXycBZ1sS6I 3cTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785514033; x=1786118833; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=CVffTg0thpytBoHWaWeNh2vyHkkqNffHnf4NKS93HWw=; b=SdesUH9wt8Twqow8fhQciOsT31CZMF84+oHlNG+fOIZKqfNlxMQSw+s3MZWAi3751+ O6LP2iHBTF9ygXq2dtiNcryCwtwwD4fr0Gp75vd4k1SwWHDQTej0GoA0u2PIwKfsjPPk 5711apD5mRwtGhME3Ao+HgGccm8kngorhYaHuS+3FqjtXQS7sP9oRtp5ScbFUfCTA/sr kCXLwTHM8JreOhWDcueqf4/BYNRVNWKnzuzjCQgosC7TftilW4F4TPwZdHpIU+DgFOpv h7IY9vzuVWaaJSLcgYNjBjgM8bul4LY3dRre536h5X3KCq5c0u2toix3Ks91PN/VsnwC Yzsw== X-Forwarded-Encrypted: i=1; AHgh+Ro9W0YNh9akKRRbRt5xJ/6IN6VbJKL7h3GpQDuteZSdo2qpWwRt3TXN7JOHref7UVTjacWSPBC43lmHm9w=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7ZTMxduqrmx8IGN8k+AdqiziCndXb7d/V8DYpzudUMs0HWdGx YJ88XSm0EyQvXYK5nPI0KLDe3Q4kk/WTPx9fbY1OgGrYEM5dCXdr7jXe X-Gm-Gg: AR+sD11R7TRcPtTboH+INpbt/9VeZ7jZmxyFriVD4HpcWK/0Jaoq3DgY9eIsYmrpNdp FXb6Rnkiotgv72GFdjRhVD78V6QvTdgh82ZYSIJIZz7aGq8Lc7tnQlkndV/Flu51OTkU4fVvoP0 3fvb8iyJdRPsU4USZtVROI0ZwaN0uIDNrQp6qHItvGRz9TCdSVTtWfNBrRKGSW8A5XwGi3rRnvT 8DzqzEC/HAxQIl8Rl9GEMPQp0lv2RREp7TJ67xObVHBbu0YIp+N/o4BOYQFYSr5/XpvX0vDHMXT Xg8e2P0fFjY+al9XkAIoasiVtCDK70khyZh4/8KIBoW1M2Y704PZvIdklRpaeYwBUWcaQAS0WPt SSr1hkyXqxfE/7o7MDNaNCvJIS/pYkwe2VC6Ileu5dmVxD39UkCXJU6WS3t9NEj9Dlh3Befaoxw UgHt/a9xeca6wyhZigm/ptdbH4JL7ZmK3ZwoEFpDYU31TzxmbvEN9nabK9VtgBiFj2Zc41yFSqk K/jDw/6 X-Received: by 2002:a17:90b:51c3:b0:38e:6a7c:abbc with SMTP id 98e67ed59e1d1-38fbc5482f1mr684483a91.3.1785514033358; Fri, 31 Jul 2026 09:07:13 -0700 (PDT) Received: from Potato.tail66a299.ts.net ([171.76.83.76]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c93dsm7881425eec.8.2026.07.31.09.07.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 09:07:13 -0700 (PDT) From: Shivesh To: arend.vanspriel@broadcom.com Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, Shivesh Subject: [PATCH v4 7/8] wifi: brcmfmac: fwsignal: document safe no-op for duplicate MAC handle ADD Date: Fri, 31 Jul 2026 16:06:24 +0000 Message-ID: <20260731160646.3812-8-chanelshivesh@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260731160646.3812-1-chanelshivesh@gmail.com> References: <20260731160646.3812-1-chanelshivesh@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When the firmware sends a MACDESC_ADD event for a MAC address that is already registered to the same slot (same mac_handle), the driver hit a TODO comment with no documented rationale. Per the firmware protocol, retransmitting an ADD for an existing handle is idempotent; overwriting the entry or reinitialising it would drop in-flight traffic queued in the per-descriptor psq. Replace the TODO with an explanatory comment so the intent is clear to future readers and static analysis tools do not flag the empty branch as dead code. Signed-off-by: Shivesh --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c index a43f1a38b0e3..3c1ca355e8ee 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c @@ -1037,7 +1037,9 @@ int brcmf_fws_macdesc_indicate(struct brcmf_fws_info *fws, u8 type, u8 *data) } else { brcmf_dbg(TRACE, "use existing\n"); WARN_ON(entry->mac_handle != mac_handle); - /* TODO: what should we do here: continue, reinit, .. */ + /* Firmware re-sent ADD for the same MAC handle. + * No action required; it is a safe no-op. + */ } } return 0; -- 2.53.0