From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3DDC449B17 for ; Fri, 31 Jul 2026 16:17:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785514648; cv=none; b=A94dut0fSHEAzd5x6O//qfjl22opUGQr5ScHZn8Na6osQlebfCp2Nige/6hARQGdZvgCebIPGXKjnCzCBClLFVBzvgo+7rdIk7xEbtgYIBmZjYRnnwOvtQJwTZE1jo1tg5G8DFCk9fC0yjb8aOa0EkxJ2rMeWSP553gVf440MxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785514648; c=relaxed/simple; bh=5dw8t7NiDICBtbn8fGHHub2PapuJ96cesqiy9PAh7pY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EDSWpcoApBJmQloa3otbfHwKNCr9puOX8DZ2tUQzrLBk11DNBjgISoeGUhBjOFFEO0fC17n+m3WcQMTCOhLIi3edc0rRa5G0HdO7CI1pQbMP64aMvA07cDilS7SRl3ihA2sp5IwMkqVFLCUG6NI5NrrFdB1L1O9BIDCczcm9iqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=khkS+3P3; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="khkS+3P3" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ce7d2adef4so17907295ad.3 for ; Fri, 31 Jul 2026 09:17:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785514642; x=1786119442; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=bewKPbnrjrTcQjZUlJ1M30GgoqVY0S60b2kjgYZAO/A=; b=khkS+3P3bvQ/kwDgAh+bKxqfmuNcRa2sYhgfKfxPo3aulQCta1FG8ZyWuE5rneFe5p 2k0yMihR3gcsNwXoBjo3M+1Xa5yBpZZhItMtsdUWdBz5rHlM+ItBr1y3C2Qw4A5wtD5z x97wtl0nYqctD9MP3DBjcI2DI7ck47tSKIJ1dQ2qurFfu2zkfdTrVmA2Kg5ZhseBnUvA tt7K8NpxdrI5xo8sbQWc/+0TVEqtnD1hWwBw2cMgKOmkZj8VI6Hiafzg1tfgzRENFepx zyb8gt3dDBp3iX13HqN0nhKp7eXdvoKVrZYz13cK8Vy4Ph10zbuvbOGkHn0ZMoNHEMGX RN9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785514642; x=1786119442; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bewKPbnrjrTcQjZUlJ1M30GgoqVY0S60b2kjgYZAO/A=; b=VwH8CGERFZWEEAqwUAF8h7A8MiQn+gTJkjF2FBbxAiuDs/xZ+T4E768WOcwr2l34uh UrT4fCM+9SZWwWOJRSadhkvePjtMxf9XmRN+gcHdIvuKjA75LMMfT6kLFWPw9kzC7Ibu ndl2tCPDXTQW2iYwZGCxLG1K/MQWZQW1eqWoi/7h15ENrdB1oBXDftnRLNV6XEtvaTOv ShIZ4w5U3xNTgkg23f1kMYKH3gtdwR7im1EZh0jA9jdsxyxubD7qH3s4mx3bPx43t+83 3MfBnW/AgdbSCBh3rUA5zA6/luXEeWCgfPaqPQB5E3c1j0E2z+7/LazI1XCmJiC5Yx8B CoVg== X-Forwarded-Encrypted: i=1; AHgh+RrWI/CLvopjrQhx4Cd0JjtppAc54BNcKttHV6fhJTQ9t92HPoVwc116Y39KuMt1njq312LwEH/L3gDStfU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4l1RZk6id5/dLYfz6inUUdUeckKkt9ugo0n1ytxpHVUY1WjCb IlCNdCMVo7Vg0z8wMEO1gmkUl9LfaHD+PQ75yfhRlKQVz1RYTlXtDvU= X-Gm-Gg: AR+sD11sKIv26VrdrCET7t2ljodZK8V79EBtUHNlUbHorP4FmEeIDjdIb4anPYdnRyM I9MzjGAi3H/DcyhUnt6mIotr6KOrHMCpZWsReAaTPRvxWUrJ0E6xT2SFR8FwCo/ksHN4Wqg1xSH V/d5byXgR9sapADEE6YSD2iCAGLthssDjY+pPYnPI8GeFzJgq1/AP3vngHXEV68sN/N02hnGtd8 tqHFYpZe/iaAO2o+Yd0Cv2oER6TY+P1eJv+oe4aNuQ7b4sEaAnQK9WIj3LDbJsBZ+aXIFBsj1o8 wqI9Cui74QSMc6ajPNlZ3MRxJqie2PVrYiXl8pGPaSXMGifplE8iwBLfxmQ/ZmeVMhJOnvZpHQh xnGRet/zGpGjOWAfH+9Ip3e71TqlsutNTOxhYEIVuMdpCxM3+1vYUaLuJh3bF6/WKZqvl6Mmrhw gREX55HTBWtekne61phVFpJXuLNL1qFzWVmIucfhQ7v9fWxjLSGRzthIRR4Lbrm81gxxxocM7Oy MSesfBEKwbM31uzKZImZWmL0LS1/zmGDBQyELBnDvQLUEHHFi8XcgsfOxhtU5GJgZv4jozDjhxV agUoUC5Kkcrv96OpkYX16aM= X-Received: by 2002:a17:902:ebc2:b0:2ca:d91d:d3a7 with SMTP id d9443c01a7336-2d0521a56ecmr6508995ad.10.1785514641927; Fri, 31 Jul 2026 09:17:21 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d04b15d27asm7258775ad.78.2026.07.31.09.17.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 31 Jul 2026 09:17:21 -0700 (PDT) From: Myeonghun Pak To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Myeonghun Pak , Ijae Kim Subject: [PATCH] staging: rtl8723bs: disable SDIO function on block size failure Date: Sat, 1 Aug 2026 01:17:10 +0900 Message-ID: <20260731161710.44828-1-mhun512@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit sdio_init() enables the SDIO function before configuring the block size. If sdio_set_block_size() fails, the function jumps to the release path and returns the error without disabling the SDIO function. The caller then frees the dvobj directly, so the enabled SDIO function is left active on that probe failure path. Disable the SDIO function before releasing the host when block size configuration fails. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c index c43a0391a5ca..47e87aaf76e2 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -122,8 +122,10 @@ static u32 sdio_init(struct dvobj_priv *dvobj) goto release; err = sdio_set_block_size(func, 512); - if (err) + if (err) { + sdio_disable_func(func); goto release; + } psdio_data->block_transfer_len = 512; psdio_data->tx_block_mode = 1; -- 2.47.1