From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BC393E6394 for ; Fri, 31 Jul 2026 16:18:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785514704; cv=none; b=uaJC3c0uMU6728bGgv2jlGe5y9xyZDU0olaJyNap8Yucqg5SWlW0KSgXVg9gWd1AcaEXdIZwosBa2uVGnqd02aP7d8eEh5NSGdqDgEqgWS4I9njAEYWPqq5FuLA0dYmZkIy4VyNnp2JVfv3UuO18klvdd8DkGyoKUqlm68VU2q4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785514704; c=relaxed/simple; bh=YOAC5Iz8b4Wfr8gFSlts5gUsGsYV93JUg+dXPJSubq8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RHe4Y+DqlFZ1mHqhOxeIh6JJ0dzZUDXBUSZ/M0MJKzONirvTgBsjPoEwYujewoN18enOHMwDv3EG7UVA0GXN0gNAH4w4cQwpgEoHfZ9RLZoDlUJOo7SKe6drj677B8nYOf/uelj/j3Ngw3jk7De/9IJMQOP/ozOIKQ0p8ptgwT0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sX1a0SK0; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sX1a0SK0" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-8486ac3f347so2291677b3a.1 for ; Fri, 31 Jul 2026 09:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785514702; x=1786119502; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EkiEIruiRSk3N9UIDQ+4txiR4UPtQnB+oM9OYfyxLPI=; b=sX1a0SK0Ddf1AB5GeYJVJTuMJ6cuSQSwFc8i2AOuXuLkYEHQas6DGP0PqU+X2G7EiM tzFqT5Ozs7EkEa0v4vDCTV3qcXFfZO2ERc5rZ+oaU6pQPLnoXa3YP5YU1eEEF4ocmx78 I48pF0bNI2EqWcdGpDcLbpO/rS3uVeUytAAF4zch6IX0YyYuhDEABw/s+/DXU1gWvoj4 8kTJYcYI87FVzjV89JpLGu53sIpqORGq0Nmt1dj5EMLXn++0de+/z757mv2K0N6xDOpu iTE9LKCu9zUwJdJbQnR/D2X7hDjUrrE0JuDtFN0W0WzdcyWlazzCmjBgKAJd4wvnLrFf +bLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785514702; x=1786119502; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=EkiEIruiRSk3N9UIDQ+4txiR4UPtQnB+oM9OYfyxLPI=; b=rI8+sb7rVL3NDEipqmF07i504WPDwrArVkb5gWCkvISOLh3huBa512GLv+NpXYbwlT spCfBvSNHrEm2gv0y0gOImfJOo1Q93603sjxRi02hkDERgIBDHLW7pwrWQKj6IeyEF7A rLjwMaNx8D19yPeIrZmsClIvUvCtDvGxspsuxuTvXAad32LuNq66Ho5buesdDr7sxV+X w7plhsEnVozHDPIivqK8o+j+689icBblAnIM6k6U6Q/7Msj8ZxrhCKNQvTyc3Fbnt9eW inB1Dswdm0u2rdX7CkxlSAeyfc6Q1py6JA1glxNIo+GALMCb8JIRaDD/y/g7WuTlD3UL kqWA== X-Forwarded-Encrypted: i=1; AHgh+RpMqh3pbfqQeK+abRPMd+FUu0CTcVpwlRpkxgnLTyrCsDCp2qIMhByF/UqHN1yLIU/F2Lk+5NRNE+3dWLo=@vger.kernel.org X-Gm-Message-State: AOJu0YwpQbLPMwAYnWKEj0IgWBm3FoA86Hkug7pe5qL/Rcb2M95hY/k0 ca+ybjMldQ2sFrTPki+5e27eW/fclAEIDqPzNK6CrPwtkw9sri4x0Rw= X-Gm-Gg: AR+sD12pHqXHo65LT8DrYgDULWvFax8l+X8/FI7bmJNw/f3d4boJ7D8hbS9qavhx4e/ RT6PZRYgtOjsW7nl/cyiVsSABr7i8/ZrvWofpN+IymqpMOESuXVOvMQNriI4M5kpjjdAFUpGhx4 DPOfvYuXYfeRd1anpjWSvX5Im2oB24+9LO0konlGSUiRJSW2Ukxmv4Uhlzecf05K3VsL/ADxFYu R3fmJSPXs9Q7NqQcsjoCv5qmIMQuhQjm10G7zW0Ueeplo1G7PG5cxwvdu6WjG15YRgbPOig3noC U2wzQqB6rkd684CAGlErqYA/ApX7IfzWj2RPZhj4srM16IJ9uO8sNK6zeFQiG0ZnmgrHPZ512zU pwDVpFFMBMMosGul4n6pELEgisTDt/e3QqPfraTy0rBx0kDlX5+snbF302cYv/08xiJ0dUMVuFP gRGN21PCvmZ0Iooo+URKoPciyd+JQSYV/YX9GZ+zxAksJ3AH4nYW5MIAIu4NqCcIWgSUQ08xEgm FFWcEtcYyKoNgnlWJjIYSL5PSADIZ7CFIhR/RIOKmr8WCW7b/UXuSQeyJvdzmk92u5gtnKd7s1M 6/scYD4uACNqvXg/kINjuxs= X-Received: by 2002:a05:6a00:2d9c:b0:848:4ee6:4d0 with SMTP id d2e1a72fcca58-84ed7483c02mr2063804b3a.23.1785514702344; Fri, 31 Jul 2026 09:18:22 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84edc29e6f0sm647072b3a.39.2026.07.31.09.18.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 31 Jul 2026 09:18:21 -0700 (PDT) From: Myeonghun Pak To: Greg Kroah-Hartman , Jiri Slaby Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Myeonghun Pak , Ijae Kim Subject: [PATCH 2/2] tty: moxa: use pcim_enable_device() Date: Sat, 1 Aug 2026 01:18:09 +0900 Message-ID: <20260731161809.45066-2-mhun512@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260731161809.45066-1-mhun512@gmail.com> References: <20260731161809.45066-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit moxa_pci_probe() enables the PCI device with pci_enable_device(), but its failure paths and remove callback do not disable it. Repeated bind and unbind cycles can therefore leave the PCI enable count unbalanced. Use pcim_enable_device() so the PCI core automatically disables the device when probe fails or the driver detaches. Keep the existing explicit BAR request and mapping cleanup unchanged. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/tty/moxa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c index 680b2dd65462..02220ecf3b38 100644 --- a/drivers/tty/moxa.c +++ b/drivers/tty/moxa.c @@ -1063,7 +1063,7 @@ static int moxa_pci_probe(struct pci_dev *pdev, int board_type = ent->driver_data; int retval; - retval = pci_enable_device(pdev); + retval = pcim_enable_device(pdev); if (retval) { dev_err(&pdev->dev, "can't enable pci device\n"); goto err; -- 2.47.1