From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f227.google.com (mail-yw1-f227.google.com [209.85.128.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 136204562AC for ; Fri, 31 Jul 2026 16:37:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.227 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785515862; cv=none; b=uSbUQ2Kd6InGJfie0el6IuSTQjQsO4c7LK7p3BCvVTSwIBLaCMH/aJmik15A+tDzSyG0OAcUESuxBmAj/iR9GkIq5UQtiS8VXskvs6mROaQWV2uLf+NbypmcrOpQF2QCsljfWcBAduF7QAYEY4tuSHEWJKOKmfNQAaBobGc2rHQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785515862; c=relaxed/simple; bh=/AHuTK/EWIh6mSL+YYtp1VcqATQuiVubR8zEMFzuA3o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cnPlJBfviUqdlfuo+Wv26ffAltAw5ZSuDZKkgHjbNlCuHRSKPjddRVKLvlcTxFym2id4G9t27AD829IQWAkEVp2Hl1w3UqNsD3QNUgUgt8HKBi/ldH3XBgjdXruDsnKqmhlrJJEDsjqz8zNsDjtsrs8YwWKelMN0Z9JD1uNIiLs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=hqVRRmbV; arc=none smtp.client-ip=209.85.128.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="hqVRRmbV" Received: by mail-yw1-f227.google.com with SMTP id 00721157ae682-81e9d8f3289so17386547b3.1 for ; Fri, 31 Jul 2026 09:37:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785515860; x=1786120660; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lRdwnNt6x86Uy4JXaTIBlaSrTz+xz9fM5aVZPxECWm0=; b=T4nbQnSeGBR6q+ro5yoKuKQNdbY0ea1gr+9Zp9/fhVpQM8HAVwSOfXju1ASD+9ghBC SPlZmwcMGJWNRgp8AfT3MTOHsrTsUgfKuVi0qSUVrm8ZLCGlRJ5pHGifel+pPdMi8BVe DDspMSZrdWnD3wYZHKrrfFeelnUKeGxezHVnhfe1g++hrpUDQbH1ILle2/7Jxm/fTg17 rqmWsKFzLpa8It3A3HbX8yS4Dlwdw1kGrR1TLgn53oBNnJAaUJCBkhpDE6ab9DBKeZc8 Ghu21WK9XEEj79f/wwQixOVZRdTEy9bQZ2ZD0lNPPZkQCpA+YTfJv3xAmYnqf9nTXX4H Ta4g== X-Forwarded-Encrypted: i=1; AHgh+RqX7iv9RkD6w/vcjChgY9JBYRsJrHmgx3ijBW1Rq68EB2h/R9D6aM7SvmiNQlrThoo2t8sbod17byLBYsY=@vger.kernel.org X-Gm-Message-State: AOJu0YyWARHYs2z97dqInTVEcM8Z9S3PwxSzF10yQhCDcex6WIKnzBpx 5MrF6z+KaRAcKChBL1/K1zpctSQD94F2B8IbgsHxxKDTcr0pS/H3XinuSq/NUHVYI67OUBxhkSp KFbtG4lCOP+PoykkSzDkK7cVax5FHQasgkewrFcaZngcvPvmNJsihs/hDPrhVutKzfLV0EBiPJ2 s65POXFIHpRZaDUlDT/g9i8WU7y+abvQ4NXcyv8GLrGcatofoE9/3j4GlDH+OVRR8ERX+xgkpCV 1c73dHnbF022v2PhQ== X-Gm-Gg: AR+sD12fFHPqEqtWyOd/98mF3aYFF+oHBoYXgWSHMBFTp4pS1rl0QnOxZmZN4lqXzlT 05Cr5mJwWSDkGQ5X/w0GI3bGnmH6PcE/L4CwpfziCCy68werordGR4A1k0pE9gpZtpsLGH4KoUt F5Ger7kT66uTNojIjQBrrt6AE6C5XLJcgvoINrVAUCj4cli9VlBMeG475VZngWNbGm16eRWyRRE oPBjZYxvhVvwp4kR9/MAuKsAfd5t8FrMjsk3IQLa3oQT6n0wGsovCXr3j30+jZk/WrumlkYPaC0 Jb5pjTKVFrlBK8jI8H+YoFfH8XQiAFrqn+iYKZ6rmC3TAcXbZbjOkfN6W2UyTEAP4tD35ZBuRul xS8j3gO/HtfGFUqB6r3aXslc3lWr+FATdOvVX34mmsrgiNvG3GF75/c5crqUFAzIOwcZWimw2fW wL70lVHnr2JJWONCGHHUtpUmyetsDskhCvLQ== X-Received: by 2002:a05:690c:6506:b0:81e:45a6:bd52 with SMTP id 00721157ae682-81fd4c7f0e3mr6403267b3.34.1785515859801; Fri, 31 Jul 2026 09:37:39 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-27.dlp.protect.broadcom.com. [144.49.247.27]) by smtp-relay.gmail.com with ESMTPS id 00721157ae682-81fcd0add7asm921607b3.16.2026.07.31.09.37.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Jul 2026 09:37:39 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-8486c3411c8so1595127b3a.2 for ; Fri, 31 Jul 2026 09:37:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1785515858; x=1786120658; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lRdwnNt6x86Uy4JXaTIBlaSrTz+xz9fM5aVZPxECWm0=; b=hqVRRmbVi5Y2FiopOcDQiIB5Jucu8w45pd1ytRkWV4AVD8SKDl5MXtj/3S624TdE64 JQRYDN/hk1IWVDDNu3gRkXCGnA/zLWtC4AmHDdlj0HiLMHe1X0SpZoUW25x73vsByBiI CUhMHQUucUhAkLL+VG6xK3dbvohkf6p/D9wGU= X-Forwarded-Encrypted: i=1; AHgh+Rpx0rUzXRRRUitZzj92OG7UlUUVlNjqPikvO2LRY98CxyNEHPrH7K4/0+9FSCrsnC5nO5PfTp4dJ4qFVKo=@vger.kernel.org X-Received: by 2002:a05:6a00:2e85:b0:848:2f7a:2e5f with SMTP id d2e1a72fcca58-84ee49a5970mr282214b3a.78.1785515858448; Fri, 31 Jul 2026 09:37:38 -0700 (PDT) X-Received: by 2002:a05:6a00:2e85:b0:848:2f7a:2e5f with SMTP id d2e1a72fcca58-84ee49a5970mr282178b3a.78.1785515857974; Fri, 31 Jul 2026 09:37:37 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84edbe57020sm690127b3a.17.2026.07.31.09.37.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 09:37:37 -0700 (PDT) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bhargava.marreddy@broadcom.com, rahul-rg.gupta@broadcom.com, vsrama-krishna.nemani@broadcom.com, rajashekar.hudumula@broadcom.com, dharmender.garg@broadcom.com, ajit.khaparde@broadcom.com, Vikas Gupta Subject: [net-next, v2 3/3] bnge: send hwrm for interface down/up transitions Date: Fri, 31 Jul 2026 22:07:12 +0530 Message-ID: <20260731163712.3463362-4-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260731163712.3463362-1-vikas.gupta@broadcom.com> References: <20260731163712.3463362-1-vikas.gupta@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Firmware expects HWRM_FUNC_DRV_IF_CHANGE on interface down/up transitions to coordinate resource management. Add bnge_hwrm_if_change() to send this notification. Signed-off-by: Vikas Gupta Reviewed-by: Dharmender Garg Reviewed-by: Rahul Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 32 +++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c index d47eb9bc5b8d..c2e865f8d9c4 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -20,6 +20,7 @@ #include #include "bnge.h" +#include "bnge_hwrm.h" #include "bnge_hwrm_lib.h" #include "bnge_ethtool.h" #include "bnge_rmem.h" @@ -2864,6 +2865,24 @@ static void bnge_tx_enable(struct bnge_net *bn) netif_carrier_on(bn->netdev); } +static int bnge_hwrm_if_change(struct bnge_dev *bd, bool up) +{ + struct hwrm_func_drv_if_change_input *req; + int rc; + + if (!(bd->fw_cap & BNGE_FW_CAP_IF_CHANGE)) + return 0; + + rc = bnge_hwrm_req_init(bd, req, HWRM_FUNC_DRV_IF_CHANGE); + if (rc) + return rc; + + if (up) + req->flags = cpu_to_le32(FUNC_DRV_IF_CHANGE_REQ_FLAGS_UP); + + return bnge_hwrm_req_send(bd, req); +} + static int bnge_open_core(struct bnge_net *bn) { struct bnge_dev *bd = bn->bd; @@ -2871,16 +2890,22 @@ static int bnge_open_core(struct bnge_net *bn) netif_carrier_off(bn->netdev); + rc = bnge_hwrm_if_change(bd, true); + if (rc) { + netdev_err(bn->netdev, "bnge_hwrm_if_change err: %d\n", rc); + return rc; + } + rc = bnge_reserve_rings(bd); if (rc) { netdev_err(bn->netdev, "bnge_reserve_rings err: %d\n", rc); - return rc; + goto err_if_change; } rc = bnge_alloc_core(bn); if (rc) { netdev_err(bn->netdev, "bnge_alloc_core err: %d\n", rc); - return rc; + goto err_if_change; } bnge_init_napi(bn); @@ -2927,6 +2952,8 @@ static int bnge_open_core(struct bnge_net *bn) err_del_napi: bnge_del_napi(bn); bnge_free_core(bn); +err_if_change: + bnge_hwrm_if_change(bd, false); return rc; } @@ -3157,6 +3184,7 @@ static int bnge_close(struct net_device *dev) bnge_close_core(bn); bnge_hwrm_shutdown_link(bn->bd); + bnge_hwrm_if_change(bn->bd, false); bn->sp_event = 0; return 0; -- 2.47.1