From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 910A629A9E9 for ; Sun, 2 Aug 2026 06:31:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785652320; cv=none; b=J6Qmm3YVeCLTrGA+gMFC+snM/+ZhtuYppIdgXhcjh7hTQCUc4qOY5GggqRz/nyKOPziSLob/314NsHfbCNOn8btlMhTajc3C4lYNfXlx7j0RP0tgWFJEm0gNwX78MA2LuGLFdxmG8ErmDm8AP5tF8WmvTOFpFWwDszniIEMED7U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785652320; c=relaxed/simple; bh=z8HDAkzFMZNpn6hBMimOcVP/mBpHX5xa0QTAjXUTTFc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kOs2xd9V9e9/8VJgP6gKZKKoRFjHZUVP8T9ha+wpkvTPfaYI4o/W3WS6Tx35bHepwZP+zPMZ/MipfaYXKESjaXOf5gR1MRn5+TRCk0Wzg69v7VKkcQ2tBRCi5RwWQ9Op59GQNWWQbr80zF3D0itX8SrlVaLnt+43BSZrVlm8L3g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZMeiu98r; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZUkqoUU/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZMeiu98r"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZUkqoUU/" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6724aYGv875990 for ; Sun, 2 Aug 2026 06:31:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AR43rgTt7HZmR4NtGqpPU+uXAcmy6WuqTrXhfWgS5r8=; b=ZMeiu98rgszUZHnU 790+LsI4lV1Fgk9bScfz1iIxOVcA3UC7LWiUQ3bloMXzwJZf657os90VyaRxisXx xA7nS0sxgPAI/HvnJUqproBnRiD6WO7AGZqa6i+6k0GK2I29d7K/eLWhTwZWw3bl MJpB+462j9AqYcefgJ1HlQKZzUZxCWh7zFFuYzX3xwkjCgKAjHoH3kagk5XmtTlL 0TdZip0QphroKLoHhLB95W6RRch2SIAVu6iqYUe2bt3m1gn8Rm6Gyi91+CXxV3TP fehdEQehaptEMB9ZzTREubI8ORRM9LQGr04+x69JEdwNPxsxsCcLAwOcmVf7BK+d u4HqaQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fs911abft-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 02 Aug 2026 06:31:58 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38ddc70b9d5so722101a91.3 for ; Sat, 01 Aug 2026 23:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785652318; x=1786257118; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AR43rgTt7HZmR4NtGqpPU+uXAcmy6WuqTrXhfWgS5r8=; b=ZUkqoUU/98czuY7aWQEI8nBueSw1EjybUjtKGhBVuOaFMTk+IrhPpJZ1phYvMY217q 6v2A2rXO7XYJKqS2F/1oHH22suxcOBbaNsolQAflPBIH6hae184j354Ke3NbKYk2gGRq vMiNo+p4sjLxs+mxhz4B1P8zlE9mxAIDTLIR4/NgC1noWzgUTE8FAMDiEPaHPMD0qjlX 7OD/tehH/in38QVXKp0I9GjSTZLyT5klXak5WzO1P/oPGFwQ/wEmQqBVQywHWqdsIiYf ZITwsUw8TCiu5EwEd3wmmvwQwvB95XimSLJVjd+9ujcRfsG9Vhl7H4y8hWjcYM0Zw3Yb DNWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785652318; x=1786257118; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=AR43rgTt7HZmR4NtGqpPU+uXAcmy6WuqTrXhfWgS5r8=; b=pgy4c/hqUwtHs6AwLr+vD5RzS5vUll8P5YBCseMdc6xGJbLqZHopHfqnIPGTfD8oTB g0jFxSLNapX9axJlzRApMBEdSLxWeuf4xhg5OwZLzoGWgCUSoLFJWd+SKreJrBPgp8mB 3PrtKwXGwzTjYhD1TJhsGkavIcpLfcQAGlTu4Wok8cIsDqz3QQJUuO+ygn4Ql6NuNHEU eodITzuB4Y9qXhmfHXGe2i0/E+HKAiMvIfwP9tF3f9RmmXeGfBpq8/jYVzB247hfx8QI 3NJKHNW90DoE9BiYVmdHmtKMTUOZ1JZ7WukijDmEe4FaqzBeVdwsH6zisbihf2Sk+yx/ d/Dw== X-Forwarded-Encrypted: i=1; AHgh+RpK8eebW0cQLjceJ+KwvYKVMavP5wv5Vg74I0eT0iUNrQyTTj4WxnqxWETh8LVpXfvMxawl6fZsEhPxWZg=@vger.kernel.org X-Gm-Message-State: AOJu0YyI4kMPs9vrIBaEcT0ZzNj33I9qMwDpuM6yNiFR4b0fOR8fUrR6 i1eEf994N004UXwKZ/7t2qYfEGZZYhs9iWb+GRoJhxmpYU2f+JWzhgUpF2AOrfmMEnJMLy17qF7 wMffLmpCU52WPEBYC6ErOF4m7/0ZdU3Ep3aPK8bFRp8f5yPEYJimIeQSRVFIjPVq+QCE= X-Gm-Gg: AR+sD13FkG/QA09aryMr1cICiWZn4ayI/qG+0Dl6bEStlWuOSQbaEliA20qSFyBIzfN OwzRGC8yJh5MMr2VWfip7JFQVhgFmD05KpVfiZj7MV7WkMWMr8WlhQ5/Ggov9HHMpfeGIspQUSH e86FYdgl4VeUKbqMogwFTQBLHzkZmx7/n0ybhxTO+RSuvFS7rkXcj0oizHm+EzHzHoNhQ+a/0DS TfeUh/djw7A//MwkEuUPLkbkDK3X70llxoM6C9pCEq8E5CgZm2BkuVsgvtxqhFYYDNECwMLatrx M8qN1q/aSLa//R4byV2CqbQj8eI1nnBfTvidMYvh5PAxme8kl00fDh/TavTAkph2QsQ8Gl9Viqk oulKS9+N91ttYFRhwOBxRM3ASOVat3sMY5suEzE6NvxSXhP0= X-Received: by 2002:a17:903:1450:b0:2c9:d298:6c0a with SMTP id d9443c01a7336-2d05246fbb8mr85218165ad.2.1785652318157; Sat, 01 Aug 2026 23:31:58 -0700 (PDT) X-Received: by 2002:a17:903:1450:b0:2c9:d298:6c0a with SMTP id d9443c01a7336-2d05246fbb8mr85217845ad.2.1785652317783; Sat, 01 Aug 2026 23:31:57 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c93dsm24233304eec.8.2026.08.01.23.31.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 23:31:57 -0700 (PDT) From: Zijun Hu Date: Sat, 01 Aug 2026 23:31:36 -0700 Subject: [PATCH v3 1/7] Bluetooth: btintel: Fix diagnostics event detection Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260801-generic_fix-v3-1-efdd8dcf3430@oss.qualcomm.com> References: <20260801-generic_fix-v3-0-efdd8dcf3430@oss.qualcomm.com> In-Reply-To: <20260801-generic_fix-v3-0-efdd8dcf3430@oss.qualcomm.com> To: Marcel Holtmann , Luiz Augusto von Dentz , Abhishek Pandit-Subedi , Manish Mandlik , Chethan Tumkur Narayan , Amitkumar Karwar , Neeraj Kale Cc: Zijun Hu , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu X-Mailer: b4 0.15.2 X-Proofpoint-Spam-Info: AW1haW4tMjYwODAyMDA1MCBTYWx0ZWRfX8E9R/IheySI0 1IGEW1LP/C9ERiOAnX/tY+2BQ97qvOgS3H8e7iqMRNE0CQ+4NdxUE/efFsxlZ9S0dWdi541P1GR 7BOL5606yRdxxe/bw/gWefVqL8zCK+Y= X-Authority-Analysis: v=2.4 cv=PvGjqQM3 c=1 sm=1 tr=0 ts=6a6ee45e cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=w585p4NK48lv-ZABhGUA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: KzSDA1RI1hVygtHRSIQlw9kSC-J0IHdI X-Proofpoint-ORIG-GUID: KzSDA1RI1hVygtHRSIQlw9kSC-J0IHdI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAyMDA1MCBTYWx0ZWRfX6Ck5LMGgRfO8 +FJkDZ7Jh68i1yImRJvSPeUFqR2R+Hur4XHWFWkSV+UgruVKMqabyrnB5ASGs0tzGGjcUuHbFP1 gztW+KC3gLA73aGo1pRLTjwnhJ07MHTQa4EDFRSIEeMCDOpJVxpWaPOfWwMO1zY5T7MHqT4P9/y 4rq8aHe84Iv9a0Dt8GfaQ7OAmikz72K7za22Nt1w9U/GmwSH7XmAEdou2f/EMwowX/ESE50w4jU XmPuvVP5a81TsRS/y3LixAukfsRql+HQ26f5xL6iBWwy43qfIBEi1dTKkI4YPgot2FcN2Nxosc+ f6MG2Lm2UIPyfTrci2yBktHgnv1r9m5Bhlove3I/pjTVbE7ucnCrdV3RbwZhtKos0WjRb/ICC4x 7f8ZZYdpRKkzxIasAdUfk7T5h232e3gVzBAZxOnVETGdP5YQ7F5RSo++rBgdTuANWCLR/dItUmM 7OYGK+OiQbmPjRXuffA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-02_02,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 priorityscore=1501 adultscore=0 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608020050 For a diagnostics VSE, diagnostics_hdr[] sits at the start of the event payload, skb->data[2], but btintel_recv_event() wrongly guards its memcmp with @len, which is measured from skb->data[3] for the earlier INTEL_BOOTLOADER check. Fix by using (@len + 1) instead, which == (skb->len - HCI_EVENT_HDR_SIZE) exactly. Fixes: af395330abed ("Bluetooth: btintel: Add Intel devcoredump support") Signed-off-by: Zijun Hu --- drivers/bluetooth/btintel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c index 770b1fb371c7..d06a335ff1db 100644 --- a/drivers/bluetooth/btintel.c +++ b/drivers/bluetooth/btintel.c @@ -4016,17 +4016,17 @@ int btintel_recv_event(struct hci_dev *hdev, struct sk_buff *skb) kfree_skb(skb); return 0; } } /* Handle all diagnostics events separately. May still call * hci_recv_frame. */ - if (len >= sizeof(diagnostics_hdr) && + if (len + 1 >= sizeof(diagnostics_hdr) && memcmp(&skb->data[2], diagnostics_hdr, sizeof(diagnostics_hdr)) == 0) { return btintel_diagnostics(hdev, skb); } } return hci_recv_frame(hdev, skb); } -- 2.34.1