From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFE563612D8 for ; Sun, 2 Aug 2026 06:32:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785652323; cv=none; b=H1qBiz5tzfOD17yUKW4YL7jK8ZbFza26VbEUn5J1gTJ+ekPSVVde3LbcsSMgesuvkJrwNC9Llsx27VKop3VdlXCV+s/HW3xbg5t8IUnAyw8UbO1nPwrCpS5kMZYDGQM/JwVhRefZO5TEV7aM+M0O3tBXeKCKgMPIjOP3RbO8ADw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785652323; c=relaxed/simple; bh=kxutCMtWPZ8I/oFqkiHyPup95KPTQ5v97RYSM4jiO+U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=A/vXdZIx8aL+BrLRLFZ9tKj9i1GZPi2eK0LVTWPSpqszYtcXcMvx/AVHAeFOO1JekLUrKiQZ3BOTp3N36Gjz6II8M+yaCfmTmxBiBEiqZGpdCQkIDBbndNm7NE/NQ23SvvMEPzKbeaEfiEgBViA7nHxK2F69PvqOCUCX2Zait/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hN1csOw/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LzBDdcZM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hN1csOw/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LzBDdcZM" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6724aoxY1012951 for ; Sun, 2 Aug 2026 06:32:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LSmNIm7/Z2iieOdVjenT53YbH0uk3Y8PUFU/NhW22Ok=; b=hN1csOw/A4RDnCZ1 +DEKrjDxijxvpDxp2op2A4lgm44DN4JxZMPQM62talHfMIUdZsoQ10jCoA5y/kDw 13psgIB/uCw7nVtolwilOWyQs9pFy4CDYqmLtOpbkZt9rfdc81yviwF7kXpE3axg 6E7yWdOVFex7pCKSAwPROjMzXfDjm6gWGRKmNPANVybpCISG/F0S4XZ1zDjdBJNs uecGhbANve1zheFAgFoH84QJsDkqo+ELH05UMstdLr6/KD6LJmA5cGNNtCAVaDzh WWVfw4p2O7ezO7XlHdEMnGvXQGM2KvR1qJES2SXIIp2JZ3D8EyYObGjtHuyypfZu +I4pLw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fs8q52d8y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 02 Aug 2026 06:32:00 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38459087607so879907a91.2 for ; Sat, 01 Aug 2026 23:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785652319; x=1786257119; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LSmNIm7/Z2iieOdVjenT53YbH0uk3Y8PUFU/NhW22Ok=; b=LzBDdcZMrxwzk8Ov+3VtfTURWoMSz4LRRfsIlkYNAcCQqHICWms7Qj6DfSr56vvvZ1 cS5R/cVC/R8d9QgsHMAVnkQHXRrT1GZ/uBzUDG+JW3NxGBeuFWCFWSBdzoz0hCCAP2zK phyeNrIvY+ahbtdevTp42uCBm33GNZGwpQ3XQWpfblRGQwqOblzx7KEodk/Nw6bxez1R 4lRRVVNfN+mLB2aGu4n63OtNacdG2hFEObNK3oY/rjvyVNEDBd2xa6R9g+8SAPI3lBPa rCB5elQfoFWj0fJNp+D3UQ/B6Ad504orv0stoBqlGOsIgPntSzN6VsTr9hP/xHCjld7d qhrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785652319; x=1786257119; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LSmNIm7/Z2iieOdVjenT53YbH0uk3Y8PUFU/NhW22Ok=; b=Wlk2buX+sUqZSGNbGF/Ko0GppY5RHI/vkmnOIkml233Z6V/NFd8/oTIFoVOfPAVaBq Ehw2F8rheUePB8w4G5PXrMnYQNgbL6UoM9PC+EcRjoYXRBFLD9RTjHZniXqEi04OcmHN gm3G3AewUe4wO50eRdlnd779sXDAjed6Jk90nOdEIZHqEhKT+j42POrhl6QCo9ytVSSv a4ms0h1OqlQXEy0HDGlRgc0uHjU59irjlL7fH5osecwybKKPZPyiIfWzI+YsXmduJpRu mTodQgBPsKUgKPQ/FZmsGjlBL9booLsZyG52jGhSEuYiUjeEUEeTJhmavho3vVv+jo42 c9eg== X-Forwarded-Encrypted: i=1; AHgh+Rr7kc1QPGfjHdcyK5YHFqPQQvXSxQ/I0i8zrU0A2nIllYiWLnEhzMj8Uv8vudjc30CDUH7qFy1fD0q3ndM=@vger.kernel.org X-Gm-Message-State: AOJu0Yyh4xoG3D8VzC0wmeSBL6+XujVYesoZeQBODrAN5TtAcrMTW6uS ay3wDIXT7ty8RCf9bUD7h0MVDaqSjv6bgOmW4cSPit36Oua31BRKUlTmAmknXlw8VDSMWjhW+lx qpCYTU3uZcaBteRmrH6vb72UtfiXkx2Nty0txA7EZ5l9SaNoS+E44x6Uy4CCpVSBbkF0= X-Gm-Gg: AR+sD11EXtSllgtRmxF9R30p3h1SyH3mIMQyhdRgHmtgzsR+/XWEzoZ6rfYw7Jp7xPZ yLgB6wvXbcc0rGIu4gnhTJLA70mljJBvrSTUnqYH2y7Q6UqcwPJHpNZlatJZlqUzRcy33oVvKr+ iHhxCejGcxgaY4H6ZiW4WOv3mitqAceF4/mdjL8BEbcNn2W4ADiMXWktHUKllG8ONUhb9F9Y3aU qSqMliO4/h/XNyFeJW3zdAqufwArPexql3NA7eWEe2Eb7GCmAeng2HvkeGazJrq7bwifNIF9t0X H/BbiVtGqwyEghGmw2bTFXBAMdSbSb+U9s+81c35AUNTNsY9xce9gkAocuDOCemxpnGY5blejHG hIDMJ/nJrpiPdbFRqeKItlYicAxItZ3meKyJwkQrMOXtyrvo= X-Received: by 2002:a17:902:f78b:b0:2c9:e846:a582 with SMTP id d9443c01a7336-2d05206277emr76292235ad.0.1785652319376; Sat, 01 Aug 2026 23:31:59 -0700 (PDT) X-Received: by 2002:a17:902:f78b:b0:2c9:e846:a582 with SMTP id d9443c01a7336-2d05206277emr76291975ad.0.1785652318936; Sat, 01 Aug 2026 23:31:58 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c93dsm24233304eec.8.2026.08.01.23.31.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 23:31:58 -0700 (PDT) From: Zijun Hu Date: Sat, 01 Aug 2026 23:31:37 -0700 Subject: [PATCH v3 2/7] Bluetooth: btintel: Remove redundant (hdr->plen > 0) in btintel_recv_event() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260801-generic_fix-v3-2-efdd8dcf3430@oss.qualcomm.com> References: <20260801-generic_fix-v3-0-efdd8dcf3430@oss.qualcomm.com> In-Reply-To: <20260801-generic_fix-v3-0-efdd8dcf3430@oss.qualcomm.com> To: Marcel Holtmann , Luiz Augusto von Dentz , Abhishek Pandit-Subedi , Manish Mandlik , Chethan Tumkur Narayan , Amitkumar Karwar , Neeraj Kale Cc: Zijun Hu , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu X-Mailer: b4 0.15.2 X-Proofpoint-Spam-Info: AW1haW4tMjYwODAyMDA1MCBTYWx0ZWRfX58zaJWmcGkjV dZDmSezrh32Ahv4wSnA8x1as99TGFbQ1B2L7HzGsUCEJ1GtSXQxqcmrupNo17crNLJQcwbENIXY YXe3BIUKcnKFu6Wr06BT18sggdA7Zvk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAyMDA1MCBTYWx0ZWRfX9nfZVYXpYFeS tMA4u7aUte5OTKaHmatDW3BFLXJxUsVB9y1YJ8qI9tJtI5QjFxQYHHm/WOjAHSK5V63EFzrCiQL mzBqt0WyCJsgbdwvDEHCB5/x+zT3qlmGq+4C4IaBpcMuVmf3Te1GGt+FjrX7bih0qQH7N3xg8HC GwZO889QpeYh25CB2ZVfd9fdWgCRd8QBcZ4xMbS0nlj2ovGTAvdVaxbwPP/o89Hz95Gbmm1ndbx k+ryjEthphGNomEIeL7Ea2vmjs95nhSalRyMeeZCBXMcYuY5z2czmXJ2TRQOMgNDKyL2Rcvb8uM T7JcicP1gdm6rlSVVjQ72D+QWwAyOXspfYhxHu99sgH3+N5lcPrfnYEQe2Vo1BIbOHj02Cz0CpM ps/M63+VmnNGlAYuuPx3Hu76izGHCQF3rt+5MAV9MJ8k2hG0aCa1SM0tfgY0NzRIAy6QerITPR6 3X7MWZqlAOqEScvsEpA== X-Proofpoint-GUID: zMZC9yGIHzHI4E7AvO6Ic-wTL6nFn7fk X-Authority-Analysis: v=2.4 cv=IYC3n2qa c=1 sm=1 tr=0 ts=6a6ee460 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=7TpkJ8Rp_0KA0x_Po7YA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: zMZC9yGIHzHI4E7AvO6Ic-wTL6nFn7fk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-02_02,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 phishscore=0 suspectscore=0 priorityscore=1501 spamscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608020050 Drop the check since: - it is already implied by the existing (skb->len > HCI_EVENT_HDR_SIZE) - hdr->plen is then not used by the function at all Signed-off-by: Zijun Hu --- drivers/bluetooth/btintel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c index d06a335ff1db..bcb2514b7bc0 100644 --- a/drivers/bluetooth/btintel.c +++ b/drivers/bluetooth/btintel.c @@ -3986,18 +3986,17 @@ static int btintel_diagnostics(struct hci_dev *hdev, struct sk_buff *skb) return hci_recv_frame(hdev, skb); } int btintel_recv_event(struct hci_dev *hdev, struct sk_buff *skb) { struct hci_event_hdr *hdr = (void *)skb->data; const char diagnostics_hdr[] = { 0x87, 0x80, 0x03 }; - if (skb->len > HCI_EVENT_HDR_SIZE && hdr->evt == 0xff && - hdr->plen > 0) { + if (skb->len > HCI_EVENT_HDR_SIZE && hdr->evt == 0xff) { const void *ptr = skb->data + HCI_EVENT_HDR_SIZE + 1; unsigned int len = skb->len - HCI_EVENT_HDR_SIZE - 1; if (btintel_test_flag(hdev, INTEL_BOOTLOADER)) { switch (skb->data[2]) { case 0x02: /* When switching to the operational firmware * the device sends a vendor specific event -- 2.34.1