From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B6313D47C5 for ; Sat, 1 Aug 2026 03:15:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=96.67.55.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785554166; cv=none; b=YXQ5sXko7PQPKsJt0Pz7VGLly/PLtbntCra2yZcbufLHQ7JG+hzlanUfqsIa4jYnlwVplsVoJFbSMNqO9AJi5hl9EFFAwTOmVFNAt9sKL6jzQkg1xdaeijPEV6Gn4RlTaktA0M0dQL75TJE/PqWZddhq6tXhAevP4d1Ty0fUXbE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785554166; c=relaxed/simple; bh=Ru7dCAuTLRIyhPgJukpe+qV+gOQTLImC+os1Np18NfQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I6BuEEf8nCUEukdUyh3411+YmskhjdeqIpZdqV+zsv1Lz1TMvkjDKw5799Wy2UGivlvgoZmDrmEK9DZ2f2aX4RP+0ekw7C9JQvcLEk1GD8lh/Ytxl0Z9J42QqjrMDB0+KB4rxpxPaFAOQP2JM6nvSU/Q1Lhz6VAx04h1fKA7nQU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com; spf=pass smtp.mailfrom=surriel.com; dkim=pass (2048-bit key) header.d=surriel.com header.i=@surriel.com header.b=oPTdc7GY; arc=none smtp.client-ip=96.67.55.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=surriel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=surriel.com header.i=@surriel.com header.b="oPTdc7GY" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=surriel.com ; s=mail; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Wa9J/+YO6I4dfQddtw/Ia7wDAxt2roUtbkMuKbEd/24=; b=oPTdc7GY6cMkQue14keVS8PtXA XMgVlDpD6bsEpPAG6VEf8wL6uLFYKX3uT+NN7NfkpFJrlur0MchHYWQp/yszM0i7ThzXFFnZKYb2K gFjH+MHq/WheyPnqmiZs3EG9FHyiGV/4x9vk2CTpKt+M+361VSCPsqcaHyL0ESyAF7XR4O2EBvjH6 lGjMyzugkU9m8drjEWEicpM83GwnpbrfJnIIb7hrFcTxS6nYtVEsGV7bSSE6wUHXT+oVOlaOKqyaP Q/tZ0yvqk/OTV/1nZEJfJQPRYqQFw3MXudWgc5tm2v38cf5/tmYOCOeMo4ZYH/1ePa5acd/sM5dhu UGT4dcjA==; Received: from [96.67.55.146] (helo=fangorn.surriel.com) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1wq0CU-000000001Q5-3rhq; Fri, 31 Jul 2026 23:15:50 -0400 From: Rik van Riel To: linux-kernel@vger.kernel.org, Andrew Morton , David Hildenbrand Cc: kernel-team@meta.com, Rik van Riel , Jason Gunthorpe , John Hubbard , Peter Xu , linux-mm@kvack.org, Lorenzo Stoakes Subject: [PATCH 3/5] mm/gup: add gup_fill_pages() and use it Date: Fri, 31 Jul 2026 23:15:38 -0400 Message-ID: <20260801031540.2742891-4-riel@surriel.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260801031540.2742891-1-riel@surriel.com> References: <20260801031540.2742891-1-riel@surriel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit follow_huge_pud(), follow_huge_pmd(), and follow_page_pte_commit() each store the page they found into pages[0] and flush its caches with the same three lines. Add a gup_fill_pages() helper for that, and call it from all three instead of repeating the loop. No functional changes intended. Suggested-by: David Hildenbrand Assisted-by: Claude:claude-opus-4.8 Signed-off-by: Rik van Riel --- mm/gup.c | 35 ++++++++++++++++++++--------------- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index 053da43760a2..b6d508a44ced 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -633,6 +633,23 @@ static long no_page_table(struct vm_area_struct *vma, return 0; } +static void gup_fill_pages(struct vm_area_struct *vma, unsigned long address, + struct page *page, unsigned long nr, struct page **pages) +{ + unsigned long i; + + if (!pages) + return; + + for (i = 0; i < nr; i++) { + struct page *subpage = page + i; + + pages[i] = subpage; + flush_anon_page(vma, subpage, address + i * PAGE_SIZE); + flush_dcache_page(subpage); + } +} + #ifdef CONFIG_PGTABLE_HAS_HUGE_LEAVES /* FOLL_FORCE can write to even unwritable PUDs in COW mappings. */ static inline bool can_follow_write_pud(pud_t pud, struct page *page, @@ -678,11 +695,7 @@ static long follow_huge_pud(struct vm_area_struct *vma, *page_mask = HPAGE_PUD_NR - 1; - if (pages) { - pages[0] = page; - flush_anon_page(vma, page, addr); - flush_dcache_page(page); - } + gup_fill_pages(vma, addr, page, 1, pages); return 1; } @@ -747,11 +760,7 @@ static long follow_huge_pmd(struct vm_area_struct *vma, page += (addr & ~HPAGE_PMD_MASK) >> PAGE_SHIFT; *page_mask = HPAGE_PMD_NR - 1; - if (pages) { - pages[0] = page; - flush_anon_page(vma, page, addr); - flush_dcache_page(page); - } + gup_fill_pages(vma, addr, page, 1, pages); return 1; } @@ -854,11 +863,7 @@ static long follow_page_pte_commit(struct vm_area_struct *vma, folio_mark_accessed(folio); } - if (pages) { - pages[0] = page; - flush_anon_page(vma, page, address); - flush_dcache_page(page); - } + gup_fill_pages(vma, address, page, 1, pages); return 0; } -- 2.53.0-Meta