From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84C7737F756 for ; Sat, 1 Aug 2026 06:45:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785566720; cv=none; b=GSsSJmEB5GBzTocrmR3oyxybA7NN8V1luudkujr7iRQm3qQ2I4S2SVKKg8mR+lm8jdhIMsEDq8DyFs0YHT28Ld4U7IbUAZl90cYFtIv5f8N6RtveiSkkxMe/B39kOGqCJuA1kQqqNtMGpe0gNYCVTGw3uEHBLs9sCQJLzFedflE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785566720; c=relaxed/simple; bh=GvdZ662JCMXzbW8+6bNSz/VzMykfM7w2yO2nTWSDYKA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=goXc4KSoxZyoHFLvv7TrkL8ruo311pCPqIYVzM9I5IE5ZNXSa87UTXKLA7p1xYXZGFlw0GvzXUCjrTpj1jIaX8WGqPN2Hgp2MhkGvz3v9Z2ySGzmc97k4hZQOzthXS6pHjNYCRuKgW/cYrjrAaieFb5wU2GCGA/FRsqbZSxkObY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=osZ2WNbo; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="osZ2WNbo" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-47c6e9a694bso1167969f8f.1 for ; Fri, 31 Jul 2026 23:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785566717; x=1786171517; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=shXI5gTecK3XzXEfQhSt8Ph409l47ex30hjHXtZWBBA=; b=osZ2WNboAnUPujABCAYXUjKloEyFWGvTf2Pu9hACHWcNLtS1ki99liP4LVtNfKlacT P+QGh1padWva+H6VS8eg9HOR397Ugv+ePGmWYw/M66F4tk6l497E501+anFz9uUb+Lb6 fnusB74xgbuh0ZfdV6G3ulnfyIa9fvVCbH0o/UHU9SVSvGsyAybfreTDVcvZuXYOSm0l wd7vOCo+bhsmE5FX+wT2xv5g1XFhCfPSdNNTyzuCxpWGyIDuqAuPC2O8rQM6p1/2/P9V YZ65fdCZ0Z79DmN2R+spQlPoknXmQEEU0YDIOISpwahoB8zHv1ZJVL2mk/tfdLy3Ivk6 BfEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785566717; x=1786171517; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=shXI5gTecK3XzXEfQhSt8Ph409l47ex30hjHXtZWBBA=; b=Fl0ywdx2P5xbZOncZf7Hy1U/iDNhPODmenGkNlrJlntlcpXPBw8136PbkO4HHJC/gs FJ0PTHLPONEfBumdx+eWQK6jkYPVoHyepHvhudV/8JLckjM+Poe/Er7bZyEIqMsk/7v+ pDmhXHK4fc5HfTO/W6h2UuN79AxBgLs3NtOMwhOPE50Pwn3lPT3fvvxkI7kvIoq0HLcn 7JYS1WHsbQq5CfVyHhhJkAv4NA8G4dYPxaayTb2hGahVnyIzjTgKdwN1sl5/yni9lw/S CUFD8MiVMG3fhtM7Xwa9B3H3ofzdHJ/C0V8GK/HZLAa1yc+xtUO7Dk7psmZliUa0vScB Dhyg== X-Forwarded-Encrypted: i=1; AHgh+Rpbm6fNXfy4K13t97btxd11YXvMKbR3qEqvuHT9sk0l5BK++pYXrgBKu6MgaLmfqIltaWGbH42k9K4UavA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1ik6kRV9qlSy9iSFSIrZmzWvx4EC9isW+zjIY5D4qjmPw4G1C 6IEbz3Pfxrhl1ptZ+pL+27rfhaIHZrxuIR0nctbVsRkS5D7hZXo4Mk7ccWUB1w== X-Gm-Gg: AR+sD126eA6/ccdMpEcBM70fAim30rUVq9DvDedpvc9v/ZoPT7aCx3JDCy5aACyNbt5 SeNKpXV3oJKG9yOLExZvE8ew0qop+9/ozx/QSFycW2OOsWOaYB9mRvwoiXs+xqRZUpCioOd3b0x b3hLrGS/ePYsjyhtVaioD82lEsPuHbTFDoP4rS9a6vr9Y/g1m2jxf5AzKwv9LxstOm6w9TIWGnF m0pLQjzZoI7P8YEuSB1s7j5C3DNJW+EoR/a0DaTrtoqCGVsuzQZkVoalKuDU4rudVNb4osmsFYl IpyCY6i80kLRjm++oc6omcFEKZQA6RheEdnwnSc5h4ZeAPNLuuMU1eYMn8m0uk5cen5Uwmc1M8V q1UBIHcHt2V274N9l/Pj/INAWNqxKaPHR3p3ees3AFdh00VYzHsLi3YdxgafEXyBdw78CuLEHCZ Eyj7yyfw91SS9LL4pcIT1pZORkUd9skmnotALxKrjR7nirAU5hHZ3myxw2ZVSkHmsaN1AEQsbQ7 oRwdxuxVkCTQURcpykcAIOgi+vVIJC9Vkg1+HLJhAMbQAlznQ3iUY/WN4ojAEyszG8Ax1QRfc7d wD6EZaZMKZBSIM33FGe/cIMtgO3AdX+i++eU6rZVYpUYWVBchjaJGf4OMnEWgnxeAksXvZ8kMEL 972jTiqvSFSU/f7xvKCfTmtqmlHyuQg10Wfcqm2HgJJK8uMQp3+FxSCbMR0c= X-Received: by 2002:a05:6000:186e:b0:47f:aead:f81b with SMTP id ffacd0b85a97d-47fd72c48a0mr4568734f8f.21.1785566716620; Fri, 31 Jul 2026 23:45:16 -0700 (PDT) Received: from systembl0wer (109-81-110-31.rct.o2.cz. [109.81.110.31]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd458ea4asm12408852f8f.31.2026.07.31.23.45.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 23:45:16 -0700 (PDT) Date: Sat, 1 Aug 2026 08:45:11 +0200 From: Joshua Crofts To: mdshahid03@gmail.com Cc: Jonathan Cameron , Andy Shevchenko , Joshua Crofts , Broadcom internal kernel list , David Lechner , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nuno =?UTF-8?B?U8Oh?= , Ray Jui , Scott Branden Subject: Re: [PATCH v3 3/3] iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe() Message-ID: <20260801084511.795962ac@systembl0wer> In-Reply-To: <20260731182347.42888-4-mdshahid03@gmail.com> References: <20260731182347.42888-1-mdshahid03@gmail.com> <20260731182347.42888-4-mdshahid03@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 31 Jul 2026 23:53:47 +0530 mdshahid03@gmail.com wrote: > From: Mohammad Shahid > > This simplifies the probe error handling by replacing open-coded > dev_err() and return sequences. Also remove the redundant > dev_err() after iproc_adc_enable(), as the helper already reports > the failure. > > Signed-off-by: Mohammad Shahid > --- > drivers/iio/adc/bcm_iproc_adc.c | 43 +++++++++++++++------------------ > 1 file changed, 19 insertions(+), 24 deletions(-) > > diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c > index 29ea35972a23..5fcd528eb88a 100644 > --- a/drivers/iio/adc/bcm_iproc_adc.c > +++ b/drivers/iio/adc/bcm_iproc_adc.c > @@ -523,19 +523,16 @@ static int iproc_adc_probe(struct platform_device *pdev) > > adc_priv->regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, > "adc-syscon"); > - if (IS_ERR(adc_priv->regmap)) { > - dev_err(dev, "failed to get handle for tsc syscon\n"); > - ret = PTR_ERR(adc_priv->regmap); > - return ret; > - } > + if (IS_ERR(adc_priv->regmap)) > + return dev_err_probe(dev, > + PTR_ERR(adc_priv->regmap), > + "failed to get handle for tsc syscon\n"); > > adc_priv->adc_clk = devm_clk_get(dev, "tsc_clk"); > - if (IS_ERR(adc_priv->adc_clk)) { > - dev_err(dev, > - "failed getting clock tsc_clk\n"); > - ret = PTR_ERR(adc_priv->adc_clk); > - return ret; > - } > + if (IS_ERR(adc_priv->adc_clk)) > + return dev_err_probe(dev, > + PTR_ERR(adc_priv->adc_clk), > + "failed getting clock tsc_clk\n"); > > adc_priv->irqno = platform_get_irq(pdev, 0); > if (adc_priv->irqno < 0) > @@ -543,10 +540,10 @@ static int iproc_adc_probe(struct platform_device *pdev) > > ret = regmap_clear_bits(adc_priv->regmap, IPROC_REGCTL2, > IPROC_ADC_AUXIN_SCAN_ENA); > - if (ret) { > - dev_err(dev, "failed to write IPROC_REGCTL2 %d\n", ret); > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, > + ret, > + "failed to write IPROC_REGCTL2\n"); > > ret = devm_request_threaded_irq(dev, adc_priv->irqno, > iproc_adc_interrupt_handler, > @@ -556,17 +553,14 @@ static int iproc_adc_probe(struct platform_device *pdev) > return ret; > > ret = clk_prepare_enable(adc_priv->adc_clk); > - if (ret) { > - dev_err(dev, > - "clk_prepare_enable failed %d\n", ret); > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, > + ret, > + "failed to enable clock\n"); > > ret = iproc_adc_enable(indio_dev); > - if (ret) { > - dev_err(dev, "failed to enable adc %d\n", ret); > + if (ret) I'd say it would be better to move this change to the patch where you remove the dev_err() at devm_request_threaded_irq(). -- Kind regards, Joshua Crofts