From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68500255E43 for ; Sat, 1 Aug 2026 09:10:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785575450; cv=none; b=h/u1P+o+5KSlbHkOsmjPgVWmeVYanuXlL6holRcxOuaPYqjpIk5pw1T2Q3fsAgXIecx1qw2o9E62fo1wlOyMX15LTrK2YVnb7mS+LPKvFN2kytCRxu8vmZ0olB8sT6UU5tuNN342QiC9WEALLTpjbu0ZIAVgDe6zNDZ+Cwig4Ac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785575450; c=relaxed/simple; bh=OvQKuoneFsh/WxICPt1MaBIMs0/iiqu65A4ormy8KeQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i4y/Erk/Ou3LgnUumwkvY/Uyuf0BIUZ7WYnJjSydR1pSr6Km8v0zICMPx1S5S2rh0NffEVvENf9zn/ZZWqJflVqgT1oYuPzx7lVtMK3Xet9gDdoYBJmORzijWdXY+57jkWLR0lmlcsyQp9U+LYtFMTeMz9H+KV0z/FNEwEuhEEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WdDgUjKk; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WdDgUjKk" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-84862b0d5f8so1625692b3a.3 for ; Sat, 01 Aug 2026 02:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785575449; x=1786180249; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PgxBTc/eAxhpXNXIIpPZ/eJLF5hZIUUNMPVKiLuD+Wo=; b=WdDgUjKkyv4zqYfB0A8uO4zTfw9lz3K6v2WFTHUscNEFZkRnYjRCVP6WVQYywIXmgl +Fyi1ZNDWGI6fI4AT2LHW8RtxvAniT1EbfBdoTv2rGvGW8GX1R22iZp7FcpYGoa/jG2A 7iwcnDWCURh1gnhEFj/dzu3z2GjEE50moPTmljZJ8eV2L9aEnqwmGSbBdMPAneVx1iwB g2xTjWTy4IS6B/PvUQ8qUi9SY6YYFXHUtXe0J62EHksQxR7UEyPFUzUFydL/Y9h+0EHk m2wDzxjAmEHpFnTgROch0+LHocX7FIiWwq/qsT5Xx26L22uE4ya4qR42jGPUelTbFLAE C0fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785575449; x=1786180249; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=PgxBTc/eAxhpXNXIIpPZ/eJLF5hZIUUNMPVKiLuD+Wo=; b=soGLp4N4LlGdIGLNaXqGnWzMGMSV0FNl118jxbIZYahTNtO5iHF90ZdcqvfUNKmgT2 YPjBormNXumsrujaWrcvjprs1taef3uXo26GU6T05nHuG7i1lLyfj1Xx27Y1yo4Um7IE pIfJr1Yj1hcB6T6YLW9m+pgXxzLZEQ/5fkAkCZvamNOfaOqXNyr8zb9Kp1d5uSZAlKea rwf6ABM/7XNcgSby0vXW6UWVJctJm+dNlGfIFH8MFvMedQoT3LOZ0hbxzXtR6nlMaYNZ Ux5kVOPEQREO+iIbRZHb4wvcT/hSCxZcbUR4TG9WdrQlWGdRGkSY7eImlTg3BX6AVthW 3eMg== X-Forwarded-Encrypted: i=1; AHgh+Rp8+yS1T5k7G1SpfNOH8fVyyjQ9rVzbo4xtw/Li7vL1E1Mdm67yeU2698mLO+Y6JX/5jJ9Qm7Dj17HaAeU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2PmyLP8Ue+wqYm8G5c1JPgsd4TPQLIwFK1NOgBDqfZmFRxd0Z IPEaSgExCEtfbbqCOvvXWnbQyVqOR4IdTrKOOzaWs1cWlZX8PSQery8A X-Gm-Gg: AR+sD10DerZmCTveD0XDmMYA37o/cp0ne7GUGYbYQ8lL8YwD6btQ/0+m+yjOvZbmRLd EDRxmV5aRrx29rdZD0FniMRRrkK/xNE+Xh06vhKx0tANY+qWBVAbETEIYNOMvaznivQ1y4BPMAx rGSzx58PiCWN2bXg72fuK8vDcZ1tdCR5654fSg56UOa8z25vnhyYEbS3vQokYHyKjdNJ8M53q8m MU4XlUsjIkr/eNW6T/iFnEKrrHA/6wMxA+qYezM01Pn9U2Kq0KLrpEp00cjpuEIT7FYJFLRq3Wi nCcZSDHY+dqjq1rQpeBfndcX1Kqs9tDMYtD4KAxy5LmkUR0CQHaUus5QJqaPY/BLUrP0SLzmLcz AY+8WbvmSD7f6a/6phX7HB0KVxAOpNFjtwVVfZoNcpEsGwq0LhL6x4xlf/p//M2SLJg1btcKEHj BIvwGxslKw1SaBDGhxxsK1F4y86ZHr3jqzklJNMiH4xqAVTJbw7bIAXPHQhg== X-Received: by 2002:a05:6a21:2212:b0:3bf:9b61:f7ae with SMTP id adf61e73a8af0-3c92a75b245mr2888824637.14.1785575448667; Sat, 01 Aug 2026 02:10:48 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:36ae:7de2:5cca:938]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c96asm15432431eec.7.2026.08.01.02.10.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 02:10:48 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron , Andy Shevchenko Cc: Joshua Crofts , Broadcom internal kernel list , David Lechner , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Mohammad Shahid Subject: [PATCH v4 3/3] iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe() Date: Sat, 1 Aug 2026 14:39:53 +0530 Message-ID: <20260801090953.61603-4-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260801090953.61603-1-mdshahid03@gmail.com> References: <20260801090953.61603-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mohammad Shahid This simplifies the probe error handling by replacing open-coded dev_err() and return sequences while preserving the existing messages. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 39 +++++++++++++++------------------ 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c index 4acd9c3f089b..5fcd528eb88a 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -523,19 +523,16 @@ static int iproc_adc_probe(struct platform_device *pdev) adc_priv->regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "adc-syscon"); - if (IS_ERR(adc_priv->regmap)) { - dev_err(dev, "failed to get handle for tsc syscon\n"); - ret = PTR_ERR(adc_priv->regmap); - return ret; - } + if (IS_ERR(adc_priv->regmap)) + return dev_err_probe(dev, + PTR_ERR(adc_priv->regmap), + "failed to get handle for tsc syscon\n"); adc_priv->adc_clk = devm_clk_get(dev, "tsc_clk"); - if (IS_ERR(adc_priv->adc_clk)) { - dev_err(dev, - "failed getting clock tsc_clk\n"); - ret = PTR_ERR(adc_priv->adc_clk); - return ret; - } + if (IS_ERR(adc_priv->adc_clk)) + return dev_err_probe(dev, + PTR_ERR(adc_priv->adc_clk), + "failed getting clock tsc_clk\n"); adc_priv->irqno = platform_get_irq(pdev, 0); if (adc_priv->irqno < 0) @@ -543,10 +540,10 @@ static int iproc_adc_probe(struct platform_device *pdev) ret = regmap_clear_bits(adc_priv->regmap, IPROC_REGCTL2, IPROC_ADC_AUXIN_SCAN_ENA); - if (ret) { - dev_err(dev, "failed to write IPROC_REGCTL2 %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, + ret, + "failed to write IPROC_REGCTL2\n"); ret = devm_request_threaded_irq(dev, adc_priv->irqno, iproc_adc_interrupt_handler, @@ -556,11 +553,10 @@ static int iproc_adc_probe(struct platform_device *pdev) return ret; ret = clk_prepare_enable(adc_priv->adc_clk); - if (ret) { - dev_err(dev, - "clk_prepare_enable failed %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, + ret, + "failed to enable clock\n"); ret = iproc_adc_enable(indio_dev); if (ret) @@ -574,7 +570,8 @@ static int iproc_adc_probe(struct platform_device *pdev) ret = iio_device_register(indio_dev); if (ret) { - dev_err(dev, "iio_device_register failed:err %d\n", ret); + dev_err_probe(dev, ret, + "failed to register IIO device\n"); goto err_clk; } -- 2.43.0