From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EBA61E7C18 for ; Sat, 1 Aug 2026 12:53:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785588791; cv=none; b=shDUTGKVuRdlFkA11dihyV36iEc3jFkFxSXls0H3MczEWaEI6BOFc6xh6/FIdOwHWpy/bDx8xIS3eVg12gPzBjaokmRtSqOpfIbF4kO6fLCBfhHLU46Nuz4lCmN1wwL0sI4Brg7K+gs+nxGRO1V8xjewyuFldnblhyJL/pD9bv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785588791; c=relaxed/simple; bh=PhLR4+qn453F+QIwU0DsbC1PeRAX3ITCmQFBqjZMZ5k=; h=Date:Mime-Version:Message-ID:Subject:From:Cc:Content-Type; b=hTeJfcibvTsI4P/671K2eXsaylTIi4jVu+FpR447lsMv1tHUnIR+1aeESiHz/GPzDgKItRHsswzK0JBXYpPUgCJh+7etnaS5yAgZYzb85gvA5P34ZvEA6FAOwBefq9qCX/2Z387UFzmx6Q4k8By9dGGtFwo4ckHeM/VZWjOcCYU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=fvP38ZBF; arc=none smtp.client-ip=209.85.214.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fvP38ZBF" Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cfe48ca1efso27622475ad.0 for ; Sat, 01 Aug 2026 05:53:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1785588789; x=1786193589; darn=vger.kernel.org; h=content-type:cc:from:subject:message-id:mime-version:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=BD+pUsKKpLLfVgUegmrxzd2L72D2X2rHT5PiZiLd4oo=; b=fvP38ZBFbweL2IwaWU3Xnhw+jVvhURa/CKYS4ttDq8Q/TRv7T3NW7LVop9z5625iFi InBDUHTVZUNWQ+hN1BKHkg7m3/hWhZFtGTvs8FbyuXpS8drsnUysIXjBfHWAwWHw8cXP xnte6aXMbFjDJN8to/WM0TkkYR997o9XeGNhW1WMK+yyDpvsu9+19VjSZkUbHrcjoBXL 0TFXDxuNaynLVnArKhnyye1isqKHbnyo/Ys5ido4ecd250q88LcQjvKstVDPazKBSZl3 2OO1aIOfDDDcgCHJY0JJRTeuZ7IX5FEVYWS92J1bcelEXA2VPsX0dRQ1VepkjEI67R3X JpWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785588789; x=1786193589; h=content-type:cc:from:subject:message-id:mime-version:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BD+pUsKKpLLfVgUegmrxzd2L72D2X2rHT5PiZiLd4oo=; b=Da4mvAiqGUgZfvgHlSz4F3auyjGWlWBA6Oyxui50JZ0mUEh86mCGqZ2fcRrWV2qMVm HHGAEj62PgxzdrScgmSm5l2cl1j/qQgskgYZGECtZQeTf2Ob6g897VL8k/h/roGsHUKB 0WWtW1qRrIlN5kE1VWZRk6ohRN4dpgoGr5LSmg///QWQoEYOj7+k8FkcviYo2CWLS4WY hTOzwhwLU0QQxznxWdBTsZ/jzckYvVSrmRe1gSO2wajoW27XQ1dY0LDjbPFBvtmStJlW ZaMk3gdRXEckA1x6YB+7xDNlRJSOVTRc5InKlMBSPNlJ2xnGvQJoPGeTYIYVH0P2EnMF K/RQ== X-Forwarded-Encrypted: i=1; AHgh+Rpfm3tjlARpF5GPYIjr/71kOErJBNcJdWxk4JpaVFVs+H2X8LlFeg8nktgEjpBguiMTrWTv7oMErL5Rxgk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz10GU3Esgg05ksVNmuHqs08+9XwH4lMEGWaTE/6YIsrBkTYl8m /Wp6H3VLg3DYUOL1itnelg+MMMMujhP6HIOR6AMt4JgL8Wn+sVbU1e6ulBE2ysmzk5hS9heuJQF vVCOiLbtPR4Uh5IE50KsyqyjVdw== X-Received: from dyjh34.prod.google.com ([2002:a05:7300:5622:b0:313:c814:320f]) (user=almasrymina job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:390c:b0:2cc:d6de:d597 with SMTP id d9443c01a7336-2d05219bb84mr32050535ad.7.1785588788682; Sat, 01 Aug 2026 05:53:08 -0700 (PDT) Date: Sat, 1 Aug 2026 12:52:19 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.55.0.571.g244d577d93-goog Message-ID: <20260801125308.1342897-1-almasrymina@google.com> Subject: [PATCH net v1 1/3] net: core: propagate unreadable flag in skb_zerocopy From: Mina Almasry Cc: Mina Almasry , Pavel Begunkov , Stanislav Fomichev , Bobby Eshleman , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jason Xing , Kuniyuki Iwashima , "=?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?=" , Jiayuan Chen , Willem de Bruijn , Kaiyuan Zhang , "open list:NETWORKING [GENERAL]" , open list Content-Type: text/plain; charset="UTF-8" When skb_zerocopy() copies devmem payload fragments, it fails to update the target skb's unreadable flag. This causes the target to appear as readable memory. Propagate the unreadable flag if any devmem fragments were copied from the source. Fixes: 65249feb6b3d ("net: add support for skbs with unreadable frags") Cc: Pavel Begunkov Cc: Stanislav Fomichev Cc: Bobby Eshleman Cc: Florian Westphal Signed-off-by: Mina Almasry --- net/core/skbuff.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index ba3dbac80fb49..aebe8ea74776a 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -3928,6 +3928,9 @@ skb_zerocopy(struct sk_buff *to, struct sk_buff *from, int len, int hlen) } skb_shinfo(to)->nr_frags = j; + if (i > 0 && from->unreadable) + to->unreadable = 1; + return 0; } EXPORT_SYMBOL_GPL(skb_zerocopy); -- 2.55.0.571.g244d577d93-goog