From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6557275B03 for ; Sun, 2 Aug 2026 01:23:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785633830; cv=none; b=U4SvDgbj8TgITZVQcSm0vkhM00wTIngMKagLOe8GV9e9p030zgh3IVxgR7R7iC/ognwInSza38pr+yf6bUCjaBTLhUudb1QEEATScPyNOYwefnz4Qdu5H8EWF+2WTieR3/X4ErNfFSI7Tus4Ihcm8ZIn4FUeQ1BLY6osOEy225g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785633830; c=relaxed/simple; bh=Tkcyj1pIcSE+uem/7Raqyt4F4YMYHe/HbEy/1nXpsj0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uvzLIbAbv4AVfxhGZ8o8+PQgl4Blu9KRxWygn3dpVwEl1byXkUhnnkFSc3W4f6d74Y41HXbrIcs/eM6K1KkMgc3IlOjrsjSo3d65ldnFCMcF7HN/iT6IDmV13Q1+VQsgg2ErptojEcHo3VtS2eZAKgu1LhWpofSrvQpL7IOVSQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zzu1CwmS; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zzu1CwmS" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-c9eefcf9175so1913270a12.3 for ; Sat, 01 Aug 2026 18:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785633828; x=1786238628; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=3pTsE0k2zb7kd5dP6EHONBGSxmW+mcist3GzpPTbszk=; b=Zzu1CwmS005pxz3dquClpTNOUD13sMYLvvY9UONgOPKOdfW3hhwe+JyufEouzdyVWS yJQkpQeUNS5EqJGl9zOM6YW6fgfrjSjQuSnBtgrGKdUGsqVBXnJtQe6GLAOUZVoGAs6g BCj806hdpwWx70wAOZcMQwqeQAuE7IGPk5XQmeBlLPGrf7K/SZzxUjCq3GeUYMjQ96Zz BJVhqsLwD5hEqF/HcIIZ4eBa3Ddgsiffh0qMgyYRjn9PwxKKz9FsHzjQhguFTFtJgMxP Y+dkBoDFQxpMZCmQ0/7FNzKiQNllUT1+uj385F9xipN92kVS488/O6lXJk8UqHDr0YFp oixg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785633828; x=1786238628; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3pTsE0k2zb7kd5dP6EHONBGSxmW+mcist3GzpPTbszk=; b=EoEhOz8Fd4K2v5CtgYMJMuAN4DXW8a62focrVuT2ww91RRCXuiD5lDGnYlVkRXNEoJ 79grexTFOXn1c9nkusRtF37W4sW2d/KdyCb6fUBmOsUcDyZTeBDJOTEdX3XqgDyEamcc fGsqZ2SF/t0O4tVuDB5jTgUW10xJzPDBDQoM1Z1TRaX0rwX4jHsLi4O/Z/rRORjzetID K01FrI0N+OtXGg9SOyq+OLm8WfGCvtjLZy+Jd3bSUVQvA8M2BKcTsnnbKTshPlOvQ8QK YRh0AixpVSEB+T0MD2vORKY8gweWviTr3tCB+3/JK28xjB0WrvyLl193/E9EKA0Qlk9y 2B2Q== X-Forwarded-Encrypted: i=1; AHgh+Rqq0pWrgkopjWALiggjPR3BQEcVsBt5agaHS2KayS24IAQL2/9OcVWCeeIcQjnleOHrPD8OJIhmwjvgE10=@vger.kernel.org X-Gm-Message-State: AOJu0YzApZMIXHIRdPqdBJJtvI24UBTU5FJo0Bfu2oOz5urYIQScEZlu XQY/P0axcNwwVEsQp8Z8rGkm7YwDVhfiYX7XH8NbwlMR30P+uuRqZplY X-Gm-Gg: AR+sD13QVFUBF2Xk6KwscJW1Q81w5+XKKKHAWSm0IxExIyGw0fNh2nXfSpafPedd3rq bkAVMmYSAOoir1GXNxmxFv8cPxMTrF8JKQRVOfBcq+8fgI84NZZEidCCQGhtszj3gecvYMHw1WB Zf2T7ZUZyuZJBGkZ3dqdQ6ETToANfAvY6FmEpbI3szunRMJxmBrHLaPJ6JDy/8mFLFAUMMaw4wm lC2DmZoruFtnX+NU7nHWvVn18oD376RnvPiF3ouVddP8ROS26qiJ/wpWoCZLySUicNxYnyQHq8m FLx3T016+seTd4unadpwW4GYeHVdEXlbUrOfdIvp3B3oTcE8KyZQ1mSv1WujDnoyRNRGaAAOoPq GgHXZxsIrlSDEFW6kUU45J4I8tYii1MYuUF6H15U0rflsIgiUVjhhcbLZ93hDG2ZphFdwSbR05D jhMk4F2dRmb3KHn50HCRQlDUMeY5SwOAqcX3LfrFW1z1uuLW6uzbR9eFry88e7V7cLz7bdYchzM zgTXTTbToNyMPm/PqffFVgXXQ+34+K+bjBMVZMwfpi70RKeIeOw33rtWYvGNA== X-Received: by 2002:a05:6a21:6b13:b0:3c3:b57b:6285 with SMTP id adf61e73a8af0-3c92a51e081mr5409487637.13.1785633827927; Sat, 01 Aug 2026 18:23:47 -0700 (PDT) Received: from debian13.localdomain (bb219-75-96-14.singnet.com.sg. [219.75.96.14]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153e18e114sm36906954eec.28.2026.08.01.18.23.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 18:23:47 -0700 (PDT) From: Adi Nata To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, u.kleine-koenig@baylibre.com, adinata.softwareengineer@gmail.com, dakr@kernel.org, bhelgaas@google.com, mazziesaccount@gmail.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linux-kernel-mentees@lists.linux.dev Subject: [PATCH] iio: humidity: htu21: Fix SYMBOLIC_PERMS chekcpatch warning Date: Sun, 2 Aug 2026 09:23:26 +0800 Message-ID: <20260802012329.9877-1-adinata.softwareengineer@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Checkpatch warning: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static IIO_DEVICE_ATTR(battery_low, S_IRUGO, WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. +static IIO_DEVICE_ATTR(heater_enable, S_IRUGO | S_IWUSR, Signed-off-by: Adi Nata --- drivers/iio/humidity/htu21.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/humidity/htu21.c b/drivers/iio/humidity/htu21.c index a9dbf08b4f1a..fe7192d142ec 100644 --- a/drivers/iio/humidity/htu21.c +++ b/drivers/iio/humidity/htu21.c @@ -154,9 +154,9 @@ static ssize_t htu21_write_heater(struct device *dev, } static IIO_CONST_ATTR_SAMP_FREQ_AVAIL(htu21_show_samp_freq); -static IIO_DEVICE_ATTR(battery_low, S_IRUGO, +static IIO_DEVICE_ATTR(battery_low, 0444, htu21_show_battery_low, NULL, 0); -static IIO_DEVICE_ATTR(heater_enable, S_IRUGO | S_IWUSR, +static IIO_DEVICE_ATTR(heater_enable, 0644, htu21_show_heater, htu21_write_heater, 0); static struct attribute *htu21_attributes[] = { -- 2.47.3