From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1031F1C860C for ; Sun, 2 Aug 2026 03:16:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785640581; cv=none; b=FF1WN+TK+W4nMEMyY4CDDVWMehxQsDqiihdjOds01B/hpG9JMx3XLcBpsot3x8bZWrkLih2XEX8HOZLWJQ/d43DfCbTi6xklMEIwB7qOiPe2KfsZucjya86v49X9B+VBoBzBl9KT4CV3Hmv0TjciIJO4QgQIiLT5/WVD8NQCcn4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785640581; c=relaxed/simple; bh=/XhZ1aVu4At1OajSWcUasRCtEb+jFFura59MTLZj4ss=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=h6FYAut2GK6SpmxW/DrVgiphZwMiROI5dFWGinhWw2Uk3oAwe/TCy8Vzh3+qirD42kii676p+L2SbZdn7YaQWdLPXTzAea2mgxXnm88COGlxw+sH+iJKhEb7+EHmzxvoc+nFmIJ1bpNXhuW+UWGOsmzSpBByrofk4CZ5VKujz0A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hEedcliD; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hEedcliD" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-382ef647e20so2465581a91.1 for ; Sat, 01 Aug 2026 20:16:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785640579; x=1786245379; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=J8kkEhJEL1gBoW9A1iqS1uDrICA5x8rxqvqKjWPtAyE=; b=hEedcliDqgeoLbJGWP3yzC73b9KnMLcxpTGF2gLDssGELBoqtHFC+rYLmzyak6llM7 i4gI2OlnU+5dHwu0wqLvOTo6YT5GQA+FF8jVO1jWR0idfXTh7kna9A1xBRKjVY0o9qKW RlyCDoQbjEOjV37TOlWwPFW3bQOdypk4yMiR6cyhxnFKJbSbTFsw1Ro0myILMM9wDjCl Z32fgTaEYe4dor3WUR235b9LOaJxEJ7BLE3FcoPIBogWN/t9AeDAl+lfpNk89Iu7v7j7 NEMNGcSyvKlLPgZxrqqy8sudxqjaypnEy2fTSta9JCOIFXFv5y9jlHqQpsc6Hd6Fy5GH 6E1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785640579; x=1786245379; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=J8kkEhJEL1gBoW9A1iqS1uDrICA5x8rxqvqKjWPtAyE=; b=AWoLUXHorgDWvCfBqLuGBDV+cOpauGIQ8K0qvO7iGWxNApaz2esmAGmDAVl7wb04Lb rfKuP+mbzUZfDMEMLLhuKTCiHNk0IlNSh5uRyHAdwMKXCPCOx2xJuF0OJP38yzBjdM1h fwnrGxJmiXr/W0rbfF3O6Z0n92hzHwkPd/i6ph1hF9gHWDkQ06b8xranNJpyQLVRPAeu gM3e61WQLPc1YP89Rz+xpZNZ3IpRWoEPP+/nMhJ6d0kPCkqGiFZHBRERTq7ZKQMeRQwi oxj1heGeVNuuckyepu+5KPdX3sG/jM/WvhOqSHRUu04qdZwMNjOogYSFy18uy2CC0Oeq 8LAA== X-Forwarded-Encrypted: i=1; AHgh+Rqslp9B4UF+NNQqvjfO6Z1tax+LCWvy7HmmV8CllSywz/QvFGjI4cQ4lb/etE+LmA5nRuDfPUAxk8uU53s=@vger.kernel.org X-Gm-Message-State: AOJu0YzRZo3UpWden4b80mL3sPndsRs4EZZgVQhqBmyE7TfzbS8Z3FIz xsbg0QiuXtbvdZqBgQLwiPaKVfFGjsFxQM3UC5R4VK8W0jUzjpZo/WOqjRaIfNtliQyV8g== X-Gm-Gg: AR+sD12scC26i8qEobF3bO5X1TcBhtynXwn3KdUBY5zUed10WC/KS38NHVGh6S9tX0O x7Al1wBeCWlFNCt+l1gD8EUtnCQt5o6jgZ5bnioCaeQhiMw00rWlohqQf3X3SvT2/N2I+C7Ei+r NtjO/f3sIe5SWm2NN3paHIHmZ9xMdy2zBPPB4oJ9TW1X1dUYrw62gMYgjVD7jKhaM/O3LzX/z54 AFJrYVThaR0hqMRTyOdAKvZIBxBSjqgJi/C+N9Uu7vqdFVUPcao/hQSKzHdra+yQPRufwhXyvpM BUh46Nv0LlHP85/jhWk9WCQnvJph90bwSfV7qXKgQrBUcXqgnbEXPVFP05FzEXKHhkim3u8MJkY zOv/e5H0RjemDEfXWwFLQg3hZj7vP49IPVRmntug8n3xwtmeWOY1aUwrirEdmZIoguV6mMfMKPo UlDQGnkacBKPkMW3flDnx6EIXg0K1YhmTTWDdK14bFSHiy/NZhB16chJcayJ7xRw== X-Received: by 2002:a17:90b:5746:b0:38e:67e1:15b with SMTP id 98e67ed59e1d1-38fbc40e2f2mr4915356a91.6.1785640579288; Sat, 01 Aug 2026 20:16:19 -0700 (PDT) Received: from xiaomibookpro-14 ([149.19.17.31]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13fab4e44bcsm25356701c88.12.2026.08.01.20.16.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 20:16:18 -0700 (PDT) From: Zhefu Zhang To: Dmitry Torokhov Cc: Andrew Zhou , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Zhefu Zhang Subject: [PATCH v2] Input: atkbd - skip deactivate for Xiaomi Book Pro 14's internal keyboard Date: Sun, 2 Aug 2026 15:15:59 +1200 Message-ID: <20260802031559.19701-1-a723356@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260801101908.33838-1-a723356@gmail.com> References: <20260801101908.33838-1-a723356@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The internal keyboard of the Xiaomi Book Pro 14 does not work unless atkbd skips deactivating it at the end of atkbd_probe(). Using 'i8042.dumbkbd=1' also makes the keyboard work, but then the driver never writes to the keyboard at all, so the Caps Lock LED is lost. The atkbd_deactivate_fixup quirk fixes both without a boot parameter. DMI: XIAOMI Xiaomi Book Pro 14/TM2424, BIOS XMAPT4B0P0909 05/06/2026 Signed-off-by: Zhefu Zhang Reviewed-by: Andrew Zhou --- v2: - add Andrew's Reviewed-by - explain why i8042.dumbkbd is not an equivalent fix Previous: https://lore.kernel.org/all/20260801101908.33838-1-a723356@gmail.com/ drivers/input/keyboard/atkbd.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c index 8cb4dc6fb..6c897282d 100644 --- a/drivers/input/keyboard/atkbd.c +++ b/drivers/input/keyboard/atkbd.c @@ -1938,6 +1938,14 @@ static const struct dmi_system_id atkbd_dmi_quirk_table[] __initconst = { }, .callback = atkbd_deactivate_fixup, }, + { + /* Xiaomi Book Pro 14 (TM2424) */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "XIAOMI"), + DMI_MATCH(DMI_PRODUCT_NAME, "Xiaomi Book Pro 14"), + }, + .callback = atkbd_deactivate_fixup, + }, { } }; -- 2.55.0