From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ADFD70830 for ; Sun, 2 Aug 2026 06:55:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785653749; cv=none; b=ICZrhQZOcY0YwzEgRJVZKxWmdaaW0krcA3+RUg3jTqEGByx/CXTPOV5AkPhfyv0ScXvkC6ZEbAnLZtXnr0m6uHzd7w+di0DKZIgFMr+IgnThLjwZZayVHWCWGOrzLeIjrUP4xW9Q01B045IdzTXBZSqy7gilOhxDDKGVTniJgb4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785653749; c=relaxed/simple; bh=O0QzfMOPr6vkrOHrhbKyJAHJOjCmMJTXKRxMQ/xCu50=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=M5HIU1p6BpC0Mcr3xNX+H8DaWP+wrXdWJYGOVTNg0tcZWCbmiw6UZTFvZHCAGdmyegHjYe14u7UQasfQGNCJWTqvZGBnkuYqPLgduGxmcarDIpLNrwlnDPfsJPfmhetgTQnqHb5VNG1TIdBNMg4106UuzrrRF+YIlEmevnWOoKw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HJSVOCmT; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HJSVOCmT" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-3811f512167so2393800a91.3 for ; Sat, 01 Aug 2026 23:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785653748; x=1786258548; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=f8LYikitMrC+BH+jG/GkXkTeEEEki2FXKlfuLfV91rU=; b=HJSVOCmT72GlPOmufknuGfA0G/KuRhq9H7kzDXKBW9DFqBfR4yGPqEcrsktSUJOJB1 WQV63nNmTp3pWvfA1EZ22Wz4cK1BhDB2DFuidHyVdMPT8hFXwXhIk5FYMTG/6sMP6wv5 ULo5xfnO0zw2S4/Xe+Ml+3yC0maF6FvpVyuMgVTu9ibx2hQEHDQCy0xp7SyzWCVZM49l wRjMcCI7r97q/x8y8vSK1WB0Kbt5r7CJBBrClmjR7qKyj3Md+LhTMCG1ownolOWqnD/N qgi69ZD7g5ZQUxGno1jiktEUpUTM9MaKTYQUSAVx63A90kEqKw1QutZIQvMmA97RfIux 8Bsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785653748; x=1786258548; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=f8LYikitMrC+BH+jG/GkXkTeEEEki2FXKlfuLfV91rU=; b=HTJhupOp1Slk3n6q1pd0dl6jaILsvDjn9VmQgjRvj4Ue0UyLk3cHM/ak7xK8Q3XiHK A3w4BvzzJGal761IvSnq5dgprSWzCv+qMBPiSwBolnSOfvMKg2kKQV/IpZ41cPA37+8V S5tCNBfvSzf/1mPQh+xxY6C+/h4+8U02tH/yI6CyoYC57zhdgjOEUErCuTcpp277KYMk N74YAzb/DNkQM3SKcbabnmDK5JgC2bRAmxc4ZjmdzKq32023f3vfEZ4QI0i1XWAZboXl 7oktz2bV0pDk5Xx2Vw7mpOAYoczvd9QoNPziZ45b72DLFX2lDPN717XH5kiV90cCbagQ Z7dQ== X-Forwarded-Encrypted: i=1; AHgh+RqMkDEFZOj48F1A0ABiuthxACVxb2C0xInJDzx/MTMN6OUHLRC50v6SekKMPnUdlNcmhILyjcoo7SUA0MY=@vger.kernel.org X-Gm-Message-State: AOJu0YzBvOxdvlXfhBX9z3Hxv+qd2C68XBuIzteJEakeKvGQzLbvTFx1 NdQmSxYVC5rXH8yd1qLIc0O2u37DDBreQEbqPOcPxHvV6RYf3bc/CEBY X-Gm-Gg: AR+sD11acz9zEX9mW5nkS7t4aoOqjgG5FMp3VGO+fwAUdEuzqdVRXPO/S587/GCWIE3 nZDcV3u5FAoYPPkVRWuZ2OEL56fpCJWBeovhThnc6hDLwlNW/82qRLBXjm5SE6kR8dMPXd9VphI L7EICBac7s4ZhZ6GqCzRPmAtqSSOHt4eKei5eI7p+YxiHs3rgCZ+YxaCrja2hwZz/hQI1vg/dtw dxY+i1O+FnWpVy7NVrl6c7GRL6+C4Bo8yBY2+elEeoN4sN+FfgD5+6Wc4QgOSVr+vaLHFgr0ulK ujss1ms18pic5tcLT+nkGBEWSi2C7tDgRWOlrptmk5vpeo8pqMNI0kO/LVGhujZYmeC7v5+VPr9 +3kRO/KLfZ4VSNKMHBI8lGdoSjiNP4OeQjBFRX5LFAhuRPCNpPhVSmOUXwiulXWz3SlL1iS1k8j NTEcSaWChNi5RFhAOzPNG2aQXRlUeXMmC/2LvyqLYN/ZFd5/SPDBRHQOPsNu6jF924OYytJmnn0 oiKUkNy+qKqzuE6 X-Received: by 2002:a17:90b:5111:b0:37f:ad36:8fc5 with SMTP id 98e67ed59e1d1-38fbc53430emr5982092a91.23.1785653747827; Sat, 01 Aug 2026 23:55:47 -0700 (PDT) Received: from SGN-LDSENG.tasernet.com ([2405:4800:5cc3:11a:1ac0:4dff:fe8b:4a69]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13fab24ec10sm19641297c88.6.2026.08.01.23.55.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 23:55:47 -0700 (PDT) From: Cong Nguyen To: Linus Walleij , Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] iio: gyro: mpu3050: fix sign of raw angular velocity readings Date: Sun, 2 Aug 2026 13:55:40 +0700 Message-Id: <20260802065540.8120-1-congnt264@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The MPU-3050 gyroscope output registers hold 16-bit two's complement values; the angular velocity channels are declared with .sign = 's'. When mpu3050_read_raw() handles IIO_CHAN_INFO_RAW it reads the register via a big-endian regmap_bulk_read() and assigns it with: *val = be16_to_cpu(raw_val); be16_to_cpu() yields an unsigned 16-bit quantity, so negative rates (bit 15 set) are reported to userspace as large positive integers (e.g. -1 becomes 65535) instead of the correct negative value. Cast to s16 before the assignment, matching the temperature channel a few lines above which already handles the sign correctly. Fixes: 3904b28efb2c ("iio: gyro: Add driver for the MPU-3050 gyroscope") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4 Signed-off-by: Cong Nguyen --- drivers/iio/gyro/mpu3050-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-core.c index d84e04e4b431..07c0f9011c63 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -356,7 +356,7 @@ static int mpu3050_read_raw(struct iio_dev *indio_dev, goto out_read_raw_unlock; } - *val = be16_to_cpu(raw_val); + *val = (s16)be16_to_cpu(raw_val); ret = IIO_VAL_INT; goto out_read_raw_unlock; -- 2.25.1