From: Jonathan Cameron <jic23@kernel.org>
To: Adi Nata <adinata.softwareengineer@gmail.com>
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
u.kleine-koenig@baylibre.com, dakr@kernel.org,
bhelgaas@google.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH] iio: humidity: htu21: Fix checkpatch tabstop warn
Date: Sun, 2 Aug 2026 18:04:50 +0100 [thread overview]
Message-ID: <20260802180450.33fbab86@jic23-huawei> (raw)
In-Reply-To: <20260802013333.12689-1-adinata.softwareengineer@gmail.com>
On Sun, 2 Aug 2026 09:33:31 +0800
Adi Nata <adinata.softwareengineer@gmail.com> wrote:
> Checkpatch warning:
>
> WARNING:TABSTOP: Statements should start on a tabstop
> + }
>
> WARNING:TABSTOP: Statements should start on a tabstop
> + }
That's an amusingly uninformative set of warnings. I'm guessing
you cropped out the bit that says 'where' those are?
Anyhow, I'd not bother with what checkpatch printed for this.
Instead just say what the change is and that checkpatch suggested it.
Thanks
Jonathan
>
> Signed-off-by: Adi Nata <adinata.softwareengineer@gmail.com>
> ---
> drivers/iio/humidity/htu21.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/humidity/htu21.c b/drivers/iio/humidity/htu21.c
> index a9dbf08b4f1a..908661c64eb9 100644
> --- a/drivers/iio/humidity/htu21.c
> +++ b/drivers/iio/humidity/htu21.c
> @@ -105,12 +105,12 @@ static const struct iio_chan_spec htu21_channels[] = {
> .type = IIO_TEMP,
> .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_PROCESSED),
> .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ),
> - },
> + },
> {
> .type = IIO_HUMIDITYRELATIVE,
> .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_PROCESSED),
> .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ),
> - }
> + }
> };
>
> /*
> @@ -122,7 +122,7 @@ static const struct iio_chan_spec ms8607_channels[] = {
> .type = IIO_HUMIDITYRELATIVE,
> .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_PROCESSED),
> .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ),
> - }
> + }
> };
>
> static ssize_t htu21_show_battery_low(struct device *dev,
prev parent reply other threads:[~2026-08-02 17:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-02 1:33 [PATCH] iio: humidity: htu21: Fix checkpatch tabstop warn Adi Nata
2026-08-02 17:04 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260802180450.33fbab86@jic23-huawei \
--to=jic23@kernel.org \
--cc=adinata.softwareengineer@gmail.com \
--cc=andy@kernel.org \
--cc=bhelgaas@google.com \
--cc=dakr@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox