From: Jonathan Cameron <jic23@kernel.org>
To: Philip Mueller <philm@manjaro.org>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Alex Lanzano" <lanzano.alex@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] iio: imu: bmi270: add BOSC0160 PNP ID for gaming handhelds
Date: Sun, 2 Aug 2026 19:01:21 +0100 [thread overview]
Message-ID: <20260802190121.73d3f1ed@jic23-huawei> (raw)
In-Reply-To: <20260731195325.44453-4-philm@manjaro.org>
On Fri, 31 Jul 2026 21:53:24 +0200
Philip Mueller <philm@manjaro.org> wrote:
> Adding BOSC0160 as PNP ID will enable more gaming
> handhelds using a BMI260 sensor with this PNP ID
> to properly use the bmi270 driver.
Very short wrap. Go up to 75 characters.
As in early one, ACPI ID not PNP ID. Ideally we'd also have confirmation
from bosch that they have assigned the IDs like this. I ask in particular
because they have multiple parts with 160 numbers and they aren't
all supported by this driver. E.g. bmg160 which is a gyro only part.
+ Can we have at least one example part that is using this ID as
a comment inline. Some of those earlier discussions of bosch IDs
identified ones that we were fairly sure were only ever used in
prototype devices.
Jonathan
>
> Cc: stable@vger.kernel.org # 6.18+
> Signed-off-by: Philip Mueller <philm@manjaro.org>
> ---
> drivers/iio/imu/bmi270/bmi270_i2c.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/imu/bmi270/bmi270_i2c.c b/drivers/iio/imu/bmi270/bmi270_i2c.c
> index d7faebcbd2fa..839e71b65f05 100644
> --- a/drivers/iio/imu/bmi270/bmi270_i2c.c
> +++ b/drivers/iio/imu/bmi270/bmi270_i2c.c
> @@ -41,6 +41,7 @@ MODULE_DEVICE_TABLE(i2c, bmi270_i2c_id);
> static const struct acpi_device_id bmi270_acpi_match[] = {
> /* GPD Win Mini, Aya Neo AIR Pro, OXP Mini Pro, etc. */
> { "BMI0160", (kernel_ulong_t)&bmi260_chip_info },
> + { "BOSC0160", (kernel_ulong_t)&bmi260_chip_info },
> /* GPD Win Max 2 2023(sincice BIOS v0.40), etc. */
> { "BMI0260", (kernel_ulong_t)&bmi260_chip_info },
> /* OrangePi Neo 2026 (since BIOS BCPH01_V1.20), etc. */
next prev parent reply other threads:[~2026-08-02 18:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 19:53 [PATCH 0/4] iio: imu: bmi270: Match PNP ID found on gaming handheld firmwares Philip Mueller
2026-07-31 19:53 ` [PATCH 1/4] iio: imu: bmi270: Match PNP ID found on OrangePi Neo 2026 Philip Mueller
2026-08-02 17:47 ` Jonathan Cameron
2026-07-31 19:53 ` [PATCH 2/4] iio: imu: bmi270: Match PNP ID found on OneXPlayer X1 Pro (AMD) Philip Mueller
2026-08-02 17:58 ` Jonathan Cameron
2026-08-10 19:04 ` Andy Shevchenko
2026-07-31 19:53 ` [PATCH 3/4] iio: imu: bmi270: add BOSC0160 PNP ID for gaming handhelds Philip Mueller
2026-08-02 18:01 ` Jonathan Cameron [this message]
2026-08-10 19:05 ` Andy Shevchenko
2026-07-31 19:53 ` [PATCH 4/4] iio: imu: bmi270: fix typo found in dc757dc Philip Mueller
2026-08-02 18:02 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260802190121.73d3f1ed@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=lanzano.alex@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=philm@manjaro.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox