From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B6A8259498 for ; Sun, 2 Aug 2026 22:23:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785709391; cv=none; b=E8qQuYQ8ZLgAJibxRaBJm7sU+fz3VPou1Yo9+pKZ3NMNk1dg1S+BKdEMl1pP/fw133LiN40nraFF+4iJ/qsLfxt2cie/u5HniRtw4SLJC32iXpYrvWz0L0MIX3RPF+DaAVdCt7QRUdrnVdzP57vWdqaFcBgxPCmAtE5NoM0PYzs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785709391; c=relaxed/simple; bh=k/PWOQgo1p4Yp1h5/yZGB51G2UQvJK1mFc6oQmkpaxM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bWzKOtwFcUEGE7/hWCPyswz3gFbfo1mBgQGI+5Mw9pLYiAhwj2AVCH9PDh5tiQ7aYPoi3/Dr5ZG/aJigK2ItqQ7LxQi6Zs3dtUx+xLNwI1WIUb30xHTfOn/FuRQN1Vnr69AackJ0IRGJ6RvWFwt065Bn/hOdV5qCmqg29zbjiik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sRfACfKi; arc=none smtp.client-ip=209.85.160.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sRfACfKi" Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-51c0ecfaee7so16198141cf.0 for ; Sun, 02 Aug 2026 15:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785709389; x=1786314189; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=K+YpikDeGg3PaK1+XecbhoXs6xNS16wdVuw+OggeHyc=; b=sRfACfKiKm7bcvKniB6pPlh1WSURAQoXATW8CfMD3ns4FoGgtO4yppEJx2SUIkBBmO ho5zdGccfBz1jkM1ss698f6nRgDM8mhpjzIgC7Sa1j00oBVDlfnzSWeo8UKDMSyXVlOe u7i7X4VfX0+QIi2SaAv8PlEVNCIBLw4gzJmLTQpaPN8I/4eqfj+CidYDLimEJj5YdrJI dfhJI4BppFDGCdKT7LVDR2SDvfaO8PJxtmVfMh0wIuJkYqKsgD+w+MHwnb3HG0BXxDuc fuxgd1f9lriNvRDYaxKiWb3orEpEphCdnQ1Reis1gaFmeOm2dL7G2+3G4mG2rJ/gjSxJ 0SUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785709389; x=1786314189; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=K+YpikDeGg3PaK1+XecbhoXs6xNS16wdVuw+OggeHyc=; b=RJWHYNqUedK4TgQdqBxhwSuvaAeSMLR858a0rvf7aoHfS9dOln0YQVAQlwPvLZQ5D0 aj1+1QTL9t5Ez4HR8KoDAVVMFPIpm1vv0QocSIUtV8pcurE7JTfNyCq79pJ/Ao9kjCj6 oaU3UwSs50BeJAkdC0BVc1FiJ4/RYNvSLvujeY9z3QKiQr5x83n0OOkQsY/wXYrMvMZi 4JfgU/c20+n97JIfyh1Q4GxpzWwer+lonvw9ZhhvWpd13BKvdp08/KnF9xJ0ZReh9EWa dXqoja1Yx2iCXlJGjAEB89Ri5CztDR7pUOU4oBnMliS/2ry46Ogqc7eXDxyjIpe+6EDC j5+g== X-Forwarded-Encrypted: i=1; AHgh+Ro6x6WgVz1egHzb5nJQQ576IInpMTlPjzjn5hK3D0zJjXgRduyVtbA5N521Y0rv8cJ1tm6QNUDGsmaFVcY=@vger.kernel.org X-Gm-Message-State: AOJu0YyJfBSwSXBOC9o0gHe7YyxVlNx1qH9cUQ/8BtKCyPRW6KXJ6Ttn 8Ni2e8Gz6ekHalWs6XPAjm2bhwN4StXpAOJArQnC2hvJzhdkmqUJuyai X-Gm-Gg: AR+sD13j6mvB+qHdf2ZbBzuVdPbEj4Kx3L780y10Jz7VoYD7Kb/5Kt1b757/AQrixqc k5vh/+OBmxNIYVqbKljPSWhMJEtfwhF+nRi6UR0HgmmHmN6ho1cLWRrtmWWFrT/o8D0A7WjgnfK +VQA6TTMouhm2iPgq+wvvmWlw/necFxf3o4W3ZwSEt2fLq7azpl2R70l5+wwtH5DFw5l7qrZgYA QMJ2C2ZdZPDGKYREWPeo7JZ+GORwrle1INHku2mVtxFbji9ZYtRqHRQm3i4yidUu8cYVCdygXil q4KLV4tTHLFlTbqWTTgEYrjqdtFdHVWqj9YL6aWjsjb7fMM5Dteqpfk3aVPv1IFWb0DZTfku+/U eidjMjliq4QDHLMr5puz4WpgWy60SrHd6nsvJBlwW62hUfEVxHOM96kFfbRyPLuDIssK4QNb6Pe nM6upHzDl7x9YojIjXljMAVeL0PH6ghqtO8fn4jtEAod7bQxtKTZCJe1kAWy88PT+GtHOskiRms L5MWerB6JMyfc1ozk7KlNhHTPbsj52sk5Zqic6YCYURVWeJJ4pMUhZ2KT8h5oI= X-Received: by 2002:a05:622a:2612:b0:517:642c:8196 with SMTP id d75a77b69052e-52b566db0admr173984281cf.12.1785709389063; Sun, 02 Aug 2026 15:23:09 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-908434a250csm61249026d6.13.2026.08.02.15.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 15:23:08 -0700 (PDT) From: Yuho Choi To: olivia@selenic.com, herbert@gondor.apana.org.au, Frank.Li@nxp.com, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-crypto@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dakr@kernel.org, o-takashi@sakamocchi.jp, bhelgaas@google.com, Yuho Choi Subject: [PATCH v1] hwrng: imx-rngc: Disable clock on registration failure Date: Sun, 2 Aug 2026 18:22:59 -0400 Message-ID: <20260802222259.577200-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The RNGC clock is enabled manually before runtime PM is configured. If devm_hwrng_register() fails, probe returns without disabling the clock. The devm_pm_runtime_enable() cleanup only disables runtime PM and does not call imx_rngc_suspend(). Disable the clock before returning from this failure path. Fixes: 7a96a64e8689 ("hwrng: imx-rngc - add runtime pm") Signed-off-by: Yuho Choi --- drivers/char/hw_random/imx-rngc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c index 28c56c2d1bf6..a2db26d7f790 100644 --- a/drivers/char/hw_random/imx-rngc.c +++ b/drivers/char/hw_random/imx-rngc.c @@ -313,8 +313,10 @@ static int __init imx_rngc_probe(struct platform_device *pdev) devm_pm_runtime_enable(&pdev->dev); ret = devm_hwrng_register(&pdev->dev, &rngc->rng); - if (ret) + if (ret) { + clk_disable_unprepare(rngc->clk); return dev_err_probe(&pdev->dev, ret, "hwrng registration failed\n"); + } dev_info(&pdev->dev, "Freescale RNG%c registered (HW revision %d.%02d)\n", -- 2.43.0