From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38A1D312837 for ; Sun, 2 Aug 2026 23:26:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785713162; cv=none; b=uCJQ+XneCUdcRj6vGtvTkoi17ergTKljleSe/k1N9GGkT9yJUlm6a3LSorm2Ug9nFcIzQxrTl0b10y4ly89o4YMYhNBcQgmalc81DBYqaUL5CYXHA0d2VxIDGG+Rp9s/nXboV/VKd4r3kfX2N/PemLiV1Ve9YoizylCK+V0mENc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785713162; c=relaxed/simple; bh=Th9JFAE7KPZhGbzM0rNwHh3pmkdJDKbQi50Kfb65Utk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nBEl22diaSCK1ev9XlGQTfskW4IIOdX2bmpY5Jpo9Nh/1OnXOgxa3n9wBpYfM/NvFnR8qr78yvi3rRZpvFo4i35qEKU3U+7C4blJ/O6Br9QRMg52YIYn4a6RHMz05czBhtuplTk5zMlwjjNinB+zA1uLElNyBpt6eeLC/x7q3fw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mtuEdYNn; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mtuEdYNn" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-8f29ec73064so18081396d6.1 for ; Sun, 02 Aug 2026 16:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785713160; x=1786317960; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=b2siebzQwyclmXl9OQ0U38WMcozmoMwIPul2McG6A9c=; b=mtuEdYNn96IgTBbKdGRMUFkoifdbsozmvG//wlfewKrXjpB6GVhd/CpwPVZYOOIzeD ARxd4z+71TxCpdlxGrI9hNl4ayhx/OIq9f0pRqfDkNRUrdeSxnjKLevNh1Di/rOY1rEA //GqANU+ndyNlYi5S9fK7prVWJqGPoezFiC2tFiT3Gw35Y+3OlXdSpvRZUREMfS2t8Kw 2W2Z6M/ywU3SqRbxQvGezoBNY14X9/WLqLtKsAB80rMHa5rgjpljNdmLI9bDUld3mvbF L448rm7P7Lh1gZGVii5weth/eXjMhDY/eb1teipAQHWIr8OEWsdgRmBDT6RgUkDjdWmy UPmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785713160; x=1786317960; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=b2siebzQwyclmXl9OQ0U38WMcozmoMwIPul2McG6A9c=; b=Bv7opeaegNaN9/dDK5Lv6M8M2KNNltonEyrKNxcHdUE/i7JILvD4HXCpoGD+M1qYSv 7+Z73v11vsoH0umZmm1+0nRUIMPycbBAOJbFy7JznnD7UC/nRyyL0zxoLATI/E+gKNPL wEQ+GDxc7AbaDNNa4XcA1+fshYFUvBBVCrTTSim6rqLG757H5cN3yV2x9SyX5dwFThm4 zWwJCFXY8xMpMWUzoR1p7pRmxmrGBBc93FNb1fZb3M6YKoI3naPswt1LZERytgcGBYAt /8/fWy70sk7NO+TrR1tSu4UkzOspcfLRE0pnuviBrRM1bPE0aWqy/bp0TORL0aWP6dKd HE8Q== X-Forwarded-Encrypted: i=1; AHgh+RrredtQ2CUi5DgUMbAAwZu4fQr8CQUeq8Q9w6396+4+X3uI92pjWyaZFPz1MP6k9+Tkz0Xd0ZJ7+gpzOQo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9E8b/fnLpJPdL9+RlrEnl11SV5kL1k/lDug+JqROjBNeqSKlw 14kPISDZJou2BMjZQZfTxoL95FL6UuVP+JdqhBkRQ4eQOKwKeQKlIOxa X-Gm-Gg: AR+sD12Z4KONFXjsVDSUOYeVQ2WK1zLaS1jeqPw4/jvDls5pGa/6zWoC0e9WMOFoR2P d5LBvsjMcXqPPQZP6Ix9J+pwxaJxykT5wAemhOBi2zqC5tyjQrgk/GqbqfwROU5yRL+eID1uOzx jga1ynBIxFofD/EbyYHusVbMXbijaXLgSqBuHP3985bXmWufjASrM+qZLju2YWXt5JSAj8EaLyf 7G7CkyO/L0b7OmsdEkaXfGaPumHl9vc9HbsN/jdzfg5pryelljkkJy77CKT3sb61xIO2tmVQQMb TEMYK3uaVx39Ubu8pnwIthN05iYpMba9T4MnbrUQBvajEyhrHybY64KJ9B7AuXLQ/M13WzN+Nnl /blxdBWTN9zMeJEdZpQ2eLWc7UKPPARyh7gMpnzbRCy9H9uL5/OtlXsxtWwFqBKoxIDKItWXxZR kmshCMChxdpwxpf8/kLFh9pFXofILtztaCIf9RQdkRY1o596dNOcGizN2TGuHNB7gjNg6VQXT0m q54uTyiB/ZfP1bhePhiA4GCQYcQaWADOOsOIGVWsVmHfl78az19OVwH6pInUFs= X-Received: by 2002:a05:620a:4549:b0:927:59bf:46ca with SMTP id af79cd13be357-934a0aa676emr1508739185a.40.1785713159973; Sun, 02 Aug 2026 16:25:59 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9349c1ee678sm540076585a.44.2026.08.02.16.25.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 16:25:58 -0700 (PDT) From: Yuho Choi To: suzuki.poulose@arm.com Cc: mike.leach@arm.com, james.clark@linaro.org, leo.yan@arm.com, alexander.shishkin@linux.intel.com, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] coresight: Check runtime PM resume result Date: Sun, 2 Aug 2026 19:25:52 -0400 Message-ID: <20260802232552.593435-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit coresight_get_ref() ignores the return value of pm_runtime_get_sync() and reports success even when runtime resume fails. A path is then built and the CoreSight device may be accessed while it remains powered off. Use pm_runtime_resume_and_get() so a failed resume is reported and its runtime PM usage reference is rolled back. Drop the module and device references acquired before the resume attempt when it fails. Fixes: 5da5325fa856 ("coresight: moving PM runtime operations to core framework") Signed-off-by: Yuho Choi --- drivers/hwtracing/coresight/coresight-core.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c index 6d65c43d574f..77d05b360484 100644 --- a/drivers/hwtracing/coresight/coresight-core.c +++ b/drivers/hwtracing/coresight/coresight-core.c @@ -843,7 +843,11 @@ static bool coresight_get_ref(struct coresight_device *csdev) goto err_module; /* Make sure the device is powered on */ - pm_runtime_get_sync(parent); + if (pm_runtime_resume_and_get(parent) < 0) { + module_put(drv->owner); + goto err_module; + } + return true; err_module: -- 2.43.0