From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: "Théo Lebrun" <theo.lebrun@bootlin.com>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Richard Cochran" <richardcochran@gmail.com>,
"Russell King" <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Paolo Valerio" <pvalerio@redhat.com>,
"Nicolai Buchwitz" <nb@tipi-net.de>,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Benoît Monin" <benoit.monin@bootlin.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>
Subject: [PATCH net-next v7 07/17] net: macb: refuse set_ringparam on EMAC
Date: Mon, 03 Aug 2026 22:08:14 +0200 [thread overview]
Message-ID: <20260803-macb-context-v7-7-4d7d4af04849@bootlin.com> (raw)
In-Reply-To: <20260803-macb-context-v7-0-4d7d4af04849@bootlin.com>
EMAC has never supported changing ring sizes: RX is hardcoded to 9 and
TX is the tiniest ring buffer you can imagine.
Make sure the operation fails early rather than silently succeed and
storing values in bp->configured_{rx,tx}_ring_size that are never read
in the EMAC case.
Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
---
drivers/net/ethernet/cadence/macb_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index af351d30adab..1476bce77f34 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -3687,6 +3687,9 @@ static int macb_set_ringparam(struct net_device *netdev,
u32 new_rx_size, new_tx_size;
unsigned int reset = 0;
+ if (bp->caps & MACB_CAPS_MACB_IS_EMAC)
+ return -EOPNOTSUPP;
+
if ((ring->rx_mini_pending) || (ring->rx_jumbo_pending))
return -EINVAL;
--
2.55.0
next prev parent reply other threads:[~2026-08-03 20:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 20:08 [PATCH net-next v7 00/17] net: macb: implement context swapping Théo Lebrun
2026-08-03 20:08 ` [PATCH net-next v7 01/17] net: macb: drop "consistent" from alloc/free function names Théo Lebrun
2026-08-03 20:08 ` [PATCH net-next v7 02/17] net: macb: unify device pointer naming convention Théo Lebrun
2026-08-03 20:08 ` [PATCH net-next v7 03/17] net: macb: unify variable naming convention in at91ether functions Théo Lebrun
2026-08-03 20:08 ` [PATCH net-next v7 04/17] net: macb: unify queue index variable naming convention and types Théo Lebrun
2026-08-03 20:08 ` [PATCH net-next v7 05/17] net: macb: enforce reverse christmas tree (RCT) convention Théo Lebrun
2026-08-03 20:08 ` [PATCH net-next v7 06/17] net: macb: allocate tieoff descriptor once across device lifetime Théo Lebrun
2026-08-03 20:08 ` Théo Lebrun [this message]
2026-08-03 20:08 ` [PATCH net-next v7 08/17] net: macb: introduce macb_context struct for buffer management Théo Lebrun
2026-08-03 20:08 ` [PATCH net-next v7 09/17] net: macb: avoid macb_init_rx_buffer_size() modifying state Théo Lebrun
2026-08-03 20:08 ` [PATCH net-next v7 10/17] net: macb: make `struct macb` subset reachable from macb_context struct Théo Lebrun
2026-08-03 20:08 ` [PATCH net-next v7 11/17] net: macb: change caps helpers signatures Théo Lebrun
2026-08-03 20:08 ` [PATCH net-next v7 12/17] net: macb: change function signatures to take contexts Théo Lebrun
2026-08-03 20:08 ` [PATCH net-next v7 13/17] net: macb: introduce macb_context_alloc() helper Théo Lebrun
2026-08-03 20:08 ` [PATCH net-next v7 14/17] net: macb: move printk() calls out of bp->lock critical section Théo Lebrun
2026-08-03 20:08 ` [PATCH net-next v7 15/17] net: macb: read ISR inside " Théo Lebrun
2026-08-03 20:08 ` [PATCH net-next v7 16/17] net: macb: use context swapping in .set_ringparam() Théo Lebrun
2026-08-03 20:08 ` [PATCH net-next v7 17/17] net: macb: use context swapping in .ndo_change_mtu() Théo Lebrun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260803-macb-context-v7-7-4d7d4af04849@bootlin.com \
--to=theo.lebrun@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=benoit.monin@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregory.clement@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=pvalerio@redhat.com \
--cc=richardcochran@gmail.com \
--cc=tawfik.bayouk@mobileye.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox