From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11C551F4181 for ; Mon, 3 Aug 2026 04:09:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785730180; cv=none; b=aehhMHVWwtV9f3j5bEDqmwKacKg2WLtaIoFyfoSRDcABSloS7XlQVUMJ22RAbfrNe4v0ec89lRUcevASGbiA7bRtprcwLgGxlwnNuBP4Teli93hSbzJ6mfh16UZw9ZKbsvEv/Qjp+V0rNdGYBRx2TMnb+rM92WFYI97S4nrvCGY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785730180; c=relaxed/simple; bh=qdkgC7X8xsrVxxAJvBjGSGkn09CNoMf1XaeV8l/xSZ0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aunU6KbKKR+9zwv9Ht8cJKG4Td63c3TxTVa2EFI5JClPHtXrwj3KttrA5w8cGDnHlzIsrJ5sZr4Apnok1K/J3EkcK5VA+2dWnANqXzzsyIn0tTy0Jm9m+zxJY/8dWQBEyNoF1tTij5pufQcsnUBEhs8jFU1UxeAWSway1mI1+4o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WKNRJ60f; arc=none smtp.client-ip=209.85.221.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WKNRJ60f" Received: by mail-vk1-f175.google.com with SMTP id 71dfb90a1353d-5c2c0e261aeso699296e0c.0 for ; Sun, 02 Aug 2026 21:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785730178; x=1786334978; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=EDVVXgDFGwdwAJNFq0Lnv/4zVTHHlmavZdUyT2s7HFQ=; b=WKNRJ60fet2pkeH763Fvdy5+0T3pmEoubCMFOpU4rNeLDBtM2QYE6zZPVeJ3md9VGv 40oxhFeRjaatkkDEzrcfrRauruZfv4YgaSw4YsGekoSTr7TGeRziwzizvlp31MBMt6RS FNX6zLDgmJIMfTI6rjBixi343wwUFIVJL7myrbMZ5/5J5ZW5teeOxj+Ln303sOLcdOox UvCEJFOvaIMf8OwRh6moE4uCpdEU1YKhEmnRvANUgb41dhgdukOTTq4IwOUkUnvG1AJi 4eEi6jfEWuEKmKwldQH/pre6+/Kjhx3IJBW6016ZL8kRw+aug+mXNwDtOwgV4nBnVTWF j6rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785730178; x=1786334978; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EDVVXgDFGwdwAJNFq0Lnv/4zVTHHlmavZdUyT2s7HFQ=; b=sL8Dp/mBO6NvBZaHPP+B7p0WGb0Dg8vxRh/w9HaOQr6vYMQ2hDLzbOC2M/yReC2xUH 2yNUPZLKPutz9DqGTxHovqg/2Xf6slWWrnPXCDubVWePzmBLQy6d3XAATXYBCmmQap07 Qxfh70O1iLgHvbo426v5en9VvOCTjpjyXY79St12vPQ3Dfn3v2J6cK4dGPknY/YyG1Bn a2CNFHMu/L0Wijd9C8TpCAPMYFY8tV8fOjpotD0FovLOdfZiEQtPC69hNJxpCorg2DXd rDqdKdg318sH69X8x4rOC/HkjGAbqJM/MeFSEWCDqHltXV72vDhxTSiLkEQOQMWoQAKm c0hw== X-Forwarded-Encrypted: i=1; AHgh+RpkMjlc1Bhw7GXmLpsoSQ/Yrj2dZ6Z1XA+ziHvph8/lNRvnOif+kAVEoUB6583XdjEWS8DfbxGoPpuayrM=@vger.kernel.org X-Gm-Message-State: AOJu0YzoGZm9t78NviSREyXtiVSCwClfu+nSIoJpsmStocIVyjqHMiRy Op35lXNj3YrTwj0jRr65g1NNYwNmlXBTMem1ARtNOxLVGR1VAOhjYvoCcfSxdXuD/pk= X-Gm-Gg: AR+sD11f8sdbXBrNu0NawHpLTRvEQyRQ9X1rzdaMBVDQ2gR7LKBtR0IKgspEKvLGWEK oCJXc0WTnXgyrXBqWSTr5Izo4kwGHAhK0Ioy4smIZ4osTXt4xOvnjYVNy1uZ1uF6BRG6XYUKApT osgIaZVYnbWiTDH9V0cnLM6qMh40bWggyaCN5bX4dhKqUXqe1MNZ81AVe9wVotzf2UtKWAMO4hR UQKP55/kppfmaJ9iquZ/tcWqBp+x5EfBF8q8YrEz7dF3dDfgEPZHw0cjvlUoou4NB1j/7yiE3HN bmY+Ixp9UPb8YzTvVAXFVMjesZzk1ZQk3dCCD15v8AE8UgxqQzdJccw91FCAjHoI8vNup9M0ujd YXgWdcGV9GTJnxWBNOZtF+Ifsdr4IXZrk7tq9pBTyPMz87yFyqNDGnLHxNdoWAatZnonqeVqB+o a6UQUQz+/hoQ7HJdV/C/UHGnR93ztSTTX4rk00CMM1xEEnhk8GzvG+9GFAG2WElXXPWIUvHKfIk c6dfFDigKCEDGDObbiCYpO/Q3ySK9oyKq4DvYdZhYE= X-Received: by 2002:a05:6102:3e82:b0:747:4dcf:189e with SMTP id ada2fe7eead31-75b2225f8bcmr5708135137.5.1785730177794; Sun, 02 Aug 2026 21:09:37 -0700 (PDT) Received: from lucas-inspiron153525.. (host110.181-12-179.telecom.net.ar. [181.12.179.110]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-759b8e1e8d5sm5366413137.6.2026.08.02.21.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 21:09:37 -0700 (PDT) From: Lucas Jeffrey To: gregkh@linuxfoundation.org Cc: florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lucas Jeffrey Subject: [PATCH] staging: vc04_services: preserve bcm2835_audio_write errors Date: Mon, 3 Aug 2026 01:09:28 -0300 Message-ID: <20260803040928.12453-1-luquijeffrey@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When sending audio data in multiple packets, a successful later packet could overwrite an earlier failure in status. This caused the function to report success even if one packet was not queued. Stop sending packets after the first failure to preserve the error. Signed-off-by: Lucas Jeffrey --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c index 3156cb8392f4..5ac23cfa7983 100644 --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c @@ -365,6 +365,9 @@ int bcm2835_audio_write(struct bcm2835_alsa_stream *alsa_stream, status = vchiq_queue_kernel_message(vchiq_instance, instance->service_handle, src, bytes); + if (status) + break; + src += bytes; count -= bytes; } -- 2.43.0