From: Ye Liu <ye.liu@linux.dev>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ye Liu <liuye@kylinos.cn>, David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-mm@kvack.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/3] tools/mm/page_owner_sort: fix --sort, add module filter, improve usage
Date: Mon, 3 Aug 2026 14:20:53 +0800 [thread overview]
Message-ID: <20260803062056.1518070-1-ye.liu@linux.dev> (raw)
From: Ye Liu <liuye@kylinos.cn>
This series improves the page_owner_sort tool with a bug fix, a new
module-name feature, and better usage text.
Patch 1 fixes a long-standing bug where --sort was silently ignored
when used without a short option (-a, -m, -p, etc.). The COMP_NO_FLAG
case fell through to COMP_NUM and overwrote the sort conditions
configured by parse_sort_args().
Patch 2 adds kernel module name support for sort, cull, and filter
operations. Page owner stack traces already contain module names in
the "function+0xNN/0xNN [module]" format produced by %pS, but
page_owner_sort had no way to use them. Records without module frames
are assigned "vmlinux".
# Aggregate page usage per module
./page_owner_sort input.txt output.txt --cull=mod
# Filter to records from xfs module only
./page_owner_sort input.txt output.txt --module xfs
# Sort by module name, then by pid descending
./page_owner_sort input.txt output.txt --sort=mod,-pid
Patch 3 lists all available sort keys with abbreviations and examples
directly in the --sort help section so users no longer need to read
the source to discover valid keys.
Ye Liu (3):
tools/mm/page_owner_sort: fix --sort option being silently ignored
tools/mm/page_owner_sort: add module name sort/cull/filter support
tools/mm/page_owner_sort: show available sort keys in usage text
Documentation/mm/page_owner.rst | 8 +-
tools/mm/page_owner_sort.c | 135 +++++++++++++++++++++++++++-----
2 files changed, 123 insertions(+), 20 deletions(-)
---
v2:
- Patch 2: use regexec() directly in get_module() instead of search_pattern()
to avoid excessive debug spam for the common vmlinux case when debug_on is true
- Patch 2: anchor module regex to stack trace format "+0xNN/0xNN [module]" to
prevent false matches on kernel thread comm names like [khugepaged]
- Patch 2: add '-' to regex character class to support modules with hyphens
(e.g. aa-bb-cc)
- Link:https://lore.kernel.org/all/20260722023726.600200-1-ye.liu@linux.dev/
--
2.25.1
next reply other threads:[~2026-08-03 6:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 6:20 Ye Liu [this message]
2026-08-03 6:20 ` [PATCH v2 1/3] tools/mm/page_owner_sort: fix --sort option being silently ignored Ye Liu
2026-08-03 8:17 ` David Hildenbrand (Arm)
2026-08-03 6:20 ` [PATCH v2 2/3] tools/mm/page_owner_sort: add module name sort/cull/filter support Ye Liu
2026-08-03 8:23 ` David Hildenbrand (Arm)
2026-08-03 6:20 ` [PATCH v2 3/3] tools/mm/page_owner_sort: show available sort keys in usage text Ye Liu
2026-08-03 8:24 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260803062056.1518070-1-ye.liu@linux.dev \
--to=ye.liu@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=david@kernel.org \
--cc=liam@infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuye@kylinos.cn \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox