From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95D32403156 for ; Mon, 3 Aug 2026 13:31:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785763865; cv=none; b=K7EW9i4nJPbiRrEr1W/XTBDFClLTijdQVbv9HTHtJbMq1+zl9DqjN5l1Il2tcliwV0UO14YW4kjHTMUpLoWZyMXPQP4dB0BIYTrLc/Epr3AcW/hAJjstAcxHkChwvC4l7zdHEnt09/8cIuR44DP4E2z+BpRuxrJApxHJgPboRnc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785763865; c=relaxed/simple; bh=s7sVT5nQKfhO1MYQ+cpOMkikgu6fjfHMzycska5FUMk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hSqzzgLg68LJbdaX6zMtUnh5OlPwztGzHIUrYSOOgfReE+llbpf7GU6GBA3C7QuNmMZsP7LY2RJUcInAmiw4mmIpiGtsvPFNs582NfJNb0MkDbg6oIPhO0Gq9vy5sX2FHP/bt0v7hvOyW0fcRsj4gebiJogYDOft5/1D9yaUIjk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eZLcmUBA; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eZLcmUBA" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38e7109321dso1913296a91.3 for ; Mon, 03 Aug 2026 06:31:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785763861; x=1786368661; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=NaH5rfBTvvJEbq+DmDZKDP4NbrrXRvHP/DgwMEdPwTA=; b=eZLcmUBAWfCzhIdeH6fNswwvhJSuwlsTVOX3tAzn+2tvQdbqDH5+SXplD09H6kd2Wg YdOVkLjdSzzqIHV2mlf3d95lLLmfvzqkk5rxjfwiboeF3FlrKtgKo+h3+bPRi1HkkIg0 QJVIFQwGq+NYQh7qvAL5HwCpEOKkli1kosPW5ihIdqFgeHDsltcCIpObfVSmB6XytIHB 0FfaQM9CyHpAaJgW5qIC4iOH4EvjSHiSXAWOF47ZRuw000cJnAIXX1OLt52Jsp8bfL6v /hK6K60QYJb+zSeB6IsytGKCU7CVFKqRYwxxBczU7X0do2m82AWnZ+nsYp0Nottz3Nkm gPbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785763861; x=1786368661; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NaH5rfBTvvJEbq+DmDZKDP4NbrrXRvHP/DgwMEdPwTA=; b=UrLA5Bz3cfQE5wrZlwxfJ2ply7KFtXzzPPjslZZomqI7xbr7AWZ5ak3h9+KwRIJEay Na4gmDO6HwhLwEYCkmblXcfVtw7Jq3gAu0jAi9OGcCVLrbz0X7niVvoHU4J7g3JCjK4C etZ6k23cqlD4R1Mr5j3zYsbotDRc4hWtULxSByfmZa1U1p3aaq7OujHA9CCzLvB6KHbn OZt2ZDZ0Yi3TzXw5DJdm2q88Dwan4WygD8xaASvNiY08uahA37nnTx/Evyh1rda1A6zs H5ih/vhHLWEL3gt/Eqf//UhmDJ0XJnuZ2aL7L5cQAzk5eAi1PkC/tpM87zJfF9Ycc8Jt 3fZQ== X-Forwarded-Encrypted: i=1; AHgh+RoJbe8PNy1t41Xh5lyNUZvJ6bYNj3qiCPiJQkXpWVgT/QXSufJs2q5ZiPfIcNyO2P5J7gZO7Rl5CEeeenU=@vger.kernel.org X-Gm-Message-State: AOJu0YwRk6RXtkpbwbWmcggW/UvQdl5iNHpwCuZ+gH3UNCHywBmQUuxI /nrhRu1XvvV2ALqHp4tX8011hoAQ2XXN6zZ2c61QLuEW2lN6uB4P87k= X-Gm-Gg: AR+sD10OpXeK8iUsrtAKcYIhnlNj/T53iJzgwXm9YsaY19sxQv0eziZn0toV0A/PSPc 6pgzZf6vlsGMI8KSpqlsx7Vv2hYbYtApkX9fCeFWRA428JZq+8/8O1rNizgfU3KYZpt/Pn9f3RO +BghOGbX8kQ992RH4ERPqOmkW1Agsx2i3ABx0t6rILeXDKMH37WzZlAylgyMQVekeNkG+NY4Px7 j4XiL4aLVUHP1nm4N+M7ddYAqV5KVNbsEhWSYTX8c6U826cFepSLA4vkBsCUVKXPldps+zjMaUe iFrMydTwKAMvfy4SQLRgayWCyyUtJz12Lsgyd9yBQBkmdY1e+MV7GOlq5e5OQnGVKVlfOB6C6Kw LJfwtCWjDI3ntz55orzxgzw+cTrz84qP3ahvf/aLJDDCvvKXCzR6aV4J4XXc7Y5CVbrZ3+AM0TG MG67hci8XQe4bKZ5cjwsSE98I7tdl6ZsNeBgMmckMM0nm5HUy+mu0/8kpRAE0suSvdsrzZfS7jM ehTjQrSrOwqopGGDQqLGWlHp/NooN+4OXoeRJQCfSTtoMda2GY5yLSSBZLLQy6rBMjeP52FP7K3 T6IcqrIFQTdwAOpsFkm1OD6Sk5yJblPjsA== X-Received: by 2002:a17:90b:3947:b0:366:10f1:3d91 with SMTP id 98e67ed59e1d1-38fbc3f246fmr8665430a91.1.1785763860528; Mon, 03 Aug 2026 06:31:00 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38fb259000bsm2531459a91.0.2026.08.03.06.30.56 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 03 Aug 2026 06:30:59 -0700 (PDT) From: Myeonghun Pak To: Zhao Qiang Cc: Simon Horman , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Halasa , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Myeonghun Pak , Ijae Kim Subject: [PATCH net v2] net: wan: fsl_ucc_hdlc: release HDLC device on remove Date: Mon, 3 Aug 2026 22:30:48 +0900 Message-ID: <20260803133048.42650-1-mhun512@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ucc_hdlc_probe() registers an HDLC netdev whose private pointer refers to the separately allocated ucc_hdlc_private object. The remove path frees that private object without unregistering or freeing the netdev, leaving a registered device with a dangling private pointer. Unregister and free the HDLC device before releasing its private object. An active device must be closed before detach_hdlc_protocol(), because the detach path resets dev->flags and clears IFF_UP. Otherwise the later unregister_netdevice() skips ndo_stop, leaving NAPI, the UCC and its IRQ active while their backing resources are freed. Close the device inside unregister_hdlc_device() while RTNL is held and the HDLC protocol is still attached. This lets uhdlc_close() disable NAPI, stop the UCC and free the IRQ before the remove path releases the DMA and private resources. Fixes: c19b6d246a35 ("drivers/net: support hdlc function for QE-UCC") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- Changes in v2: - Close an active HDLC device before detaching its protocol so ndo_stop performs the NAPI, UCC and IRQ teardown noted by Simon Horman's review. - Link to v1: https://lore.kernel.org/netdev/20260728171545.49247-1-mhun512@gmail.com/ drivers/net/wan/fsl_ucc_hdlc.c | 3 +++ drivers/net/wan/hdlc.c | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c index 809f21fb93..4c843c94cf 100644 --- a/drivers/net/wan/fsl_ucc_hdlc.c +++ b/drivers/net/wan/fsl_ucc_hdlc.c @@ -1255,6 +1255,8 @@ static void ucc_hdlc_remove(struct platform_device *pdev) { struct ucc_hdlc_private *priv = dev_get_drvdata(&pdev->dev); + unregister_hdlc_device(priv->ndev); + uhdlc_memclean(priv); if (priv->utdm && priv->utdm->si_regs) { @@ -1266,6 +1268,7 @@ static void ucc_hdlc_remove(struct platform_device *pdev) iounmap(priv->utdm->siram); priv->utdm->siram = NULL; } + free_netdev(priv->ndev); kfree(priv); dev_info(&pdev->dev, "UCC based hdlc module removed\n"); diff --git a/drivers/net/wan/hdlc.c b/drivers/net/wan/hdlc.c index cbed10b1d8..a38f90d300 100644 --- a/drivers/net/wan/hdlc.c +++ b/drivers/net/wan/hdlc.c @@ -263,6 +263,7 @@ EXPORT_SYMBOL(alloc_hdlcdev); void unregister_hdlc_device(struct net_device *dev) { rtnl_lock(); + dev_close(dev); detach_hdlc_protocol(dev); unregister_netdevice(dev); rtnl_unlock(); -- 2.47.1