From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C5EC2DF13E for ; Mon, 3 Aug 2026 13:44:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785764642; cv=none; b=RC62TYbWFZnCM7jWqg+BRrn9QPayfkGhwhqsHU3kiZL+fWWL1ZnlNRVas5Qdl7K6gwRuY+3AzGDHSLUbP2e4TMl/PG7wSffRntjFAJHmZjQ/1jARkfWCPbe31zkG4rBz1gU/Bui3mIZuVSKWojH0DrawvunFRu5fWgzOQBy2v38= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785764642; c=relaxed/simple; bh=a4fUsm0sri2CJp9Xa6+EfCy3v837PLIvJct/CxDUWxw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dH7eECKfKGFsp9GU2NPtF/iq4eFA3u9HTtUK06X19SBfEiGCgGpd/HTZECdZIonhZEr0AKpcUxF+te+dUJnNNRBCb1dEHVlL5EXYpzKeyZgHYmMbJTkdYdNnu57+TqxlRzqsDqWSFxjQ9TS0nC9VWzlOlVFjS+QFNT8BEhlp3Sc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G4iXkmBJ; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G4iXkmBJ" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-47de0093c42so2358467f8f.3 for ; Mon, 03 Aug 2026 06:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785764639; x=1786369439; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5Ovn4XB3GgCDHVcufiauy/1mVBNPpRS6FI6cibDiq4A=; b=G4iXkmBJ/ugmNIVrZJsuk7Cv04P75n2u36vrGAfeyBM/86kqAHOe5eohdjOrjpBkLo rSSIBZ/0DfgR1ItnU6yUuD/YJUigBzVgbqXNyhTOJH0NndtjkQpbnAQv3/MNjLiDiybZ YYy+fwSohYmZEZxXJ+MjDGC/LSli5lrmH0tliTFMXj0NyBJe0NYutl0s1ViniV2jh2al XJbOpiiOE+V0a+OXRaa/nfhbmzvie1loeH9g4brzwHundjBwBI8NdYGlyLZ4cxpq+eEp MPFouC/ZZk6gu3kxOxipcq1RPKbr7xatlTqXHEht+bJydBvG6eFpi3k7q8Pi+VppG0/+ FeVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785764639; x=1786369439; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=5Ovn4XB3GgCDHVcufiauy/1mVBNPpRS6FI6cibDiq4A=; b=TBA6X2Iq6C1T5/Y5IzdvUP6JU+KH/uxXBiFJif30YTujZzrT0Q5K1LfzO3VLy8nY/w aZKnUg9vT/eg50CQd+GAl6s1vvq7bK4gqv52lkAZn9nMbHkwciwHQHLUZ1+vdAEhMmV4 hEqvki5ohO5o7CZ/n8O6O36YLs3bH96KwaaFdtR7+B3Nxrqx0Xc3fEH1F1p/oe9O+8F5 Jg0EDta3t3gcj36LoYnL4HyHM6+hwvhM508x2JdX61RGh37Mwbzh0sXz1mQ//j3occsg YCMRL16Ix7yqaHiYzQ3HiJYqo53ECI9SJCTzQJVHWkoMOsanGh6nZZd2ldY9aBPTYZDz 40OA== X-Forwarded-Encrypted: i=1; AHgh+Roo4Yxej8Kc1+0RC3Ik7LE7lKBpTp+X1v3KTTsKYTfEL5ET1Q1wYg8QCJSYOq/e3HbgWcTqjYNWElS9nRg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywa0lCeeVlJ2vjAp6ESeEJ+Mts9Y2rVRE/YXoijr9+a8leoy6Eu 4n660yFgCzxtcvr3VSZQZKn8+f8YpdBAS6DKWRBy+IYqhuH/ec5DhWwX X-Gm-Gg: AR+sD128hmmGUfGdi00ablQyUA1zmlW2zED7aOiRashWbtRiF9GhDgY8IkfHSX6qDLG Ms9Hr+qqfBYcpTEHcVgZqrNCPLU5njcpkNoxOF+5LrpotXZtsa7fMpzcdpJcvgqmYHIyyqSFivE UyLORh4oGuTgAQMU2eSE1al3sRW+c7oBgiltDXbPIDRv1FunDlMoLskyMAmKo+YADnMwvNyZFvb kgvtvQwQrl/CKX1TdWEh+GfBGPT0ZNr3U571vAlDXcpj8nMaPvMh9tvMc+2AUZKaLH/etN0yvWH yX0M1VxHVfRtUcrms2D4YddQvIQIiocUXFxQk6FhIkg4Gx3IJHq2h0yip7G8QjFiQ6CdYB9tQP9 sLvnjlLkQskgFBGgesrx2tO/+fuZMkwuWrIWto7nFh4q0RCCb/6EmjLiQ13aFnOmZjbo8eSAWP0 mF2n8KAjvWhm/gr47xJb0nGPoDuRqUfFoz46vazSMtxnSpcvT5L2JTudLxp69y8yJA6989V9p2x TcpJt0w4Q== X-Received: by 2002:a05:6000:3102:b0:47f:5a97:2a63 with SMTP id ffacd0b85a97d-47fd729fce9mr28593445f8f.9.1785764638595; Mon, 03 Aug 2026 06:43:58 -0700 (PDT) Received: from fedora ([154.182.126.98]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd4068fb7sm34328908f8f.0.2026.08.03.06.43.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 06:43:58 -0700 (PDT) From: Abdelnasser Hussein To: jic23@kernel.org Cc: nuno.sa@analog.com, Michael.Hennerich@analog.com, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Abdelnasser Hussein , Dan Carpenter Subject: [PATCH v3 1/2] staging: greybus: audio_codec: fix sscanf return value check Date: Mon, 3 Aug 2026 16:43:43 +0300 Message-ID: <20260803134346.6733-2-abdelnasserhussein11@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260803134346.6733-1-abdelnasserhussein11@gmail.com> References: <20260803134346.6733-1-abdelnasserhussein11@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Smatch static checker warns: drivers/staging/greybus/audio_codec.c:335 gbaudio_module_update() warn: sscanf doesn't return error codes The sscanf() function returns the number of successfully matched input items, not a negative error code. Compare the return value directly with the expected number of conversions (3) instead of storing it in 'ret' and returning it as an error code, which leads to returning a positive value on failure. Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/YoOLnDkHgVltyXK7@kili/ Signed-off-by: Abdelnasser Hussein --- Changes in v3: - Split from the previous v2 patch into a separate patch. - Updated tags to properly credit Dan Carpenter for the smatch warning. drivers/staging/greybus/audio_codec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index 720aa752e17e..295222ec0f1a 100644 --- a/drivers/staging/greybus/audio_codec.c +++ b/drivers/staging/greybus/audio_codec.c @@ -311,8 +311,7 @@ int gbaudio_module_update(struct gbaudio_codec_info *codec, } /* parse dai_id from AIF widget's stream_name */ - ret = sscanf(w->sname, "%s %d %s", intf_name, &dai_id, dir); - if (ret < 3) { + if (sscanf(w->sname, "%s %d %s", intf_name, &dai_id, dir) != 3) { dev_err(codec->dev, "Error while parsing dai_id for %s\n", w->name); return -EINVAL; } -- 2.54.0