Re: [PATCH net-next v15 00/10] net: phy_port: SFP modules representation and phy_port listing

[Jakub Kicinski <kuba@kernel.org>]

On Sat,  1 Aug 2026 09:43:21 +0200 Maxime Chevallier wrote:
> Here's V15 for the phy_port improved SFP support and netlink interface.

Breaks YNL build:

  In file included from ethtool-user.c:10:
  ethtool-user.h:8523:42: error: field 'obj' has incomplete type
   8523 |         struct ethtool_port_get_rsp_dump obj __attribute__((aligned(8)));
        |                                          ^~~
  ethtool-user.c: In function 'ethtool_port_get_dump':
  ethtool-user.c:8833:18: error: 'ethtool_port_get_rsp_dump_parse' undeclared
        (first use in this function); did you mean 'ethtool_port_get_rsp_parse'?
  ethtool-user.c:8847:19: error: returning 'void *' from a function with return
        type 'int' makes integer from pointer without a cast
  ethtool-user.c:8851:16: error: returning 'void *' from a function with return
        type 'int' makes integer from pointer without a cast
  make[1]: *** [Makefile:52: ethtool-user.o] Error 1
  make: *** [Makefile:57: ../generated/protos.a] Error 2

You need to specify the reply for dump, I didn't check if it matches do
but if it does:

--- a/Documentation/netlink/specs/ethtool.yaml
+++ b/Documentation/netlink/specs/ethtool.yaml
@@ -2896,12 +2896,12 @@ c-version-name: ethtool-genl-version
 
       attribute-set: port
 
-      do: &port-get-op
+      do:
         request:
           attributes:
             - header
             - id
-        reply:
+        reply: &port-get-op-reply
           attributes:
             - header
             - id
@@ -2913,6 +2913,7 @@ c-version-name: ethtool-genl-version
         request:
           attributes:
             - header
+        reply: *port-get-op-reply
 
 mcast-groups:
   list: