From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F22E4322F9 for ; Mon, 3 Aug 2026 14:19:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785766776; cv=none; b=bq6T5D/ROy/AUwrnESLIu4BDlRj7fJsHOYFcbxWPNKB6YtSTPrsC8ZVWf24bPMMGyHbEuD641/988rlBV/YWwGds+JEnzFgUsWJHI9mv2rgf4yanqmKRcXsAooBju5t+EYA85pmOwUHFYFGYYOyKP5OOLRPPSGBIrwv7hzPR3pI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785766776; c=relaxed/simple; bh=NtVxcaGT3mUFAjsPDRIqpZDl9swMqfFiGNB20NADrKg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VaLjzs9N5X6PJ+KPy0vP6QGEZTwAMr6UpXuQa3QDpP5zdHt4hKMx+Cnbi0H3ZEDbRfMyKy2oC2SsEHnDvFbME2Bw6jkiZqqRuq9+7FlSmrOUiY//LSni7an7Uqx6uN272zMzw+mZNWvDCW5pOGDjvKlTpg1KwXbD8I2gGaVwX7A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aIGqse64; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aIGqse64" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-38dd55ad76cso3119035a91.1 for ; Mon, 03 Aug 2026 07:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785766775; x=1786371575; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3LxMtUsp4NwM/aEkSRpWjNm7OpZObqtf98j/rMMWK14=; b=aIGqse64Qju3m3bzuMskh3sWDCGQjGSGkHbi9EIP6bQMcUaYZc8Las5Tnk7IzX1YB4 a0+f1ouc4PX0dEij6J9IZqQicP4m9RfakIrrWbXhpEgWFDhvXLz+Cf/Hor3VoXanIrSo gBRpp2SttqvD0DQykutoDyeqDAG698cL0HegxMXJYO8O5F89MeAWrV4ITeUWfyix33Vp 1H95mFXryqQkgjhk+BPzCUxEubkNFgfCFvAcXNCG4557azkgHQG/f6TjV64yebgJ93mk y35hAZnr6uJU+4n433rknHqZ8dr78auBdams6pafJVf8wJFEwaGIVW78FshqFnPOP9L+ GSTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785766775; x=1786371575; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=3LxMtUsp4NwM/aEkSRpWjNm7OpZObqtf98j/rMMWK14=; b=K7C+9xUNebHPq2DkKtGHJ12csBiwQmUutCHXqm+w+7YYU4pC0dCHfgcJgwSeqrf426 +tejiVeAc4Iq8sAh6rxmR8aYs/BdShirKnlIk6xR7qfRlco/08tsylrDfkdvV7B/fKD8 6aWVCUaJb7CR89HJo4RIQ830STeiy8xmohpoakO06VPD/Ma8cpUcX4BK+Zz3JbFcQFFt JgtqzzIn8TdqYScQJyUVkY+sSB6uOo5yRienkmLahhCive4F0YqdiNE2XUDOHw3lCNzJ DdwXvcveUsfM7qrwNyp0VOsH7Xgj3veP+P29eL/K7/yVCvvSZ13vseyj5jcRZbw76ZSv MoaQ== X-Forwarded-Encrypted: i=1; AHgh+RpwSPSbepyvLDevd6btPetfO3aoVZNcnR+6K68meXoyJtrav4rOlbAcNWgz2s8jHboIWP8TFKOCUVah+aA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6pa8xLNeAmh+orTAf5Q0QcFvbmD+sqLgDhkt03o4gCwxI7VBt YUn+BywmMZpaTuwoLgQGxMViGHbeG4rBA4I00bIObZoxiMgsJZWtaV6H X-Gm-Gg: AR+sD13MktWoPtFYt931zf9ehCElf/iSvkA887JmX1zorAVsSKrUVgZYbwrqFihfGcw vHsN7BXL5sP+h7hD5IyMFnmFAhe+yqWt471L1LJRquT32/NUsz8SLc513okOb1+IH1oVHn03VbI lYR0Hac30fYJqMNCYQKL27N+/Ubq31qfdP9VBlmGu1cJiMpFX75nJaZv6ZhgRffX2D8eZft4A9o 8cuDTwlYOzhrf/vcC6cGaxqVjPGRjEpwkZnhC258aQPEsQ4udUTI+fqeniRbbC21BGnFPLeiQWZ Pb/DsxHr2xJRbI/LGoKxKYEGGHWjZfOM3dnrEayoC8qZlJip1G0PUmNg0Mn5AnlFqFgcJd0L7m4 Tw49s2Q6m3ObPExDaR0gbNbu4CCeS4FgL7bC9FATiZLiR6xz5hlMKlPWJQYPxiLSSU9SFdHH9q9 29G8PuiFZ8auI76dE4xdE+6T/yVAXcvDkOPD7VzhJkMqU8IfcBvCVTQ629XznwX82FeeRwJTFt7 IUz0Jo59tJTW5yPnNs4 X-Received: by 2002:a17:90b:1650:b0:38e:c232:9d2c with SMTP id 98e67ed59e1d1-38fbc9f3ce3mr7228127a91.2.1785766774810; Mon, 03 Aug 2026 07:19:34 -0700 (PDT) Received: from buffalo-ssd (M014013071096.v4.enabler.ne.jp. [14.13.71.96]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38fb30dff2esm4078462a91.13.2026.08.03.07.19.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 07:19:34 -0700 (PDT) From: Akari Tsuyukusa To: Michael Turquette , Stephen Boyd , Brian Masney , Matthias Brugger , AngeloGioacchino Del Regno , Yassine Oudjana , Richard Cochran Cc: Laura Nao , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Chen-Yu Tsai , Akari Tsuyukusa , Bartosz Golaszewski , Danilo Krummrich , Bjorn Helgaas , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Nicolas Frattaroli , Takashi Sakamoto , Haotian Zhang , Kees Cook , Miles Chen , Daniel Golle , Sam Shih , linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support), netdev@vger.kernel.org (open list:PTP HARDWARE CLOCK SUPPORT:Keyword:(?:\b|_)ptp(?:\b|_)), stable@vger.kernel.org Subject: [PATCH 28/32] clk: mediatek: mt8188-apmixedsys: Switch to common probe/remove helpers Date: Mon, 3 Aug 2026 23:16:55 +0900 Message-ID: <20260803141659.559129-29-akkun11.open@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260803141659.559129-1-akkun11.open@gmail.com> References: <20260803141659.559129-1-akkun11.open@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The MT8188 apmixedsys driver can use the MediaTek clock framework common initialization sequence. Reduce boilerplate code by creating struct mtk_clk_desc and using the mtk_clk_simple_probe/remove helpers. Signed-off-by: Akari Tsuyukusa --- drivers/clk/mediatek/clk-mt8188-apmixedsys.c | 60 ++++---------------- 1 file changed, 10 insertions(+), 50 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt8188-apmixedsys.c b/drivers/clk/mediatek/clk-mt8188-apmixedsys.c index 48a2f61d4b77..3937d93cac34 100644 --- a/drivers/clk/mediatek/clk-mt8188-apmixedsys.c +++ b/drivers/clk/mediatek/clk-mt8188-apmixedsys.c @@ -89,62 +89,22 @@ static const struct mtk_pll_data plls[] = { 0, 0, 22, 0x0344, 24, 0, 0, 0, 0x0344, 0, 0, 0, 9), }; +static const struct mtk_clk_desc apmixed_desc = { + .plls = plls, + .num_plls = ARRAY_SIZE(plls), + .clks = apmixed_clks, + .num_clks = ARRAY_SIZE(apmixed_clks), +}; + static const struct of_device_id of_match_clk_mt8188_apmixed[] = { - { .compatible = "mediatek,mt8188-apmixedsys" }, + { .compatible = "mediatek,mt8188-apmixedsys", .data = &apmixed_desc }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, of_match_clk_mt8188_apmixed); -static int clk_mt8188_apmixed_probe(struct platform_device *pdev) -{ - struct clk_hw_onecell_data *clk_data; - struct device_node *node = pdev->dev.of_node; - int r; - - clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK); - if (!clk_data) - return -ENOMEM; - - r = mtk_clk_register_plls(&pdev->dev, plls, ARRAY_SIZE(plls), clk_data); - if (r) - goto free_apmixed_data; - - r = mtk_clk_register_gates(&pdev->dev, node, apmixed_clks, - ARRAY_SIZE(apmixed_clks), clk_data); - if (r) - goto unregister_plls; - - r = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, clk_data); - if (r) - goto unregister_gates; - - platform_set_drvdata(pdev, clk_data); - - return 0; - -unregister_gates: - mtk_clk_unregister_gates(apmixed_clks, ARRAY_SIZE(apmixed_clks), clk_data); -unregister_plls: - mtk_clk_unregister_plls(plls, ARRAY_SIZE(plls), clk_data); -free_apmixed_data: - mtk_free_clk_data(clk_data); - return r; -} - -static void clk_mt8188_apmixed_remove(struct platform_device *pdev) -{ - struct device_node *node = pdev->dev.of_node; - struct clk_hw_onecell_data *clk_data = platform_get_drvdata(pdev); - - of_clk_del_provider(node); - mtk_clk_unregister_gates(apmixed_clks, ARRAY_SIZE(apmixed_clks), clk_data); - mtk_clk_unregister_plls(plls, ARRAY_SIZE(plls), clk_data); - mtk_free_clk_data(clk_data); -} - static struct platform_driver clk_mt8188_apmixed_drv = { - .probe = clk_mt8188_apmixed_probe, - .remove = clk_mt8188_apmixed_remove, + .probe = mtk_clk_simple_probe, + .remove = mtk_clk_simple_remove, .driver = { .name = "clk-mt8188-apmixed", .of_match_table = of_match_clk_mt8188_apmixed, -- 2.55.0