From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E17FE41DDF8 for ; Mon, 3 Aug 2026 14:31:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785767494; cv=none; b=eGgZ7t8U4swMFeGvk9YvecJ+AYluCUdLVsraNtJBo4Jka0vNCm6fGB2OYKG1vwmg7ZKqUZFhbnmSU9aqalkx1LaBUIky9oiR89jS1LmQjtWUfeKovkJria9Xrc9T2Ahr8c/s51jJRpqwvAp0DEil+uZg2tSN2j/wMl1vXAKj6r4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785767494; c=relaxed/simple; bh=bxA8J6/qIIfaCWTOgjW8WTYcWhqAJeYz4cR1gJwp01U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Bk0B2Dbi/FhyO2Sx843iJrW9oX7pgqDfmbXKKv000ZgJ9fiW0cZuYCr9TUCnCggmI/UUtZKGpPsvWjkIc0Z4oFowdRSvYmb1qY7WwbRaazhg0nwrSmPPazPUPJdWZEB066ZxRnjfbAtjYaay/MAphYJquWZwY2HgBUDmExGorwQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n75G9mHi; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n75G9mHi" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4954afac04bso25861225e9.0 for ; Mon, 03 Aug 2026 07:31:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785767491; x=1786372291; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aP3AzbHc5YQoHN80VU5i3zw1DBkXU+MO/jUixWC22QY=; b=n75G9mHi6Hk0eaxOlM+uosEL+Ab/+FyB4PZEH6zRgOTxBuKVoDALRfcpRj4v4BVSGO Rw+xjlNaUYmz0WUmH31ybt27W4BNEbrt62NB9QBZNkihfx/cmrlqzGFe9nY/H77o3YJu QoBwjiP2y3MI8vUVJT8cJZ1M1XqbaVSXqNs99TT0wLb6pMthyKctXLEN78IWLhZHFtUs gWmgrlHe1C9TgcvIJmk1my9csBypZluiiD9i7MaAvuKMYvJUrGajyQgPzc+klvLY+RCq npJs2J8kYeXM2kte4lqHaHKJwdElVkMeGzzLzK2WEASY2IMHUbbWJ89y8ScRg+YLk4wX 7SPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785767491; x=1786372291; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=aP3AzbHc5YQoHN80VU5i3zw1DBkXU+MO/jUixWC22QY=; b=qOGX4f0AiQaxNbYFlRj2cPSbyaDZA7dE+3jCknJkXrAMHYr7K1ADK6XqzTIixTM81g ve4pkAuf2qKsowDQT0+jQ9GhO0X96UNc3XJIv5ZLdcNdl/YguPOsoZrd5/8joOw7L9nC oDLsJrMTx+W3CvSmZSI30IDp0GzhmqmBlRbaqPeuWwsIlIjxf/lhzUDfyNYApormJBcl YfJ/dWMYGpKCe1iYtSX5d4ZcPZlDNxJSTQ0zqBFS8llTrTtI64iVnB7vGKP/yGZJs0g5 7xIHYMfocB3bdrOJPgLvrmRpah8oIPHoBa+Ky9SEUasHwqOOLCnec97GE/sefj0KSH88 5a3w== X-Forwarded-Encrypted: i=1; AHgh+RpOvFzVQ328SsW21MlTdS+ym5OZUHruqDxRZKedsDGTnZ4x/+mTjZb3q8CgAr2Mf/v8FomNgvB9SykymuA=@vger.kernel.org X-Gm-Message-State: AOJu0YyDpB9LwNyao4C2InFvsfhzUP/LY1mtfoxbfgH4L2EjDk7Wz2V0 60kdqg48k9pHw2C7N1IXlRfap2dmwOK5/fWxNQqDZA+ltRbQV2F3MSLp X-Gm-Gg: AR+sD11ZkTV5FGwKoB3LCXyJWrVTmoTJPf5qIna6m0UU8ibI6SH8HGv3Fa9FIhaFZ4q puAQQhdELbIi+7ekd8ZTrPDRkEyUhKMt/GP0H1Cb0/3W5hp6VNZEEiSlZSkznfre63YoYJwSKjY JbosbyHi7IQv8g8CM0m3xkpEFpBdIyLUdiBlv/x6xO3QWGhusQcX5dBiOjnBKTZWPTEKxJraFWB sd3uky3dHnU9YTanjaF9+1vlWFFlvv4kW6xw29rNHhh9l0IDTvgsqgNYmmzow3IMrA+5u7kS5Mx 75nwp2u4UpL+gjMd6eIQgLz3Va3VXvHXsqd5kKQ8FlEeacsCAQ138XJiIarfg5wXNPXcZkKL1yG OOH9GqDMJQUxMcPWXTC9rm3SgMXrJ4mEwnz81u5gPoucxA9Jql8QIIbYEjHekQHLpg3069ANn4S 5tHUEPC6JqM8Ks4tFq1nbjFJtEU92kWXC9ZTOG9h3nscV5XRZecqsfkWQi1TZYGS4sZYatcqIXC HqINCJZ2K4emrjMgvj4wu3pth9at22TBkThjVHB0w== X-Received: by 2002:a05:600c:5248:b0:495:78af:78e5 with SMTP id 5b1f17b1804b1-4980c66c80bmr200642125e9.1.1785767490982; Mon, 03 Aug 2026 07:31:30 -0700 (PDT) Received: from fedora ([202.47.63.86]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b98284sm236575295e9.12.2026.08.03.07.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 07:31:30 -0700 (PDT) From: Muhammad Bilal To: platform-driver-x86@vger.kernel.org Cc: jorge.lopez2@hp.com, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, linux@weissschuh.net, linux-kernel@vger.kernel.org, meatuni001@gmail.com, stable@vger.kernel.org Subject: [PATCH 13/13] platform/x86: hp-bioscfg: advance elem past consumed array elements in passwdobj-attributes Date: Mon, 3 Aug 2026 19:30:36 +0500 Message-ID: <20260803143037.93105-14-meatuni001@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260803143037.93105-1-meatuni001@gmail.com> References: <20260803143037.93105-1-meatuni001@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Same defect as the companion fix to enum-attributes.c in this series, present here in both the PREREQUISITES and PSWD_ENCODINGS cases: each consumes "size" consecutive ACPI package elements, but the outer loop only advances "elem" by one per iteration, causing the next iteration to misread a leftover entry as the next property and abort the parse with -EIO on the resulting type mismatch. Fix by advancing "elem" by (size - 1) after each of the two loops. Fixes: 8646a3b5ee3a ("platform/x86: hp-bioscfg: passwdobj-attributes") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal --- drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c index 6bd56d3f5bd0..9b989ef756ea 100644 --- a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c +++ b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c @@ -321,6 +321,8 @@ static int hp_populate_password_elements_from_package(union acpi_object *passwor str_value = NULL; } + if (size) + elem += size - 1; break; case SECURITY_LEVEL: password_data->common.security_level = int_value; @@ -367,6 +369,8 @@ static int hp_populate_password_elements_from_package(union acpi_object *passwor str_value = NULL; } + if (size) + elem += size - 1; break; case PSWD_IS_SET: password_data->is_enabled = int_value; -- 2.55.0