From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D01440F75E for ; Mon, 3 Aug 2026 14:31:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785767476; cv=none; b=KO6aEbmbfXUe/GOIIG2ldQKzqoz+ZrOiNT0tYUI7P4PUsZuwUlk1DkxQ7IdNBDKqRNyXhO45b1ZfWPbBZWkbkBv5fHVe9KV1to5aFqMMLgA9uq+AnJmL1mBy7bhZEpIpogOgU2tGxGZ5TTxUwnV+cSGoZPfM84BOnYFan2YBfx4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785767476; c=relaxed/simple; bh=ZqVUWs3x1BgozxV3FrsSk7Lzh34dxSnwsmeX8ZrIYuQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d2K/k/NiCBh4XFItvaJWH9+YGZX0g52GevEIQaU5cr+48Z4dQsXCwVq+MoJLUUaCVhrIl96psGWL2DHkH+UGcKyTwYv5/7+XOAwKUtQ4a21w+OAcZVeVHnla9WGbTCNn9jtDTwO1jwKyKCks9dGvVlMBcoGF52e3FRoOnGewrfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=crzuaqhD; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="crzuaqhD" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4954df200ddso14309755e9.0 for ; Mon, 03 Aug 2026 07:31:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785767472; x=1786372272; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aGNNvpeBB2xFe8o+eAG+ITw+sBusoz0y2d8gJ/h4GCc=; b=crzuaqhD32tZylx5ndKwb6IvjJedmiZyrqlIP1NEQd0Q2lhDGUq34CcdY0i+LD7TdO HHlZ9I98cXfpHCGcVy0YqK13gDli1Hl1ObqaMxcztzMAVS2LRBQM5uskuNKJHRLp8j3W xCpovROFnXhsW172TcDfbR2shveaZc+U91lRkAtOO4I1JTTvJVC9oEA8ZHKdXFxo+JkI 4cezzWvEfb/fq69sa09DQaQ6vSvL9rkYZgk9GUNvUHL1GkTiGzruofIqlHKhgnaaH+qW sd7sZCzVk/KbWWf4YQu/cFcTz6Bl1rO2bo1YuyoMUawUUC08AH3IZaAJ8W0YCdxTngAn LJLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785767472; x=1786372272; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=aGNNvpeBB2xFe8o+eAG+ITw+sBusoz0y2d8gJ/h4GCc=; b=TUdD8iVjHBnLZ+cOIZjH2JPiGALGWLafB//ee2mCqts4Z2C2I+r92od9fMK3SkXPza 1MzSwjwSNAIKnqf650eX9qUbH807s7UjudWSom1Hj6F7EejZAl7a5RQmduvTnpq4Blrb Ywqa2c9gW8Y5hVD0cU2xaF3eZXn4ypMqwMg6WyECwDn90rz3HPJg3LIdXvvJaG+l2hvX 3ZEiQBpKz/dg3NTaxSTzk+vp+Vfr1bG2MECl/PjzPcLghpuhwH4YR4/tc80E5ZHa36Cm 6ZAs/fSmEF3Ku3EAohge/uiv9/K8xjpj1YrUQ31zbj6GTY+1d1DWMdzoUPRxXO5LMsQc /0gA== X-Forwarded-Encrypted: i=1; AHgh+RrXZACUBVKAsjYut6QFA0yeH3DCRFd0b9ggdu+N0/njvng6Ukbz0PN3xJMoC+m69Q5KiudnmEWr6kF1Zn0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy52InEhre/RmGkItnQVRLTnyVI1t/9meo0QocQTmhfRYDoA6LU EVJVMgxt7X328KCb4CD0dcGzbYOj++H6y7tzZcU7gTelfYl2OC8hueUR X-Gm-Gg: AR+sD12DiM5jytKH/AdrhVDdejyCyDxhLjMZuj4sLovP3z5vrMFOo4rWCNo6enIMYpC Bs2o2tjJq8GPm2BNWiqSvxlJlGfgsGKM/KH7Dm2hGNe2Xar3WG9GMmhuD9dW1CGLtXmEqO7SJeA snjzgvcqRvxv6kkXfyKKyYF5EazE3zMYe0Lugu/cCFxBlHwSfmTe9aCXkkUNyHKkHbdP6mOjYKw /hrJB0ZCJLJxUTmhvqOnnBzKclVqKCyl5+alQeHQilLPViD5cI0D7G6R+ADLqHVWniP2G7Jcnvw L1UL8ISvewyYRU3d4BoAPdkGxVndZjJxxRObp4qtSTfUKSCU4q9p0bR+cxGE0DNl3upOsKKWjot Y0yTb9QFHdB712AUFarxy8qxRMm3MTXC/BcGkDSJsPvSN7N4Qo9hVCMQKAK5mOpGhhenYG4NIIw mvtNf0kElsozoivMxZiyoWVn0+hfxRLE5AMJaCLXDGf0qI81QjGFxFaH48edDQv1pG0WztMl4zZ wTtinPVasWKcZnyllAlyGkBLNzVIZSx0Gu6K50qbw== X-Received: by 2002:a05:600c:a47:b0:498:1371:6612 with SMTP id 5b1f17b1804b1-49813716987mr143983415e9.6.1785767472196; Mon, 03 Aug 2026 07:31:12 -0700 (PDT) Received: from fedora ([202.47.63.86]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b98284sm236575295e9.12.2026.08.03.07.31.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 07:31:11 -0700 (PDT) From: Muhammad Bilal To: platform-driver-x86@vger.kernel.org Cc: jorge.lopez2@hp.com, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, linux@weissschuh.net, linux-kernel@vger.kernel.org, meatuni001@gmail.com, stable@vger.kernel.org Subject: [PATCH 08/13] platform/x86: hp-bioscfg: fix ORD_LIST_ELEMENTS never being parsed Date: Mon, 3 Aug 2026 19:30:31 +0500 Message-ID: <20260803143037.93105-9-meatuni001@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260803143037.93105-1-meatuni001@gmail.com> References: <20260803143037.93105-1-meatuni001@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The ACPI_TYPE_STRING case explicitly skips the string conversion for elem == ORD_LIST_ELEMENTS: if (elem != PREREQUISITES && elem != ORD_LIST_ELEMENTS) { ret = hp_convert_hexstr_to_str(..., &str_value, &value_len); if (ret) continue; } so by the time the ORD_LIST_ELEMENTS case in the eloc switch runs, str_value is NULL (it was freed and reset to NULL at the end of the previous iteration). That case then does: ret = hp_convert_hexstr_to_str(str_value, value_len, &tmpstr, &tmp_len); hp_convert_hexstr_to_str() rejects a NULL input with -EINVAL, which sends this function to exit_list, and exit_list unconditionally returns 0. The net effect is that any ordered-list attribute with elements present silently ends up with an empty elements list, with no error surfaced anywhere. Fix by converting the current element directly, order_obj[elem], the same way the PREREQUISITES case already handles its own array elements, instead of reusing the unrelated str_value/value_len left over from earlier processing. Fixes: 4b2672ec71a3 ("platform/x86: hp-bioscfg: order-list-attributes") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal --- drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c index f09489a085c8..704c69c18146 100644 --- a/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c +++ b/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c @@ -261,7 +261,9 @@ static int hp_populate_ordered_list_elements_from_package(union acpi_object *ord * Ordered list data is stored in hex and comma separated format * Convert the data and split it to show each element */ - ret = hp_convert_hexstr_to_str(str_value, value_len, &tmpstr, &tmp_len); + ret = hp_convert_hexstr_to_str(order_obj[elem].string.pointer, + order_obj[elem].string.length, + &tmpstr, &tmp_len); if (ret) goto exit_list; -- 2.55.0