From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC2FE1F4181 for ; Mon, 3 Aug 2026 22:13:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785795231; cv=none; b=B2n8xNRJ4yziTR8I3yWPdg+6BdkdvV4+cKn78wxKcoCgDdelYsAJPjPgBF65iXNy0flNWat1sU1Aw4mnch2GIj/GxrUAqcXG4hXug8j8XyUsIOaQeFmqzsvk3c+e5bNg159J+hEXFF+NuV+2+rZplYVUytabW+n21tlhRxsxr10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785795231; c=relaxed/simple; bh=cmRi7qupxsGmpasRNeQIN0g23ByHP/yPc/jydAD2fiA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SAOVz0cWUjisKxt8EVMInhuLshyGq0Wv3jcqE3TfkbiufO6BC6ShCT+SP7kvjhsW0ufP5getkofaj5Qwb4Qizye9U/9roFMNREc2vb5p35PF4iAiZ3IKiicWUGW9eJ7h06MiwgaoRPkLlEk/H9mDeizzze6LO/etTaXhvIg0H2w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iYeitjnD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=feuslKw6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iYeitjnD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="feuslKw6" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 673JlBRX1599974 for ; Mon, 3 Aug 2026 22:13:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ig95ApWFX9FrE4bSEK82oovW8IQGcBZFRFG4rkok8Cw=; b=iYeitjnDFCqO5O64 qaNqhGDOeOq4NMgkqbc+n2F4iepZtrMVWI1u6u+AwN05fK0ZZxZ2xRd4ZQ0L58l8 3dit4SFNnFjLMZugpvta/2QbNMHUfWK/QcdwEyOLpHtIa+nFWZdHmHWDfwIFubvH YptyBgPgf1fbyhtqpP24t8cJKMqD/edrB82H7weraYhyzqr2Za8n+XzS39tLrANC Z81Ttza/7zwsXfrxgCKjJsKS7rww2mL9hXyKAXimjo6Gya7PR1wRb8I/bvFROZiU lYeGMtQnKHTiDZuy6NiFuq0CK+agHpPssTUIa1VdfKDeDV47GxJ9JumL6XeyxZdH jLvDmw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ftnvnky1y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 03 Aug 2026 22:13:48 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-caf5fa127d4so7150657a12.0 for ; Mon, 03 Aug 2026 15:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785795227; x=1786400027; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=ig95ApWFX9FrE4bSEK82oovW8IQGcBZFRFG4rkok8Cw=; b=feuslKw6DAJ1QzpRmIxLn6UVUicCkD1AIVsz0lqAlYXmW2YjJNkfwcaGQ1ViguK8zJ 6o1qpYdJZ+3sjcF7aWbDqv4fliAAtpwLT57lqSOI6xqupFD/dCNQri2midVbpHBAMomX JOXgfOobwvTUjV6kcB9yTCnL6EnCo0cXX64NIM97PBZBCnTSRZdkg8BWYSrPaFE1Vsr7 v8MKdWKpUb51YABxdL9esCHKRVHWkIOyt4hbmDZrEWf2DAwXb/i7rhXREPaSZRuehB0G +gwQ+F28rws/65rHYchUkdpJXI6Yz4iGL2bSAY8w2Z4ybydK7eEp2Hf0q+jjkokZ+pNl LxuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785795227; x=1786400027; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ig95ApWFX9FrE4bSEK82oovW8IQGcBZFRFG4rkok8Cw=; b=DaWUnYqzN3R7xIErzCJH5xu72bzscPn7fj1VQxWkUgsOWFsRfIEz1TX4DwWl7WYlY5 Ur1ggRGBgVbvFaZjW5oBLNNORLN+7j4c0Ik02ql7cXPzh/P1AeemltSIrWY2woUGC5g6 /yhtit15gcRPLjjnjW4LE5iRbnvBdVdMdGLc8BDStN3jzjh9DH/juxI7A0EdwHo12h4w p/EkM2sNNlYpwD7CC94ZYkPfi/+TMA4gNSAt3aCnHbElL2cs1+B7N5fMhSMATm0Beb2A TbKnCdoKH188ix5mIJJOb4pYojKy6p1JR/e9TuPcKFFEZbdCCbD7HTRtm5XSqilptzej jtgw== X-Forwarded-Encrypted: i=1; AHgh+RrkrARJkk64GpDiO5UzGCShianFfoLuMQ0NEYBEA6Sn7brwJDkzVEwt/yBgevL6Er5dauXikYQBXuPCPX0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5/jtNy+hdtqS/bpu7734kZsNO4ynRSW4dM6BoYfdn7L3qyzzG c6v5VGhOsT+PBfhiXcKNcuAvN685nNFUYF5g9m8Va8Tr26Fq6CyrgA+Ih+yTZMp9A0wTg/eNs5n DPKbvul2dOOviLRWGwyGApj7cWsSuHEYEZ3ZPu7XCzLxUWeegp3EP1WezZZoBiTp5JpE= X-Gm-Gg: AR+sD111ieOu0FhkGz1N1oL1eiAT9T9su2aTmviMqAecq4E5q9ATfGiEaa16XHQmqMP +zJTvHVcRwJMddq4K354cHiiGqoFCsB56AmHsInDOoi2x/eWxoP+PAbZYN3sETMdu5jpRT7kY6i TjHimo4cRSwd7toGI3kgpNiuDvEcA76A+knr9zO9h34DOqf0oXnSOscp2Q4Cc69ZRHEh67tT0tW P/oyGE1Da8WXTCAkm4mMnpj3RLBGYSXwYuOfyVM1iAbW/7r6iOJk+gxJkcPUR4vbcGCI6gFhaYK DAijQTFcTqkzlH/IQPKZvZBjLFYLqEWnSTnTEYDI/YQM53oV69uiDhWC11aMSE8ydkOgH8O6C5H tHPKyYmhPqsVHMsNhxiy/Dk7eCg== X-Received: by 2002:a05:6a21:1fc8:b0:3c8:e10b:7a9b with SMTP id adf61e73a8af0-3c92a58e56dmr11875998637.16.1785795227528; Mon, 03 Aug 2026 15:13:47 -0700 (PDT) X-Received: by 2002:a05:6a21:1fc8:b0:3c8:e10b:7a9b with SMTP id adf61e73a8af0-3c92a58e56dmr11875951637.16.1785795226835; Mon, 03 Aug 2026 15:13:46 -0700 (PDT) Received: from localhost ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153e06f88fsm40649703eec.20.2026.08.03.15.13.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 15:13:46 -0700 (PDT) Date: Mon, 3 Aug 2026 15:13:42 -0700 From: Jonathan Cameron To: Andre Przywara Cc: Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Len Brown , James Morse , Ben Horgan , Reinette Chatre , Fenghua Yu , Jonathan Cameron , Srivathsa L Rao , Ganapatrao Kulkarni , Trilok Soni , Srinivas Ramana , Niyas Sait , Lee Trager , Ritwick Sharma , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 05/11] arm_mpam: propagate MSC access errors for __ris_msmon_read() Message-ID: <20260803151342.00000c3d@oss.qualcomm.com> In-Reply-To: <20260731170324.2927758-6-andre.przywara@arm.com> References: <20260731170324.2927758-1-andre.przywara@arm.com> <20260731170324.2927758-6-andre.przywara@arm.com> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=aoaCzyZV c=1 sm=1 tr=0 ts=6a71129c cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=7CQSdrXTAAAA:8 a=EUspDBNiAAAA:8 a=gj-DCe7_c4ZTHBUR5qIA:9 a=CjuIK1q_8ugA:10 a=x9snwWr2DeNwDh03kgHS:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-GUID: Bp1RPaRjuuzacGc5ME5eGWNXMzBGY5RF X-Proofpoint-ORIG-GUID: Bp1RPaRjuuzacGc5ME5eGWNXMzBGY5RF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAzMDE5NSBTYWx0ZWRfX9UbVEsEpOA/4 Mu6z/jnJTYDxfwIj6QY16IeQlO69CDetLIW8UO11evTDKuWlWtCiApiO4iuj82omZvckGwC/U7/ 74yMyTPDgJ82f15rQRMOrrYT3HWltadqe3mN2OihRwR//sp2mUfohTpQ65Qe9PPaR0L1qljomOP 19sxHnVP4pHkz+7wS8iJx2Lu+yXpSmq9Kc+W7JVXRPB7CTPXB2ISBoChZhjdMg+uon9yIJB/nBj Hs5lKgsEWm/DI5b2lUEL/iNeLUP1TonvhDjzfI5Jt60dEdtfJsYVmaYPIe2kI2u3+fOoq4sVZHZ Y7fzW4n0nztd5e5T+dwtevQkkWz3SKsqfSJ49yT45DNv4bXHol38fmJyoOcyMdDeiAtxGmvmKfs okSlMJnbfjdJcCjLhWDtFRNXdZzrqBqWUWx89IULS5zjWp7HDz5dMYAI7yYB86RIlF1a9/aFkom Z8bj4EPn/1+lXBWfrwA== X-Proofpoint-Spam-Info: AW1haW4tMjYwODAzMDE5NSBTYWx0ZWRfX0ITz7Rlj9Qfo X4+IudUcyKAQQ9iZxfN1GT5EieYqWtlFjX9ewpnmP4yEdB0tby8FkGgjxNHwvhNu8ouwN7AVP2c AWHy7uWgn5J/BeQG90w/G5UF5RQcfag= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-03_05,2026-08-03_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 suspectscore=0 priorityscore=1501 adultscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608030195 On Fri, 31 Jul 2026 19:03:18 +0200 Andre Przywara wrote: > Allow the function for RIS accesses to return an error, and propagate > read and write errors from the lower level up. > This function is a bit special, since it can be called via an SMP > helper, so the prototype must stay as void. So propagate any errors > using the "err" field in the struct passed in as the sole argument to > that function. > > Signed-off-by: Andre Przywara > Reviewed-by: Jonathan Cameron Just taking a fresh look and one really trivial formatting thing popped out. > --- > drivers/resctrl/mpam_devices.c | 36 +++++++++++++++++++++++++--------- > 1 file changed, 27 insertions(+), 9 deletions(-) > > diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c > index 9d9f0c635527..fa8ed20a6740 100644 > --- a/drivers/resctrl/mpam_devices.c > +++ b/drivers/resctrl/mpam_devices.c > @@ -1390,18 +1398,24 @@ static void __ris_msmon_read(void *arg) > cur_ctl != (ctl_val | MSMON_CFG_x_CTL_EN); > > if (config_mismatch || reset_on_next_read) { > - write_msmon_ctl_flt_vals(m, ctl_val, flt_val); > + m->err = write_msmon_ctl_flt_vals(m, ctl_val, flt_val); > + if (m->err) > + return; > overflow = false; > } else if (overflow) { > - mpam_write_monsel_reg(msc, CFG_MBWU_CTL, > - cur_ctl & > - ~(MSMON_CFG_x_CTL_OFLOW_STATUS | > - MSMON_CFG_MBWU_CTL_OFLOW_STATUS_L)); > + m->err = mpam_write_monsel_reg(msc, CFG_MBWU_CTL, > + cur_ctl & > + ~(MSMON_CFG_x_CTL_OFLOW_STATUS | > + MSMON_CFG_MBWU_CTL_OFLOW_STATUS_L)) Indent seems to be wrong here. m->err = mpam_write_monsel_reg(msc, CFG_MBWU_CTL, cur_ctl & ~(MSMON_CFG_x_CTL_OFLOW_STATUS | MSMON_CFG_MBWU_CTL_OFLOW_STATUS_L)); > + if (m->err) > + return; > }