From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6032834CFCF for ; Mon, 3 Aug 2026 16:02:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785772931; cv=none; b=RiFtWjfD+trbDF0+c6PlPSISSOmFFr75Lce8KnJ1UweLsxphsuEjqQS0Ybc0oYNk1q5LRZfFauPCbnF70AFyGVDIlYkoT1HbOtEYGs+SgEq0Xnpd0tnJrpgDBqrxcAam1q4PX9ZfAKYM0gpFDBWbrlo0G3ow7+7K4Dh48KiOUQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785772931; c=relaxed/simple; bh=sKowtTzQp4+cET6tX6l5fuagLeNhEMJZlcZAPa64h5k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XGTdp4vsLVhH/wpE68CJeFc8V65K6j7zDeS8MQnmWz2IUVkS8rfb7xA7B4o9hWzI46fNkdv0PdExW12BG6k6cNhaVF+Nv0DU9W4YerWHgX1QNklm4e2A0HWa3H3KFX73AgG9d7zD2gh/ryYFe9HSa7II/Vclls0+01TWftW6Yog= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H8f5N+su; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H8f5N+su" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-381b831d535so4028923a91.0 for ; Mon, 03 Aug 2026 09:02:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785772929; x=1786377729; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Romog+KVjTIvd/B61z2MJiXe0e1BJo//nd6rEKZqcdk=; b=H8f5N+suKoQjEOCUsN7qlFPYZN1ZEFOIwnzI3KtkmhRInf9DO+r08H+QLc33+8jHUJ 4Ml6WtEW2gfW91bXf6n/NZ4oi/6wh+wlAust43VpOx4E8tnBzLPPFeYtqap/1zx6Wq5c z7Ts8X2ndD7ZYZIpkhDUbGHI9w+3xRGzgoH+88kpjqym9mt8Da1d9ebbhjdPphScyISa AVDKgiveSAKuFAscrjC71CSfXuFfKabf4ioXmuL6RFOBZ8UW2NjB3W8B2QrbTgdb51ap BL4uKfiPXnp6WlKDcCUzUzhbHOOR6FDwZwZOCmBK838dysrC0bQF6q8IK5kiVgCv1w5F RMhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785772929; x=1786377729; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Romog+KVjTIvd/B61z2MJiXe0e1BJo//nd6rEKZqcdk=; b=MjIquoUZF5qf5eGYXO739bVQBquoDAfteuDdJ0d/1ZhuU1FwGsvthh0479RFLDIrH7 UUV7e/UJYEZ87D7FvlMj3Mq/SB+0s8s0Uqle2LFBckxb+HsWMXrltXK/19XycpAwDjLe XlJ/qDbS81baYDjBM0CW+FfM7Zfx9+EqI/Cd5cwTbtTvwEHE9fBLeKgNuxxZdsdz8yg3 OvD6eap8/nZpuluOpTUv0p4st+BwKCZHtfNtqBm/UyvYgF83dWDGw94jurpmXxsfFmXn 1ke6g1tECyIaZ1YvW/OpUNQMupwDCN67K8dqsuvbozWnTgfvb1jEL2JHlB7EV8VTXYtX 96BQ== X-Forwarded-Encrypted: i=1; AHgh+RpBvMJBwx6jXtcZyYw1pKqeRst5PmLjGFCT8YLnWqYkBIPNknr5ABBqhzGIJBNl7jwxLbG8iR+qEL1GE2U=@vger.kernel.org X-Gm-Message-State: AOJu0Yyhj185uZSzCvk7GiC+ZmJRi63dh2lIUSZHlk4SB3hy7dymtGDY feRbZ3fRP7MBb+ip6RTe+wzPYSC/yq84p3VG8jZML9ezayZvC0mBeci5 X-Gm-Gg: AR+sD11uahIPvw5CD1r3Ak85pbJ90NmwNBHPhnfhSFxvuF4pmbSXeQciWaJ4cm1898x TEXk0XTtpPRYzbj1SXP6GKOQdYau4cH9CxEzSMUwvFgdWx1kDaUcrLy6WaOG58GU7ysnMFNV+vb dB64eoXIEOMwrjAgdfibIeeTGE7yc2DbIT/A6UDht5W/+pSwWudKqY0Ks1VJ5ys8HPogkU6yrbZ OFZVtlpCF74uIrgaz7KZQBkiigC7OE4PNzupYtxBoHdiORcdrrfm/v+qaRIKsrs8CV9tNdJmCNg aNU+R78THkRBicxgyUWOSgf6P0p80HKDv3ZUgOIalpKQWg59tt2/yV4LQWDqA5TgIgtA7kJv7NG dSmAdpEOknBoSQZ8941FzdCegMo24itHQVO3+zhdwFnFvFQOk/iGj8CqR9MzCv0zqtZxyR8pL8Y e4O6pYCYkJMYI/El/RBtesqyfSHd8kUcNGIcZjFWAuNERQ02MahN0fp6IJs9memIlq0Poc5mAlR kq3QI+CTkWWg+x7IEFwoaLe X-Received: by 2002:a17:90b:3a10:b0:38e:79f:76c6 with SMTP id 98e67ed59e1d1-38fbc4cffc7mr9600502a91.24.1785772927737; Mon, 03 Aug 2026 09:02:07 -0700 (PDT) Received: from Debian.tail44843d.ts.net ([183.82.161.178]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153e044912sm45831506eec.15.2026.08.03.09.02.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 09:02:05 -0700 (PDT) From: Mirza Ishan Beg To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, nikolayof23@gmail.com, Mirza Ishan Beg Subject: [PATCH v2] staging: rtl8723bs: refactor traffic_stat access in collect_traffic_statistics Date: Mon, 3 Aug 2026 21:30:55 +0530 Message-ID: <20260803160055.18205-1-seedandsyntax@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260803144826.15980-1-seedandsyntax@gmail.com> References: <20260803144826.15980-1-seedandsyntax@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace repetitive `pdvobjpriv->traffic_stat.` dereferencing with a local pointer `ts` to improve readability and reduce line length. This resolves multiple checkpatch line-length warnings without manual wrapping. Suggested-by: Nikolay Kulikov Signed-off-by: Mirza Ishan Beg Link: https://lore.kernel.org/linux-staging/agDaGJ5UKndFUNPY@archlinux/ --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 25 ++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c index ce3dfa1fee26..277eccba293c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -1109,25 +1109,26 @@ u8 rtw_dynamic_chk_wk_cmd(struct adapter *padapter) static void collect_traffic_statistics(struct adapter *padapter) { struct dvobj_priv *pdvobjpriv = adapter_to_dvobj(padapter); + struct traffic_stat *ts = &pdvobjpriv->traffic_stat /* Tx */ - pdvobjpriv->traffic_stat.tx_bytes = padapter->xmitpriv.tx_bytes; - pdvobjpriv->traffic_stat.tx_pkts = padapter->xmitpriv.tx_pkts; - pdvobjpriv->traffic_stat.tx_drop = padapter->xmitpriv.tx_drop; + ts->tx_bytes = padapter->xmitpriv.tx_bytes; + ts->tx_pkts = padapter->xmitpriv.tx_pkts; + ts->tx_drop = padapter->xmitpriv.tx_drop; /* Rx */ - pdvobjpriv->traffic_stat.rx_bytes = padapter->recvpriv.rx_bytes; - pdvobjpriv->traffic_stat.rx_pkts = padapter->recvpriv.rx_pkts; - pdvobjpriv->traffic_stat.rx_drop = padapter->recvpriv.rx_drop; + ts->rx_bytes = padapter->recvpriv.rx_bytes; + ts->rx_pkts = padapter->recvpriv.rx_pkts; + ts->rx_drop = padapter->recvpriv.rx_drop; /* Calculate throughput in last interval */ - pdvobjpriv->traffic_stat.cur_tx_bytes = pdvobjpriv->traffic_stat.tx_bytes - pdvobjpriv->traffic_stat.last_tx_bytes; - pdvobjpriv->traffic_stat.cur_rx_bytes = pdvobjpriv->traffic_stat.rx_bytes - pdvobjpriv->traffic_stat.last_rx_bytes; - pdvobjpriv->traffic_stat.last_tx_bytes = pdvobjpriv->traffic_stat.tx_bytes; - pdvobjpriv->traffic_stat.last_rx_bytes = pdvobjpriv->traffic_stat.rx_bytes; + ts->cur_tx_bytes = ts->tx_bytes - ts->last_tx_bytes; + ts->cur_rx_bytes = ts->rx_bytes - ts->last_rx_bytes; + ts->last_tx_bytes = ts->tx_bytes; + ts->last_rx_bytes = ts->rx_bytes; - pdvobjpriv->traffic_stat.cur_tx_tp = (u32)(pdvobjpriv->traffic_stat.cur_tx_bytes * 8 / 2 / 1024 / 1024); - pdvobjpriv->traffic_stat.cur_rx_tp = (u32)(pdvobjpriv->traffic_stat.cur_rx_bytes * 8 / 2 / 1024 / 1024); + ts->cur_tx_tp = (u32)(ts->cur_tx_bytes * 8 / 2 / 1024 / 1024); + ts->cur_rx_tp = (u32)(ts->cur_rx_bytes * 8 / 2 / 1024 / 1024); } bool traffic_status_watchdog(struct adapter *padapter, bool from_timer) -- 2.47.3