From: Mirza Ishan Beg <seedandsyntax@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
nikolayof23@gmail.com, seedandsyntax@gmail.com
Subject: [PATCH v3] staging: rtl8723bs: refactor traffic_stat access in collect_traffic_statistics
Date: Mon, 3 Aug 2026 23:33:29 +0530 [thread overview]
Message-ID: <20260803180549.20859-1-seedandsyntax@gmail.com> (raw)
In-Reply-To: <20260803160055.18205-1-seedandsyntax@gmail.com>
Replace repetitive `pdvobjpriv->traffic_stat.` dereferencing with a local
pointer `ts` to improve readability and reduce line length. This resolves
multiple checkpatch line-length warnings without manual wrapping.
Suggested-by: Nikolay Kulikov <nikolayof23@gmail.com>
Signed-off-by: Mirza Ishan Beg <seedandsyntax@gmail.com>
Link: https://lore.kernel.org/linux-staging/agDaGJ5UKndFUNPY@archlinux/
---
Changes in v3:
- Fix missing semicolon in pointer declaration
Changes in v2:
- Added Link: tag with lore URL as suggested by Greg KH
drivers/staging/rtl8723bs/core/rtw_cmd.c | 25 ++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index ce3dfa1fee26..4aa430284a59 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -1109,25 +1109,26 @@ u8 rtw_dynamic_chk_wk_cmd(struct adapter *padapter)
static void collect_traffic_statistics(struct adapter *padapter)
{
struct dvobj_priv *pdvobjpriv = adapter_to_dvobj(padapter);
+ struct traffic_stat *ts = &pdvobjpriv->traffic_stat;
/* Tx */
- pdvobjpriv->traffic_stat.tx_bytes = padapter->xmitpriv.tx_bytes;
- pdvobjpriv->traffic_stat.tx_pkts = padapter->xmitpriv.tx_pkts;
- pdvobjpriv->traffic_stat.tx_drop = padapter->xmitpriv.tx_drop;
+ ts->tx_bytes = padapter->xmitpriv.tx_bytes;
+ ts->tx_pkts = padapter->xmitpriv.tx_pkts;
+ ts->tx_drop = padapter->xmitpriv.tx_drop;
/* Rx */
- pdvobjpriv->traffic_stat.rx_bytes = padapter->recvpriv.rx_bytes;
- pdvobjpriv->traffic_stat.rx_pkts = padapter->recvpriv.rx_pkts;
- pdvobjpriv->traffic_stat.rx_drop = padapter->recvpriv.rx_drop;
+ ts->rx_bytes = padapter->recvpriv.rx_bytes;
+ ts->rx_pkts = padapter->recvpriv.rx_pkts;
+ ts->rx_drop = padapter->recvpriv.rx_drop;
/* Calculate throughput in last interval */
- pdvobjpriv->traffic_stat.cur_tx_bytes = pdvobjpriv->traffic_stat.tx_bytes - pdvobjpriv->traffic_stat.last_tx_bytes;
- pdvobjpriv->traffic_stat.cur_rx_bytes = pdvobjpriv->traffic_stat.rx_bytes - pdvobjpriv->traffic_stat.last_rx_bytes;
- pdvobjpriv->traffic_stat.last_tx_bytes = pdvobjpriv->traffic_stat.tx_bytes;
- pdvobjpriv->traffic_stat.last_rx_bytes = pdvobjpriv->traffic_stat.rx_bytes;
+ ts->cur_tx_bytes = ts->tx_bytes - ts->last_tx_bytes;
+ ts->cur_rx_bytes = ts->rx_bytes - ts->last_rx_bytes;
+ ts->last_tx_bytes = ts->tx_bytes;
+ ts->last_rx_bytes = ts->rx_bytes;
- pdvobjpriv->traffic_stat.cur_tx_tp = (u32)(pdvobjpriv->traffic_stat.cur_tx_bytes * 8 / 2 / 1024 / 1024);
- pdvobjpriv->traffic_stat.cur_rx_tp = (u32)(pdvobjpriv->traffic_stat.cur_rx_bytes * 8 / 2 / 1024 / 1024);
+ ts->cur_tx_tp = (u32)(ts->cur_tx_bytes * 8 / 2 / 1024 / 1024);
+ ts->cur_rx_tp = (u32)(ts->cur_rx_bytes * 8 / 2 / 1024 / 1024);
}
bool traffic_status_watchdog(struct adapter *padapter, bool from_timer)
--
2.47.3
next prev parent reply other threads:[~2026-08-03 18:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 14:48 [PATCH] staging: rtl8723bs: refactor traffic_stat access in collect_traffic_statistics Mirza Ishan Beg
2026-08-03 15:09 ` Greg KH
2026-08-03 15:43 ` Mirza Ishan Beg
2026-08-03 15:46 ` Greg KH
2026-08-03 16:00 ` [PATCH v2] " Mirza Ishan Beg
2026-08-03 18:03 ` Mirza Ishan Beg [this message]
2026-08-06 17:15 ` [PATCH] " kernel test robot
2026-08-06 22:04 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260803180549.20859-1-seedandsyntax@gmail.com \
--to=seedandsyntax@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nikolayof23@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox