From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C73982F1FEC for ; Mon, 3 Aug 2026 22:16:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785795383; cv=none; b=CaC3sJw9FsG/RZhJGZSxAkYXn6LxTPGrebnVT59R8o4q+Hupeb7VSEKv5W0tk8j1ZDbtEpHxd8/e58fUIhg6hT0mzLAiEepJ2Vcrad0xJgpQNvQST7HZENEee3KGkWLymOJDH3hIAtUpIcuq2QLSqYJkXOjWjl4x9cD1IiYPXX4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785795383; c=relaxed/simple; bh=HDD3BCKdaHCS43NkUBSwVd1u/RrPToWuCQHOzDVsYZc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ADBlA600/uuusErXrttApy2/InTK3GxCr5g8m2aLVOnDjlAK4Y9iQK/THst/OaYeFUuhtE8fZ8WQx1N0F9vtlFr93k5Qyw8ZJnOe9rix97AF9ILUHzN8R5TiADeX+hx6ILp+WdQ0ocas3uB/0XCYms5uqJE6ChPyYmTSD49ITF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IFcZbazF; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IFcZbazF" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2d032846c95so42868165ad.1 for ; Mon, 03 Aug 2026 15:16:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785795381; x=1786400181; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CHofJjuC+8WuxnJ+ZeRv8pXBm7Br8DGbmZDVzBhVs0c=; b=IFcZbazFn+Fmk/LZgH61+d1mZMsZekarVk4MbEJ5rz1Ilz2VEJmnLqep86XPaLu0vX ONQg07jdk0M6sLfsjUGzZtVsqNjOC0/ULpHQD+r9UnZ68GUPQm2R/rPgbm8Q6AsH8i11 6t2Dk4CjPylYQcwX4U7J0gQxafSaFklj1Sq+GTYW6HVjlMSuepE8W2BCmPgMeOig6E0W UVKDRa5KAUMNQyc3qjaAuZSNP0QhQxJtTkNZbpH38DUkpF4/F17ovL3MEjFivetDNVEv 6J0V9PNCFSFFlY/rDXh2q0WA7Qau/asEpzFa+T2+24EQi76cE+tpJhW421BC7HoKS40V m4UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785795381; x=1786400181; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=CHofJjuC+8WuxnJ+ZeRv8pXBm7Br8DGbmZDVzBhVs0c=; b=RzEkkcZP60wSFYRRPpt6qpdYnf5VxJk31u5HOc+WT1VlSMLwfTDdBJb8CCJoSBRVfa X+QnLdRPV7wu1qM1JsxiHS6oLV2UtY/XOlAhnmVYEv7zKW2tm08+Bu3IHhXitRXO5gJL QGBqAzKYC6rpQK4FFWaMeZBmazpRM0nPfyquxewVK6WL2z/CHQbpqbLhSgHJIbJl6Y9p N3D22vguJHXJ+zGecM1kqV1yt2ubtgE/jT5Za5WXo+5ij6pH4TtvcEkOcc4cxlrAV3RU 4KKMWcVaLJ1IM6fa33tCQA20dSqIfFdJ1J7IJl94ktqveaLXwfRZ2MGWUf1jCgSP82my uGdg== X-Forwarded-Encrypted: i=1; AHgh+RpEV4Hg08HLg5shyv4GQqAb/UuDRf9oyIQVjIFrLUy6eBBC+1DYkgpGsND17OszmBmbZBEGH++4xUPtw7w=@vger.kernel.org X-Gm-Message-State: AOJu0YyIqV9KJwigN5AZFUq5VB2SgDC7R7QDxmX63sWDq1PDGlND+NiY E5SNt3gKjqiVHtotYemcVBVbmtVLqDLa/vk+5i9AnOu3HlzRU4bUVgMa X-Gm-Gg: AR+sD13E7JqIaGYKP8+H5oE5yrPSAUVuCi/R9Q4MsTMDy9Yj0ugePKEz/JhKi6SuADB N0vML6b8nFTRZQX2D9MIQWV8SZFTvGbzoBdzwQfYqChZU5b+ttvkrYRbiJ2/ZBzq4nGbhoOQL/V fReryL6Ub6UIPXoJp+EsnrPEYh/0qMiICZm06i8hZuwvA55s+NfJczmLxo8oT99AZmljCmAWpmb TCtt1wZyUXF5SccWeCBcFxy0vANjL0EJcrV7c4iEPMdJQTiWN7e+Rk1fUoHDqi0csYazfeUIBcp gFPHa1IPLtkJuLcDvBx95xAbqkCt8F11l6LZyXmzfllLcnT0KJsjPRXJ1ezlsv/sJMutzUCHFMW wJi4XRsFFIyn4KdTnEsVHDgxZNDHjEy+bksG0Nra+P0mZhPkiFfZsrY9xptLWAR370G4E5Vi7yG esVYKIfJhGP3Ntc0W4rkw6EUbNSJTI9svuNT/AVnxo6iWmOOKhQNcnvjCPC1+Lm78NQcPslHVOZ 3UQ/8ADVC9vHcCObyk2lz2Vxvy9jzPiYNIzx6QZdQ== X-Received: by 2002:a05:6a21:a91:b0:3b4:b340:411d with SMTP id adf61e73a8af0-3c92a529fa5mr12008651637.24.1785795381179; Mon, 03 Aug 2026 15:16:21 -0700 (PDT) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13fab1334cfsm38685666c88.1.2026.08.03.15.16.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 15:16:20 -0700 (PDT) From: "Derek J. Clark" To: lkml@antheas.dev Cc: W_Armin@gmx.de, corbet@lwn.net, hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, jdelvare@suse.com, kuurtb@gmail.com, linux-doc@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, "Derek J. Clark" Subject: [PATCH 1/6] platform/x86: msi-wmi-platform: Move guard out of switch in platform_write() Date: Mon, 3 Aug 2026 15:16:09 -0700 Message-ID: <20260803221614.59324-2-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260803221614.59324-1-derekjohn.clark@gmail.com> References: <20250511204427.327558-1-lkml@antheas.dev> <20260803221614.59324-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The ML patch set uses a guard within a switch case that violates cleanup rules. Move the guard outside the switch so all return paths are covered. Signed-off-by: Derek J. Clark --- drivers/platform/x86/msi-wmi-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/msi-wmi-platform.c b/drivers/platform/x86/msi-wmi-platform.c index dfb65ac8fbf6..33acd448f674 100644 --- a/drivers/platform/x86/msi-wmi-platform.c +++ b/drivers/platform/x86/msi-wmi-platform.c @@ -675,11 +675,11 @@ static int msi_wmi_platform_write(struct device *dev, enum hwmon_sensor_types ty u8 buffer[32] = { }; int ret; + guard(mutex)(&data->wmi_lock); switch (type) { case hwmon_pwm: switch (attr) { case hwmon_pwm_enable: - guard(mutex)(&data->wmi_lock); buffer[0] = MSI_PLATFORM_AP_SUBFEATURE_FAN_MODE; ret = msi_wmi_platform_query_unlocked( -- 2.55.0