From: Rosen Penev <rosenp@gmail.com>
To: linux-gpio@vger.kernel.org
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
linuxppc-dev@lists.ozlabs.org (open list:LINUX FOR POWERPC
(32-BIT AND 64-BIT)), linux-kernel@vger.kernel.org (open list)
Subject: [PATCHv2 4/8] gpio: ppc44x: Use platform resource helper for GPIO MMIO
Date: Mon, 3 Aug 2026 15:35:35 -0700 [thread overview]
Message-ID: <20260803223539.86303-5-rosenp@gmail.com> (raw)
In-Reply-To: <20260803223539.86303-1-rosenp@gmail.com>
Map the PPC44x GPIO register block through the platform device
resource instead of reparsing the firmware node directly.
The GPIO node now probes as a platform device, so use the
platform helper to keep resource handling aligned with the converted
driver model and to report mapping failures with the platform device
context.
Move ioremap up in order to avoid doing extra work in case of
-EPROBE_DEFER.
Assisted-by: Codex:GPT-5.5
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/gpio/gpio-ppc44x.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-ppc44x.c b/drivers/gpio/gpio-ppc44x.c
index 99fb11cd7966..5db5217c0225 100644
--- a/drivers/gpio/gpio-ppc44x.c
+++ b/drivers/gpio/gpio-ppc44x.c
@@ -158,13 +158,20 @@ static int ppc44x_gpio_probe(struct platform_device *ofdev)
{
struct device *dev = &ofdev->dev;
struct device_node *np = dev->of_node;
+ struct ppc44x_gpio __iomem *regs;
struct ppc44x_gpio_chip *chip;
struct gpio_chip *gc;
+ regs = devm_platform_ioremap_resource(ofdev, 0);
+ if (IS_ERR(regs))
+ return PTR_ERR(regs);
+
chip = devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL);
if (!chip)
return -ENOMEM;
+ chip->regs = regs;
+
spin_lock_init(&chip->lock);
gc = &chip->gc;
@@ -181,10 +188,6 @@ static int ppc44x_gpio_probe(struct platform_device *ofdev)
if (!gc->label)
return -ENOMEM;
- chip->regs = devm_of_iomap(dev, np, 0, NULL);
- if (IS_ERR(chip->regs))
- return PTR_ERR(chip->regs);
-
return devm_gpiochip_add_data(dev, gc, chip);
}
--
2.55.0
next prev parent reply other threads:[~2026-08-03 22:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 22:35 [PATCHv2 0/8] gpio: move ppc4xx driver to drivers/gpio and modernize Rosen Penev
2026-08-03 22:35 ` [PATCHv2 1/8] gpio: move ppc4xx gpio driver from arch/powerpc to drivers/gpio Rosen Penev
2026-08-03 22:35 ` [PATCHv2 2/8] gpio: ppc44x: update all 4xx to 44x Rosen Penev
2026-08-03 22:35 ` [PATCHv2 3/8] gpio: ppc44x: Use module platform driver helper for GPIO Rosen Penev
2026-08-03 22:35 ` Rosen Penev [this message]
2026-08-03 22:35 ` [PATCHv2 5/8] gpio: ppc44x: Convert GPIO to generic MMIO Rosen Penev
2026-08-03 22:35 ` [PATCHv2 6/8] gpio: ppc44x: drop PPC-specific IO helpers Rosen Penev
2026-08-03 22:35 ` [PATCHv2 7/8] gpio: ppc44x: fix undefined behavior in GPIO_MASK2 macro Rosen Penev
2026-08-03 22:35 ` [PATCHv2 8/8] gpio: ppc44x: use dev_name() for chip label Rosen Penev
2026-08-06 22:15 ` [PATCHv2 0/8] gpio: move ppc4xx driver to drivers/gpio and modernize Linus Walleij
2026-08-07 3:54 ` Madhavan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260803223539.86303-5-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=brgl@kernel.org \
--cc=chleroy@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox