From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Crescent Hsieh <crescentcy.hsieh@moxa.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
FangpingFP.Cheng@moxa.com, Epson.Chiang@moxa.com,
EddieSY.Lin@moxa.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v5 00/14] serial: 8250: add Moxa MUEx50 PCIe board support
Date: Mon, 3 Aug 2026 16:52:57 +0200 [thread overview]
Message-ID: <2026080335-prewashed-cozily-9bc8@gregkh> (raw)
In-Reply-To: <20260731074820.735619-1-crescentcy.hsieh@moxa.com>
On Fri, Jul 31, 2026 at 03:48:06PM +0800, Crescent Hsieh wrote:
> This series consolidates Moxa PCIe multiport serial board support under a
> dedicated 8250_mxpcie driver and adds MUEx50 UART support needed by these
> boards.
>
> The first part splits the existing Moxa PCIe board handling out of
> 8250_pci into a separate driver while preserving the existing probe flow
> and device IDs. The series then introduces the MUEx50 UART port type and
> enables the board-specific UART setup, including enhanced mode and FIFO
> trigger programming.
>
> The driver adds hardware-assisted flow control support for MUEx50 UARTs,
> including automatic RTS/CTS handling and XON/XOFF offload. It also adds a
> custom IRQ path and uses the MUEx50 memory-mapped FIFO windows to improve
> RX and TX data movement.
>
> Later patches add serial interface mode switching, RS485 break handling,
> and per-port private state for MUEx50-specific configuration. The driver
> supports switching the serial interface mode through the RS485
> configuration path, covering RS232, RS422, and RS485 modes supported by
> the boards.
>
> The final part extends 8250 core callbacks where needed so low-level
> drivers can override break control and rx_trig_bytes handling. The
> 8250_mxpcie driver uses these hooks to implement RS485 break handling via
> MUEx50 features and to expose the MUEx50 programmable RX trigger level
> through the generic rx_trig_bytes sysfs interface.
I've queued this up now, for the issues that Andy pointed out, feel free
to just send follow-on patches, thanks!
greg k-h
prev parent reply other threads:[~2026-08-03 14:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 7:48 [PATCH v5 00/14] serial: 8250: add Moxa MUEx50 PCIe board support Crescent Hsieh
2026-07-31 7:48 ` [PATCH v5 01/14] serial: 8250: split Moxa PCIe serial board support out of 8250_pci Crescent Hsieh
2026-08-02 8:35 ` Andy Shevchenko
2026-07-31 7:48 ` [PATCH v5 02/14] serial: 8250: add Moxa MUEx50 UART port type Crescent Hsieh
2026-07-31 7:48 ` [PATCH v5 03/14] serial: 8250_mxpcie: enable enhanced mode and program FIFO trigger levels Crescent Hsieh
2026-07-31 7:48 ` [PATCH v5 04/14] serial: 8250_mxpcie: enable automatic RTS/CTS flow control Crescent Hsieh
2026-08-02 8:58 ` Andy Shevchenko
2026-07-31 7:48 ` [PATCH v5 05/14] serial: 8250_mxpcie: offload XON/XOFF flow control to MUEx50 hardware Crescent Hsieh
2026-08-02 9:00 ` Andy Shevchenko
2026-07-31 7:48 ` [PATCH v5 06/14] serial: 8250_mxpcie: add custom handle_irq callback Crescent Hsieh
2026-07-31 7:48 ` [PATCH v5 07/14] serial: 8250_mxpcie: speed up RX using memory-mapped FIFO window Crescent Hsieh
2026-08-02 9:03 ` Andy Shevchenko
2026-07-31 7:48 ` [PATCH v5 08/14] serial: 8250_mxpcie: speed up TX " Crescent Hsieh
2026-08-02 9:10 ` Andy Shevchenko
2026-08-03 4:46 ` Jiri Slaby
2026-08-03 7:26 ` Andy Shevchenko
2026-08-03 7:28 ` Andy Shevchenko
2026-07-31 7:48 ` [PATCH v5 09/14] serial: 8250_mxpcie: support serial interface mode switching Crescent Hsieh
2026-07-31 7:48 ` [PATCH v5 10/14] serial: 8250: allow low-level drivers to override break control Crescent Hsieh
2026-07-31 7:48 ` [PATCH v5 11/14] serial: 8250_mxpcie: add break support for RS485 using MUEx50 features Crescent Hsieh
2026-07-31 7:48 ` [PATCH v5 12/14] serial: 8250: allow UART drivers to override rx_trig_bytes handling Crescent Hsieh
2026-08-02 9:20 ` Andy Shevchenko
2026-08-04 3:52 ` Crescent Hsieh
2026-07-31 7:48 ` [PATCH v5 13/14] serial: 8250_mxpcie: introduce per-port private data structure Crescent Hsieh
2026-07-31 7:48 ` [PATCH v5 14/14] serial: 8250_mxpcie: implement rx_trig_bytes callbacks via MUEx50 RTL Crescent Hsieh
2026-08-03 14:52 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026080335-prewashed-cozily-9bc8@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=EddieSY.Lin@moxa.com \
--cc=Epson.Chiang@moxa.com \
--cc=FangpingFP.Cheng@moxa.com \
--cc=andy.shevchenko@gmail.com \
--cc=crescentcy.hsieh@moxa.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox