The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org,
	syzbot+eaa106d192c9daf37f95@syzkaller.appspotmail.com
Subject: Re: [PATCH] usb: gadget: midi2: remove default configfs groups on teardown
Date: Mon, 3 Aug 2026 08:25:35 +0200	[thread overview]
Message-ID: <2026080342-theorize-everybody-9f2c@gregkh> (raw)
In-Reply-To: <CALoEA-yuzdD9=gBy0s0VFc2yD5Kwga57LjECUWTTXdF2SHed8g@mail.gmail.com>

On Mon, Aug 03, 2026 at 07:59:17AM +0200, Joshua Crofts wrote:
> On Thu, 30 Jul 2026 at 15:58, Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> >
> > f_midi2_alloc_inst() creates default configfs child groups for the
> > default endpoint and default block using configfs_add_default_group(),
> > setting their internal refcount to 1.
> >
> > However, during function teardown in f_midi2_free_inst() or EP cleanup
> > in f_midi2_ep_opts_release(), configfs_remove_default_groups() is
> > never called, therefore never dropping the refcount and leaking struct
> > f_midi2_ep_opts and f_midi2_block_opts.
> >
> > Add the missing configfs_remove_default_groups() in the afformentioned
> > functions to free the structs properly.
> >
> > Fixes: 8b645922b223 ("usb: gadget: Add support for USB MIDI 2.0 function driver")
> > Cc: <stable@vger.kernel.org>
> > Reported-by: syzbot+eaa106d192c9daf37f95@syzkaller.appspotmail.com
> > Closes: https://syzkaller.appspot.com/bug?extid=eaa106d192c9daf37f95
> > Tested-by: syzbot+eaa106d192c9daf37f95@syzkaller.appspotmail.com
> > Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
> > ---
> > Aside from testing the fix locally with QEMU and the reproducer,
> > syzbot also reports no issues after running `syz test`.
> > ---
> 
> Hi Greg,
> 
> Gentle ping on this patch.

It's been 2 "business days" since you sent this.  What's the rush?  If
you wish to see patches reviewed faster, please help out in reviewing
other patches on the list.

And as this is really only a syzbot issue, the "severity" is low, right?

thanks,

greg k-h

  reply	other threads:[~2026-08-03  6:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30 13:58 [PATCH] usb: gadget: midi2: remove default configfs groups on teardown Joshua Crofts
2026-08-03  5:59 ` Joshua Crofts
2026-08-03  6:25   ` Greg Kroah-Hartman [this message]
2026-08-03  7:17     ` Joshua Crofts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026080342-theorize-everybody-9f2c@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=joshua.crofts1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=syzbot+eaa106d192c9daf37f95@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox