The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: SJ Park <sj@kernel.org>
To: David Laight <david.laight.linux@gmail.com>
Cc: SJ Park <sj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	stable@vger.kernel.org, damon@lists.linux.dev,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/2] mm/damon/lru_sort: error out for >10000 active_mem_bp
Date: Mon,  3 Aug 2026 17:16:05 -0700	[thread overview]
Message-ID: <20260804001605.88417-1-sj@kernel.org> (raw)
In-Reply-To: <20260803155715.08868ca7@pumpkin>

On Mon, 3 Aug 2026 15:57:15 +0100 David Laight <david.laight.linux@gmail.com> wrote:

> On Mon,  3 Aug 2026 06:40:33 -0700
> SJ Park <sj@kernel.org> wrote:
[...]
> > --- a/mm/damon/lru_sort.c
> > +++ b/mm/damon/lru_sort.c
> > @@ -233,6 +233,8 @@ static int damon_lru_sort_add_quota_goals(struct damos *hot_scheme,
> >  
> >  	if (!active_mem_bp)
> >  		return 0;
> > +	if (10000 < active_mem_bp)
> 
> That is backwards...

I tend to prefer using only '<' or '<=' because it makes smaller thing comes
left.  But maybe I was overusing that here.  I think 'active_mem_bp > 10000'
should also reads well.  I will think more carefully for this, from the next
time.  Andrew already picked this up and he should be busy for next
merge window preparation.  Hence I'll not revision this for the minor change,
if you don't mind.


Thanks,
SJ

[...]

      reply	other threads:[~2026-08-04  0:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03 13:40 [PATCH 0/2] mm/damon: avoid division by zero from damos_quota_score() SJ Park
2026-08-03 13:40 ` [PATCH 1/2] samples/damon/mtier: error out for zero quota goal target values SJ Park
2026-08-03 13:40 ` [PATCH 2/2] mm/damon/lru_sort: error out for >10000 active_mem_bp SJ Park
2026-08-03 14:57   ` David Laight
2026-08-04  0:16     ` SJ Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260804001605.88417-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=david.laight.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox