From: Greg KH <gregkh@linuxfoundation.org>
To: Pedro Amorim <pedro.aml.dev@gmail.com>
Cc: pure.logic@nexus-software.ie, johan@kernel.org, elder@kernel.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: Align wrapped function parameter
Date: Tue, 4 Aug 2026 09:19:22 +0200 [thread overview]
Message-ID: <2026080404-paging-runt-f506@gregkh> (raw)
In-Reply-To: <20260803204743.335743-1-pedro.aml.dev@gmail.com>
On Mon, Aug 03, 2026 at 04:47:43PM -0400, Pedro Amorim wrote:
> Align the wrapped function parameter declaration with the
> kernel coding style to improve readability.
Ok, but:
>
> Signed-off-by: Pedro Amorim <pedro.aml.dev@gmail.com>
> ---
> drivers/staging/greybus/loopback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> index ea57b1f5d156..374ff4c4ca15 100644
> --- a/drivers/staging/greybus/loopback.c
> +++ b/drivers/staging/greybus/loopback.c
> @@ -589,7 +589,7 @@ static int gb_loopback_async_sink(struct gb_loopback *gb, u32 len)
> }
>
> static int gb_loopback_async_transfer_complete(
> - struct gb_loopback_async_operation *op_async)
> + struct gb_loopback_async_operation *op_async)
You didn't align it here :(
next prev parent reply other threads:[~2026-08-04 7:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 20:47 [PATCH] staging: greybus: Align wrapped function parameter Pedro Amorim
2026-08-04 7:19 ` Greg KH [this message]
2026-08-04 12:31 ` [PATCH v2] staging: greybus: fix checkpatch alignment warnings in loopback.c Pedro Amorim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026080404-paging-runt-f506@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=pedro.aml.dev@gmail.com \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox