From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD70D346A11 for ; Tue, 4 Aug 2026 04:27:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785817655; cv=none; b=QiW7RF8Zb3OVSchwrpOqr0BBY+e0P5j71jGGxlVCV1gU/5o4rHah4NqfYRsxOvel/PEAG7BvHC/1xJfMReMpDyuo0MTh8vtjV5MFuhUYgB2HWpkS2+3DBeW6oBNA2DDDSglsXZFdQPiTmTXOSdpckpHdngjaE1H8FL37Ry0qS34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785817655; c=relaxed/simple; bh=opHX033rfmO7a//8tZ3kVaD1IEXGm33r9foejSOn4Tc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UWCOiArpPs9hjm2RZyoCldtjXkY2gxzbJEKXukcXrmP89B6rtlkLaeJ7P0g4NGoqlFH2LESeJczibq2dKwxfv6/TPlt/4JdcnP6Zp3NssS31mUrjqB0qxLlQvW07s51BWbhibKL2TtR6waSeMYNv0+OpIqr/ie5YSK1Yw5eetgo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gphsZ2Hk; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=AHU+/wL7; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gphsZ2Hk"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="AHU+/wL7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785817652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p+Wrj+fEG23grALcs/D4e+T/chcmptdybXX8nN5bDvk=; b=gphsZ2HkT6CZ41KXOT0vTZy2FhZuMTtEMFnOqw8rR7XKBLDc/4U/g05pyH0vaabqOpSteQ /Gf5SzZL6+z3Im9N+5JFh/r0//zYu97ruHfCJdtbk0KeEu8TaUQ0Stp/CMQG2w/k9d92n0 or7ovJ92OxMRd1sdLVVLfudtiIe5sNE= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-H57AL0FaNISLLHJHyeJmJA-1; Tue, 04 Aug 2026 00:27:26 -0400 X-MC-Unique: H57AL0FaNISLLHJHyeJmJA-1 X-Mimecast-MFC-AGG-ID: H57AL0FaNISLLHJHyeJmJA_1785817645 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-39c82feaaa3so2176971fa.0 for ; Mon, 03 Aug 2026 21:27:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785817645; x=1786422445; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=p+Wrj+fEG23grALcs/D4e+T/chcmptdybXX8nN5bDvk=; b=AHU+/wL7SFZZdRMmu+q6CQTXZVveOIiEMUqirp2NziIQTKoJczIJQmFt6ENDkak5zV CDziBnXatcBlMaRVmPD+3uTR1yCTrkOy0eOnvbCEe9Zb18XRN4ErC/uj0ZFrYgjxwwmF qFUw+JU9y4Bf9SrrDu9a5iDPHeak527y56bn1SEBHBZOrksvLbL26DthFeSAyxbCSTJW u9UxZE5x8y0+WRu92eWTRbDZy5EShVXcpn8lVpM9SgUAxE7wYTvZ44IrATtLaYgtTwoi hpEwXq6x06P4nq2+nZ08twJg67KW9HnYFxKHfH1rDx9pKdL4jPRlhz6bkXJ33qFOUJlq fEqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785817645; x=1786422445; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=p+Wrj+fEG23grALcs/D4e+T/chcmptdybXX8nN5bDvk=; b=FbnolZ1aY2WeY1aRwqMHZ7Yf0Wyz0HujOsCHJSiUCWO8vjmWz76HmDOD5nEoA2Nsfa jMSVjQFiPn6u4qFaT9ZzAN/VazYyJWuqTbr4Ub2LWPOUBC/UlFhA6JjuzbGv33KERE+w t+Vu3We0eNKNoBQtY1bgAIw0swPCC6jgD1JFfRwMd1fMkDLYj2wAifh/hZz3wYGAZuhN PgZ/jp1K+N9xhrvdvkREVqUtVp8AcxJhXMbn1WOgjVp2GcTHf/yCn6i2xAZWtU9aiITV 7DGV+MFju2n3USAWSVRjChbotwtCIrUO3GDTdkZ+HnWHnZeRBPOh4PtMzqeHlzl8Awl8 fzOg== X-Forwarded-Encrypted: i=1; AHgh+RpRjO/VuzLlx3jjZ/lAi9CMYClw7S6smk/aW+hCQYVQVJkyWdFIf7wSGnZP+ZddQBttDlXQTsBFkMV10Rk=@vger.kernel.org X-Gm-Message-State: AOJu0YziwKq7ns5n45o0csWUZ+fof46XxUyKtrpPwtTgONvLd87DgN2H zTYmxRhmspK+Vdm+Ne0jUXQzIhZnWZq+amzlCZuT4DS52j1QJpp5ZVtZM6y35sxYszYaa6uj0Z4 KSQa0iyWnvAGugso9CbA8WUAPS5okw7KrJZNMLOPfw4V1Hwd26J6GCjrOU0pGs+On6kj7hwrKH8 A= X-Gm-Gg: AR+sD12/A6sOAI//teF7Yd0VMTO7bP/LQqhmBbqSBPFFQnDpKJbgO1hxVn/yTuUJXvG 3NVW39Gt93Q1BNfbRAGNg8H0QO3etDu1QXjGeSN+uftMT6pwplFO17ALM+qpgTmANIA6rLIAa+a ioTVAaXDGKPwMPWvHx0tbsqp3INcvYvd0seSCuHoypcJqFhZB/BHRkVGuod5uA2ybOy30WPS7uf 9z5td2UKSoLD5T0okenamHcf+5SjNe6Q/iVJHlCGmOMtGvLdCQPdmjiUGuVV+UtQ1lSqoC1ZV6c sGaH0Q9UxrTujqEo4YuA3igsWnCtyZBDNRdmBT1La+mWRhsaHthKfzoU6sSiRUZUtna20hdGo2g 6+XtiHlox/TFAOdMo X-Received: by 2002:a05:6512:400a:b0:5b2:aa73:ea5c with SMTP id 2adb3069b0e04-5b2f282e27cmr151466e87.20.1785817644602; Mon, 03 Aug 2026 21:27:24 -0700 (PDT) X-Received: by 2002:a05:6512:400a:b0:5b2:aa73:ea5c with SMTP id 2adb3069b0e04-5b2f282e27cmr151455e87.20.1785817644120; Mon, 03 Aug 2026 21:27:24 -0700 (PDT) Received: from fedora (85-23-51-1.bb.dnainternet.fi. [85.23.51.1]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2e23c46c4sm2311351e87.17.2026.08.03.21.27.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 21:27:22 -0700 (PDT) From: mpenttil@redhat.com To: linux-mm@kvack.org Cc: dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Mika=20Penttil=C3=A4?= , David Hildenbrand , Jason Gunthorpe , Leon Romanovsky , Alistair Popple , Balbir Singh , Zi Yan , Matthew Brost , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko Subject: [PATCH v13 07/11] mm/hmm: migrate collection in HMM pagewalk - pmd level Date: Tue, 4 Aug 2026 07:26:27 +0300 Message-ID: <20260804042631.2175585-8-mpenttil@redhat.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260804042631.2175585-1-mpenttil@redhat.com> References: <20260804042631.2175585-1-mpenttil@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Mika Penttilä Implement the needed hmm_vma_handle_migrate_prepare_pmd() function which is mostly carried over from migrate_device.c's migrate_vma_collect_huge_pmd() function. With HMM pagewalk based migration, the idea is that hmm_vma_handle_*() are responsible for faulting, and the pfn collecting part. hmm_vma_handle_migrate_prepare*() do the migration decisions (with HMM_PFN_MIGRATE), possibly split folios, and insert migration ptes/pmds. HMM pagewalk based migration is enabled in later commit, for now now hmm_select_migrate() returns 0. Cc: David Hildenbrand Cc: Jason Gunthorpe Cc: Leon Romanovsky Cc: Alistair Popple Cc: Balbir Singh Cc: Zi Yan Cc: Matthew Brost Suggested-by: Alistair Popple Signed-off-by: Mika Penttilä --- mm/hmm.c | 96 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 94 insertions(+), 2 deletions(-) diff --git a/mm/hmm.c b/mm/hmm.c index 2d902b8bcd58..61b9147fd8ed 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -549,8 +549,100 @@ static int hmm_vma_handle_migrate_prepare_pmd(const struct mm_walk *walk, unsigned long end, unsigned long *hmm_pfn) { - // TODO: implement migration entry insertion - return 0; + struct hmm_vma_walk *hmm_vma_walk = walk->private; + struct hmm_range *range = hmm_vma_walk->range; + struct migrate_vma *migrate = range->migrate; + struct folio *fault_folio = NULL; + enum migrate_vma_info minfo; + struct folio *folio; + unsigned long i; + int r = 0; + + // Do we want to migrate at all? + minfo = hmm_select_migrate(range); + if (!minfo) + return r; + + WARN_ON_ONCE(!migrate); + HMM_ASSERT_PMD_LOCKED(hmm_vma_walk, true); + + fault_folio = migrate->fault_page ? + page_folio(migrate->fault_page) : NULL; + + if (pmd_none(*pmdp)) + return hmm_pfns_fill(start, end, hmm_vma_walk, 0); + + if (!(hmm_pfn[0] & HMM_PFN_VALID)) + goto out; + + if (pmd_trans_huge(*pmdp)) { + if (!(minfo & MIGRATE_VMA_SELECT_SYSTEM)) + goto out; + + folio = pmd_folio(*pmdp); + if (is_huge_zero_folio(folio)) + return hmm_pfns_fill(start, end, hmm_vma_walk, 0); + + } else if (!pmd_present(*pmdp)) { + const softleaf_t entry = softleaf_from_pmd(*pmdp); + + if (!softleaf_is_device_private(entry)) + goto out; + + if (!(minfo & MIGRATE_VMA_SELECT_DEVICE_PRIVATE)) + goto out; + + folio = softleaf_to_folio(entry); + if (folio->pgmap->owner != migrate->pgmap_owner) + goto out; + } else { + hmm_vma_walk->last = start; + return -EBUSY; + } + + folio_get(folio); + + if (folio != fault_folio && unlikely(!folio_trylock(folio))) { + folio_put(folio); + hmm_pfns_fill(start, end, hmm_vma_walk, HMM_PFN_ERROR); + return 0; + } + + if (thp_migration_supported() && + (migrate->flags & MIGRATE_VMA_SELECT_COMPOUND) && + (IS_ALIGNED(start, HPAGE_PMD_SIZE) && + IS_ALIGNED(end, HPAGE_PMD_SIZE))) { + struct page_vma_mapped_walk pvmw = { + .ptl = hmm_vma_walk->ptl, + .address = start, + .pmd = pmdp, + .vma = walk->vma, + }; + + hmm_pfn[0] |= HMM_PFN_MIGRATE | HMM_PFN_COMPOUND; + + r = set_pmd_migration_entry(&pvmw, folio_page(folio, 0)); + if (r) { + hmm_pfn[0] &= ~(HMM_PFN_MIGRATE | HMM_PFN_COMPOUND); + r = -ENOENT; // fallback + goto unlock_out; + } + for (i = 1, start += PAGE_SIZE; start < end; start += PAGE_SIZE, i++) + hmm_pfn[i] &= HMM_PFN_INOUT_FLAGS; + + } else { + r = -ENOENT; // fallback + goto unlock_out; + } + +out: + return r; + +unlock_out: + if (folio != fault_folio) + folio_unlock(folio); + folio_put(folio); + goto out; } /* -- 2.55.0