From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DEF523395C for ; Tue, 4 Aug 2026 04:53:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785819218; cv=none; b=SeuhRdN5dCkb8raHwbvamCmWqLxLwPCBJIdfbnRD9maik7fSUPukDjGqewVE9YRzT3+5gSGItjtftKh3Ho5GLyChpWToKpDNCMxSX/b29hDyylJBvvOuPwk49OAWGyHSDReOvpjCylCapJGBwdJlmgoQKnrcMRp35yho1z9//VY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785819218; c=relaxed/simple; bh=nNrXpTS5p3MeaHobweXT5nADo9ur62gwlp1t4Onq0Jc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hxRJrmRcuy4RfKW1w8q7eb89hx6GxagwRgCoEEhI+hRuNtJViq8QqYITDYSXyilR4EF6G2kuHkqOPh5kI+fHbKE0teG7IbU4n5orMkTfTHzlyNZcAHKAyakB/RPTB8hB64baELTyRhjk2EnXC742//IlDx8LEST6NxsPSVOXQOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N/u4ikFp; arc=none smtp.client-ip=209.85.210.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N/u4ikFp" Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-7eb62dbe747so191381a34.2 for ; Mon, 03 Aug 2026 21:53:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785819215; x=1786424015; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ePP/FGrYS9KwAO8eWsNAP5nnVVIQOzeomHwBJLzdcl0=; b=N/u4ikFpw9hMmYa/VlrF2Wb4szgW8bEccUZ7e9U9yejQtrkkNaGC8VtrNzqtCruZuc QyFP0rU5Wjc8RdGKHxzQzjkloKYZMQ92VVy/Kg5ZjAiQmN2zuWZcCcbKTMLS3D9DcKcW rFc4Y7w6BY1H5yUKKP2a3Gj27hagFZ4iiVlIqlFFt9Xj9bJ6cbAA6ZfpkSbuJ5h1coe1 +sQPYyvGXHuWj58SUlALAxs6GrBZTqZbPQItOLzS4CDHY3306Yv8sQftVrt82MfWJkrT XLExprCO2t6QjmYudnrFrlNykN9I8lXrUjseGRaPBGg5vFEq25YZTqMyVQapc5fL76Wm FHGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785819215; x=1786424015; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ePP/FGrYS9KwAO8eWsNAP5nnVVIQOzeomHwBJLzdcl0=; b=cYzccY75I1HQqIxik5LyEDsNL1uh+5RSIcekXcCEw+D06MndiHUEfnYFy9D5nHMd0P +jVFOj0tenSgy3o1isbBcMp7jbkEX6pAFGmfcAPedpdcsUDyH1sOck9sjgzlXPgLTgXw noViwA1KZcnHAGZ6NYoPZwwh4U8lEBEbqd0WcFb0Vr7+H1gt4nlUwB+gKkkMKdK0F+Wb MDC5l49kSlghAO573Z/nARitQgYywQX2ZDByPRYiSkzTg+BNSdgFsVhZjlvav2i5ZvT2 utuzUb1SpQT4kwUZt9oIQgFdMaUS68DvCdn57kHvd/zBmnWZ/DKzKWjOyhsWQpel3FHH Kb/A== X-Forwarded-Encrypted: i=1; AHgh+RqJouPifIpk0VMT9h4zno2D/rZ34W8VkPzffsYjz0VExH5BZwrr4AYGHJvGTHoBj7zLvPuxfpOnaTMxWss=@vger.kernel.org X-Gm-Message-State: AOJu0YwEncZN5OTfXdPrv8elSgbHxVKiiQbr8KmCX8s0ZJIDN6Be0DVN /g5rJ8nFMJ2Hkkc/0NJXTnsi4CcS2UNKfba3u058+beRjmXPREbx5vQZThHsGA== X-Gm-Gg: AR+sD100t1hwTuIRu6n6jEbntJSebHVEyoz/8Y3DnqhykI3LYslVcmxTYK07HEbwZhF y6ohDnQKFyf8xRTDd+6t2y588g2gt9s18AORNv5kgGD+ZqZ5EXkuZ8J+EQTKYC08UkyxMO9hyQA xlQDenJaj3JPa0oOn/512yJUsH4u/M1bJS1B7DNDUUK4RnTFjWYk8ee8ggp2uc9iOE7/xIuaSym Cfl13dsSp1lMg95wP1nKeWabt8fmoY2OrOctipA4y6y8WHlR0VXq719o+s0RfFvWM6zOuGDlZJi HGwj7l+uSj41reQ/PI47rFBsSEowvu54OZa45ScmE/TplhnNuBjsZlJUCw2IHHdErDl8YId6y3R t77HpSymwogFEWLMC8axf278rDYBIdnT0xG61tF+BV3xCl8RACSVNyXYzh3Sd3x9/evIpsfnrGV QPBB+i4ifFxaA6dTh5KYN923JwcGBTIUJ8m+g5s1tzMdr/QxwRTkliOmUOW+sqvrj5wOZl/hN0N 7XwCesZ1FuAnpOm5rwaat9PY88pE6m9DF0SatYsvhr/jZILnB/lDJseZaBqy0Q= X-Received: by 2002:a05:6830:6a93:b0:7e9:e16c:d3d1 with SMTP id 46e09a7af769-7f196ef5898mr12750388a34.2.1785819215381; Mon, 03 Aug 2026 21:53:35 -0700 (PDT) Received: from antares ([149.88.25.215]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7f18ed3e926sm9058333a34.1.2026.08.03.21.53.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 21:53:34 -0700 (PDT) From: Bogdan Nicolae To: Arend van Spriel Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v3] wifi: brcmfmac: cyw: pass PMKID to firmware if present Date: Mon, 3 Aug 2026 23:47:08 -0500 Message-ID: <20260804044708.402133-1-bogdan.nicolae@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Zero out auth_status on initialization. Otherwise, garbage will leak from the stack to the firmware (when ssid is less than 32 bytes and/or when params->pmkid is set). Then, pass the params->pmkid to the firmware (without it, the firmware caches a garbage PMKID on successful authentication and denies a subsequent association request that includes the PMKID). Fixes: 66f909308a7c ("wifi: brcmfmac: cyw: support external SAE authentication in station mode") Cc: stable@vger.kernel.org Signed-off-by: Bogdan Nicolae Acked-by: Arend van Spriel --- v3: Added Fixes, Cc: stable, and Acked-by tags v2: Split into a separate patch drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c index 873754be5..2c59b5e57 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c @@ -200,7 +200,7 @@ brcmf_cyw_external_auth(struct wiphy *wiphy, struct net_device *dev, { struct brcmf_if *ifp; struct brcmf_pub *drvr; - struct brcmf_auth_req_status_le auth_status; + struct brcmf_auth_req_status_le auth_status = {}; int ret = 0; brcmf_dbg(TRACE, "Enter\n"); @@ -208,6 +208,8 @@ brcmf_cyw_external_auth(struct wiphy *wiphy, struct net_device *dev, ifp = netdev_priv(dev); drvr = ifp->drvr; if (params->status == WLAN_STATUS_SUCCESS) { + if (params->pmkid) + memcpy(auth_status.pmkid, params->pmkid, WLAN_PMKID_LEN); auth_status.flags = cpu_to_le16(BRCMF_EXTAUTH_SUCCESS); } else { bphy_err(drvr, "External authentication failed: status=%d\n", -- 2.55.0