From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF8B3419FBD for ; Tue, 4 Aug 2026 06:12:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785823952; cv=none; b=Kp0ItEsinOvxSYMBQshcTqiFE0ftNwTjCUEhFCGL+o+XurhwXTL8g3IXuFA0rpS2VQo/a7DC/c/fRafWS7uhO2OzVjL50VN4FUPLvQCvKHEvTbjHfZQqsJBCGyN/5DyJtUnx47DgX1CTgh626O0ds6ONuAU1e6QXjD2mwiDTD1A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785823952; c=relaxed/simple; bh=K5Ph9XcyqOYkIasx02lR7AFxCwUH0dmM/cCvoQIHRKk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=k+1pN0Y0S0zJ8Dr7TrUzgne2YNMJhSDc42l185IspqyQK+/71T12o4e05w3XvRmIVmTDVlR+7HAogsF1fnC/fyebRQxxyYy9qdUNvizO0ZOeOwboB5x1hL3Cq4IqZzHkTfZ309qkq3r1xAmN+TlPF26d6wX38j6bay3WFaDckY0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gT4p7sUZ; arc=none smtp.client-ip=209.85.210.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gT4p7sUZ" Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-7ee4f586632so409997a34.0 for ; Mon, 03 Aug 2026 23:12:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785823950; x=1786428750; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=lLnrl7cvfXhXnP0TWy+i62c7ISWemwc6cOZstir8oEI=; b=gT4p7sUZvuSsh9OotrRHNVX2EjaglX+SdQVFp0IVMq6A0q4T0j0ZrMrHSYg425g4MG Z2qAERqDZMbFvk4TFCCuIC4Tk8x13jp8iZPAbsQPy0tvdhtszjgWHBS8hz6Od3e56V4R wB17X5EpOPF4pcl10QmBK3VVUgfWZS6M4YJe+k5gRSUHUA4gxUVj9xB5XvAi8Os1n002 ClfygzJmaG5heyKftdIqQWqWSfaoPprNx8+fHLLgPZ7Z3SqrSOqLpa6poZhLs5pkXDP3 ULPUHfXJfck02dQ9UfeJUtPmk+A0NO80uFc50ywPevTrODBwGvtapeWeRKBHfk0IsDjv 6kxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785823950; x=1786428750; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lLnrl7cvfXhXnP0TWy+i62c7ISWemwc6cOZstir8oEI=; b=KklJU2VR5pzMhU9sFQWz3j3lb9DQpcrd6UdT/fUBoWSr6DSx3oVnXmipvb8QrI3/Jo xuEaxQdCPVhkiL8xZnyxxwgj2ttbVOMEH/QFD4BxBDs7tk1vP7ux8cFusyp6Nf4xfe1w hsas7GUAiHkO9u3cNTtbaeJ7quQCCAGRtlxArZ5tkUNnUXOiCB+Xg5Gr3w+Gk0btfeaQ Y9/IIbdEAXw5Ak4EU8APdc5Djs6XhUty64MGAm8voTv/i9R+l/XYWJh4FQ8bF4p51Vx9 lZ03m31qGws9YaHdpiDHFKmmLa/FQYO1m0xcgAr+S7dOL4Y11EEm2CxDXZGUfilMPJeO 7IPA== X-Forwarded-Encrypted: i=1; AHgh+RqqemANLuwhkIYkqBMYc3NDDLbB+aFutyp/nCLum9EcxEsawEm5Azntn9jDNq+es2aCznxG3KWYdguEM+A=@vger.kernel.org X-Gm-Message-State: AOJu0YzT0bK2jcdvYsD3UYqE1mauFr9sEBPT9C9dwWnxcIOr0gn4ZHJH XFf7Ua0M4OquJ1N7RIWwDh39DgK8bloAcIP+y+GKCM1JtZOXjnwUy2gq X-Gm-Gg: AR+sD12UMCkt5C9lYX6713pdhZYHX7fLGwVg5YiOtIK5n28Wei1TIzIGZyatYac0TM+ JRbVq2q2O1apyGjdSpt2ZMB8rrHD8JBRfuRLVnRNmTeuIEsTOo13IwDIrylJRH/FgIqe3cQx70A qSvynpgqYWm2AIKYBf84BRXMI1b7XyXCXdBNehTC/6jrUz9U4H5aTgwtF8j9QjDkfsArq8ky+I6 7ruYjRkudEP/wlvu+yiaFRti78Iai9rNSrltxPH1c1CvRAg6i2qG4STrUG8xvNCD6p8fF+OtiV1 0jk1fcSLvyJM7Lwt2oH8+2puKKqrUVGOWJ3sVD030UbQe0wFQs3ABvMWuSRRsptJLy/pzT38STb fNfhp7ZwV54+AvgvOiom3+16XQjK+QRhS7msfMAtHqXc7JwRRgrTP7fcJmZhqj4OIuJDVqJ+nMv qyPaAkb1TdZRS+mWu38FyjrPOfBivOQcPIDqerDk4JqvR+aTeSTBMdyk52HN7lrto96DzqvQBMd hl3UlwR2rLM84rwzfBF4FPBvvu6i/CH71lCeRPuZ9yliSYPn7azlBY7OQqnd+c= X-Received: by 2002:a05:6808:1387:b0:495:ac16:7afa with SMTP id 5614622812f47-4af5e3740eamr13419377b6e.4.1785823949634; Mon, 03 Aug 2026 23:12:29 -0700 (PDT) Received: from antares ([149.88.25.215]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4af58d11372sm7918032b6e.7.2026.08.03.23.12.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 23:12:27 -0700 (PDT) From: Bogdan Nicolae To: Arend van Spriel Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v4] wifi: brcmfmac: cyw: pass PMKID to firmware if present Date: Tue, 4 Aug 2026 01:08:59 -0500 Message-ID: <20260804060859.412348-1-bogdan.nicolae@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Zero out auth_status on initialization. Otherwise, garbage will leak from the stack to the firmware (when ssid is less than 32 bytes and/or when params->pmkid is set). Then, pass the params->pmkid to the firmware (without it, the firmware caches a garbage PMKID on successful authentication and denies a subsequent association request that includes the PMKID). Fixes: 66f909308a7c ("wifi: brcmfmac: cyw: support external SAE authentication in station mode") Signed-off-by: Bogdan Nicolae Acked-by: Arend van Spriel --- v4: Fixed indentation v3: Added Fixes, Cc: stable, and Acked-by tags v2: Split into a separate patch drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c index 873754be5..2c59b5e57 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c @@ -200,7 +200,7 @@ brcmf_cyw_external_auth(struct wiphy *wiphy, struct net_device *dev, { struct brcmf_if *ifp; struct brcmf_pub *drvr; - struct brcmf_auth_req_status_le auth_status; + struct brcmf_auth_req_status_le auth_status = {}; int ret = 0; brcmf_dbg(TRACE, "Enter\n"); @@ -208,6 +208,8 @@ brcmf_cyw_external_auth(struct wiphy *wiphy, struct net_device *dev, ifp = netdev_priv(dev); drvr = ifp->drvr; if (params->status == WLAN_STATUS_SUCCESS) { + if (params->pmkid) + memcpy(auth_status.pmkid, params->pmkid, WLAN_PMKID_LEN); auth_status.flags = cpu_to_le16(BRCMF_EXTAUTH_SUCCESS); } else { bphy_err(drvr, "External authentication failed: status=%d\n", -- 2.55.0