From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80E5B46A5E8 for ; Tue, 4 Aug 2026 13:52:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785851568; cv=none; b=kLebA1gOgEw0lCKK9AKZLJJJwpcI0QkOxmG+zGfPG/IUE9JtlV7D+SogFgxTuqPy8eA575SvYD07dCetSId2ai8uP6sT8HUO7x3Qbeo63poihxBuHn8rqdowEAYl7F2S92sKqmOgKlKbKkEnmX3uAnvseAcwxjXg2UTTNlc0gh0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785851568; c=relaxed/simple; bh=ych81Sk1AoLZhHC3tJyhITgRXh9uIJo2FFDZgQNhlZc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ipEsmFC1aNL0gTR8Nc7+TcuVJLavEZM/nxM4j1x9hBuBjycbUPP0ujM9U8bWpDQxWmyBB1T7mY5U5IOSWAk5Xnq0PMgbakOW/VWhW8KXiVnv68J3yz0lm5n2wDPV+XIng9gdrZZ/S5ukAuK6916k6HFbB6RijE9lYz89uqUpQRU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=onLSANnJ; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="onLSANnJ" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-38759bcd877so4287043a91.2 for ; Tue, 04 Aug 2026 06:52:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785851566; x=1786456366; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=L/e4D+s9Hhji7feemrfPyi/FIF11qn7GdPSy3sXtOIU=; b=onLSANnJoiYKTyRZqz+G/74jaS2FoJI14D/yV5i3F7kT95V/fmRhwCEa1Opn7BV98o 2QL5pnlbz4nR7kUMRM9IlAvVVw4mlcmbX0jcQizPKLmKC+v3Y1bRAyNwmDO+bK2ZOfL2 dvm+bm1Z20v12mr4LBK65ZXCNzGwYW+BRLsYCDzOzNHi5NRr47bLjV/dXjSBef8zafjR a9tzPb1EE3VlzgiAsdiA8W/7NAreznB57rbjdE6yZ5pz9d+3EFWI98LLHhc6dReaCqWd W7lF/O8twh9UH0cNmrhtPH0WiRs4QFAj6tHN38GCD2METRB/N1n5vrJNAOESAnElmhHQ bk7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785851566; x=1786456366; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=L/e4D+s9Hhji7feemrfPyi/FIF11qn7GdPSy3sXtOIU=; b=LR6vKZW+vC/r13M4MZHYCGLe81vGWIDc7oEIN3QZL3by/v5N+2FaD+6NgtUqQAzQ++ wUQq9xZCNVSFeUVhZyQ98kYmR/5zFoL4Yf6uMz4w2WnjY6KJX7ZQfbBsVVhCAwIpKsZP 6MkPs3wABMwYiu8p9KntnpVkbZTmNl6ubKGFTohKfRV7eYIqETgjWdn8fxKOec9vQhtz dVNxoFHgx6sZLgqrqzR5BF6oUXquAcjsKuf0M4+cZC/ydztpPFiwERhSxFWFMELZG2nY GwuwQTGJ+YwROZgXN099Ru9MiJZWYXQU8nJjmqYSOk6Z2SVnexZhuwri0OPu7uJAYEWJ 6r2g== X-Forwarded-Encrypted: i=1; AHgh+Rphp7L6xAcFVYIMS8iWChLPldNSEf1SXI3gDFWK/lyQTBnx5AubIyly3EAPeJ2PSam6vctbF2gmjBtM0Qo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0njIWpCeUlZqfMu9zmjGATX9w3GI3oQ6Tt7/C64ZeW+nqDAkf iQaLXC/Qk+3F0rBvLJoubzW2tZAbl8i6wwuDxefgeBv9xFFY0b1oXjs4 X-Gm-Gg: AR+sD11FVF5OEWTMrpuKZ2Ywa9M25apqKXzM82+OwBoD6KjGCSlkoA+Qrt5Q/5RjmW6 MujtAXLaUXR7T8q2K96fvtCxcT4GQbEouIf8Zz5i6BPjDhayasI4UT5TB6Q0Weqm94Af9HNTQdr l5Br0pPSfxqp6XjFyWxrxCKuVuycMMpKUwr+ktPbkFk6v3zAZir7hmakWW+Cnx+PVaOFuyj5Lr6 vQwVLX8vcl9w5BjpQcYEuukoiT6hQjwFa4L2lrQeJkADzwBHmgnPRaBjr0OaTF35c4HlBFW8MF+ ZACrQRVtXXpLsF1eXMxtiNWidDqOR3mg506QUfbFiFIvlVnckd+/P4AzeaNRKH0pHIqQFEGO6VN 2dODTT4SjlZvKgbho28sxniDNpvJL6K3XcQHYoSJdprkpXsjoOdkuVlwaX43jhBm8Ag6pQuoUMV fp8fPowJgZCK3ygwBjfk42SbHIi/FMdKbSH9AnIo6mldo9NKqK/LLFuFhYAQsuMYbjPOwVCLJi X-Received: by 2002:a05:6a20:244d:b0:3c3:a9e1:a819 with SMTP id adf61e73a8af0-3c92a5e161emr15499625637.24.1785851565307; Tue, 04 Aug 2026 06:52:45 -0700 (PDT) Received: from localhost.localdomain ([147.136.157.3]) by smtp.googlemail.com with ESMTPSA id 5a478bee46e88-315863b0a9csm7551268eec.2.2026.08.04.06.52.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 06:52:44 -0700 (PDT) From: phind.uet@gmail.com To: Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andy King , George Zhang , Dmitry Torokhov Cc: Nguyen Dinh Phi , syzbot+1b2c9c4a0f8708082678@syzkaller.appspotmail.com, Michal Luczaj , Wupeng Ma , virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4] vsock: use sock_error() to consume sk_err after a failed connect Date: Tue, 4 Aug 2026 21:52:36 +0800 Message-ID: <20260804135238.386417-1-phind.uet@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Nguyen Dinh Phi Syzbot reported an issue which can be reproduced with these steps: r0 = socket(AF_VSOCK, SOCK_STREAM, 0) bind(r0, {VMADDR_CID_ANY, PORT}) connect(r0, {VMADDR_CID_LOCAL, PORT}) -> -1, EPROTO (self-connect) listen(r0, backlog) -> 0 r1 = socket(AF_VSOCK, SOCK_STREAM, 0) connect(r1, {VMADDR_CID_LOCAL, PORT}) -> 0 accept(r0) -> -1, EPROTO (stale sk_err) Basically, it creates a socket (r0) and triggers a self-connect after binding it. This self-connect fails with EPROTO because it loops back to r0 while the socket is still in the TCP_SYN_SENT state, causing it to be incorrectly dispatched to the connecting-client path. The unexpected packet type encountered there sets sk_err to EPROTO. After that, it invokes a listen() call on the same socket. This listen() call succeeds because the kernel's listening path never inspects or clears sk_err. Then, a new socket (r1) is created as a normal client and connects to r0. However, vsock_accept() rejects this incoming connection because the listener's sk_err still holds the EPROTO error from the earlier failed self-connect. This rejection causes the child socket created for r1's connection to never be freed on virtio or hyperv transports; only the VMCI transport implements pending_work to revisit and clean up a rejected socket. Fix the issue in blocking connect() by using sock_error() to read the sk_err to prevent the rejection branch from occurring in this scenario. sock_error() atomically reads and clears sk_err, ensuring the error is consumed when vsock_connect() returns and cannot affect subsequent operations on the same socket. This matches the established pattern used by other protocol connect() implementations in the network stack like __inet_stream_connect(), tipc_wait_for_connect()... For non-blocking connection, vsock_connect_timeout() may set sk->sk_err after vsock_connect() has returned. To handle it, we also remove the sk_err checks from vsock_accept(). Nothing in vsock sets sk_err on a listening socket, so accept() has no reason to inspect it at all. Reported-by: syzbot+1b2c9c4a0f8708082678@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=1b2c9c4a0f8708082678 Fixes: d021c344051af ("VSOCK: Introduce VM Sockets") Suggested-by: Michal Luczaj Signed-off-by: Nguyen Dinh Phi Tested-by: Wupeng Ma --- V2: Add reproducer steps to commit message. V3: Fix truncated title and add annotations to reproducer steps. V4: Remove sk_err checks from vsock_accept() net/vmw_vsock/af_vsock.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index 622dbd046799..594fe27d2ebe 100644 --- a/net/vmw_vsock/af_vsock.c +++ b/net/vmw_vsock/af_vsock.c @@ -1847,12 +1847,10 @@ static int vsock_connect(struct socket *sock, struct sockaddr_unsized *addr, prepare_to_wait(sk_sleep(sk), &wait, TASK_INTERRUPTIBLE); } - if (sk->sk_err) { - err = -sk->sk_err; + err = sock_error(sk); + if (err) { sk->sk_state = TCP_CLOSE; sock->state = SS_UNCONNECTED; - } else { - err = 0; } out_wait: @@ -1893,7 +1891,7 @@ static int vsock_accept(struct socket *sock, struct socket *newsock, timeout = sock_rcvtimeo(listener, arg->flags & O_NONBLOCK); while ((connected = vsock_dequeue_accept(listener)) == NULL && - listener->sk_err == 0 && timeout != 0) { + timeout != 0) { prepare_to_wait(sk_sleep(listener), &wait, TASK_INTERRUPTIBLE); release_sock(listener); timeout = schedule_timeout(timeout); @@ -1906,11 +1904,8 @@ static int vsock_accept(struct socket *sock, struct socket *newsock, } } - if (listener->sk_err) { - err = -listener->sk_err; - } else if (!connected) { + if (!connected) err = -EAGAIN; - } if (connected) { sk_acceptq_removed(listener); -- 2.43.0