From: Christoph Hellwig <hch@lst.de>
To: Tal Zussman <tz2294@columbia.edu>
Cc: Jens Axboe <axboe@kernel.dk>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Luis Chamberlain <mcgrof@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH 2/2] block: take i_rwsem for the direct I/O write fallback
Date: Tue, 4 Aug 2026 16:04:45 +0200 [thread overview]
Message-ID: <20260804140445.GB8894@lst.de> (raw)
In-Reply-To: <d30b6c9f-e479-4cca-8dfa-576d7562d2fc@columbia.edu>
On Sun, Aug 02, 2026 at 08:11:41PM +0300, Tal Zussman wrote:
> > } else {
> > /*
> > * Take i_rwsem and invalidate_lock to avoid racing with
> >
>
> I seem to have stumbled into a Sashiko rabbit hole of issues with IOCB_NOWAIT
> and IOCB_ATOMIC here... [1].
> I'll wait a day or two and send an update along with some additional fixes
> I've spotted.
I think IOCB_ATOMIC vs fallback to buffered I/O is a generally
unsolved issue. I know ext4 just has a warning, but I'm not
sure how to avoid creating the problem in the first place.
prev parent reply other threads:[~2026-08-04 14:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-02 11:14 [PATCH 0/2] block device write path fixes Tal Zussman
2026-08-02 11:14 ` [PATCH 1/2] block: use iomap_dirty_folio for block devices Tal Zussman
2026-08-04 14:01 ` Christoph Hellwig
2026-08-05 22:44 ` Tal Zussman
2026-08-02 11:14 ` [PATCH 2/2] block: take i_rwsem for the direct I/O write fallback Tal Zussman
2026-08-02 17:11 ` Tal Zussman
2026-08-04 14:04 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804140445.GB8894@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=djwong@kernel.org \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=tz2294@columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox