From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D08153EFD31 for ; Tue, 4 Aug 2026 14:29:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785853792; cv=none; b=MIQIdAls8GKD/1j4m/baB5XC5ZZQ7GlQieq4LzaaxqAAy7O4GdLYtPhtNE6qCYNgzCBLa22E/oiDQlsBAQEXlIDpWRx2fsiT1ihnJnGI9wIUCZ6e89vOvPCg9nYox+YpUrDXehyWSGveD5CeB5xGkmm1Y4/Mr6u0I8To+BHlrDg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785853792; c=relaxed/simple; bh=zwJDS5M7XSOayNbUeGw1KSlciFCw5PkPyvSmQWis6hU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fhgrOO/MRLTcRomBqBN7IR4/NdWDWZJqDokE6msw7rf2nVA/9wUShkFqF/p9cmYQTEQxkYtvrGgy8YvS/nYfSQdtTayhTWoO9JqjYli710Ysg9B3qM8jqHE1qTK7tGcbX2z1gLPrXIe6Onv6Ubv5cfJY8frSiWMGpQ+H1YoTsM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G5Z+toO8; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G5Z+toO8" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5b0117d49dcso5307960e87.3 for ; Tue, 04 Aug 2026 07:29:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785853762; x=1786458562; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=GDaBxGiFHqp5j125thlzpnjgXp8EFo5LBnP6F1rvvfM=; b=G5Z+toO8dbtFYNriGcx+E4jP6CQKpyKGO32JVG4JqCZamhxRtAAElH+x0LZik0UAX/ OTDm1w/1v7jUK1Gc/B3LczLU5NWGaUupdLLgGLO/RLsYPzs07ON0dYW1ch98gzQ1UKJS /3VOvOxkorvg5ZCh5jwRjZGirVbu8MFIGG6HZX16UKBeqRSzeM38eObMF+IzPDvxRanM aUuBTk2xVhYM1KFEM140R9pSOHNvAe6rPQs65n3ddPbxOy1HQeRDA16MKYlAcKP3Gpq8 4fCj9G089TPjVYXd2jKRuSd8LV9ctbB6dRpq3GXlFDCJrUSRU5UHpSc/QFt9ASTnZo2a OHJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785853762; x=1786458562; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GDaBxGiFHqp5j125thlzpnjgXp8EFo5LBnP6F1rvvfM=; b=nbjF4UoqJ8Ywwvuq7e+wgYpe67oeVxdCx/G7dXNG78eNPKr1UVLSxPNGeLHzKkhN4e o26HA6zRbKi+RwkQasFU5y4Q+yROBi8EjDT8euL+8128qa8MZV32whVLrsDFe69YeFdk i/XQa/gYtRigodZxJTXnYY0sq2ingz/nLg8whZHL7DKq8gshRK6tE1Yt/Dle2ENQKOaA H4Vn1qdoAXfakOcl43a6uw3uuHVo7x2fiuFiSMEdXP5QGBetTgFumdIV7rKoIuVhJstS QxTPSsSihyw8uqCHqYF5aCUJjeXXaSIXVpcR3LvtGNhSnldSgR0ZC3LsX20SnLmyxF9g W5hA== X-Forwarded-Encrypted: i=1; AHgh+RqyjXmA+ms4Cik4zMFJFLI2OU/aXHAixgWlrjGRLtJSivkzbz2kPWfixwmllTDHb56oIH8hFHj5ma3RIps=@vger.kernel.org X-Gm-Message-State: AOJu0YzBX8atRd5Uqa7kM9Y41RuzD63G5yZwCDk5ODqc3l7j4eH+TfFf WgbQoSga1fpUUQXvhTyoCJlDkTymWcOR/vTXJO1yahng3LIxErI+mcp+ X-Gm-Gg: AR+sD13pBKobqiw5mMujfroYOvrBAeE59yrefheCWwZneI7zAoa9hWHWNXv+EW11lqJ efjDrutC4tNYC2W4VwhB9fJKAe175A63EGpwe9dQbzl/odLuRtw6zHz6w6vya5u3cR/sM8ZR3hI t0vNkbdp+KxtbPt924vb9z3nuqL7RrsqSbiQK8ZoyfVWEaP8Zr6Viv4RGdtL3cULzHWYr0s0B54 tX4DtGuoXU8nyygFjzNXlj5X6NgFT9UgUr+Xoiv/giTpNWXY4oPEUPWorlkeeApssMRNUGyoTWF upH+VPaxgDA/ERgGa/luBqA550q/FzkLtp8fvH/PUQlQhe00L8yU71T1qM7eD33TvNnnlzx5K9k HK82YesNz7L5mbMAYQEnpSL2z2Bw2AxkqamZ38eBTOJKfFq3GkHkQN8lxFcULrytnbmOuhpT597 Vy0shrI6wv3G9bT7tgbJcIk+7ZDAe0sQQ2hdIxcf0tYtv7UbpvpdMByG3mF0XUo70UMypTkBFCB FS4/w== X-Received: by 2002:ac2:4856:0:b0:5b2:9599:b5f1 with SMTP id 2adb3069b0e04-5b2e4f6d57cmr1883681e87.42.1785853762238; Tue, 04 Aug 2026 07:29:22 -0700 (PDT) Received: from NB-9797.corp.yadro.com ([89.207.88.244]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2e245c0ccsm2703630e87.80.2026.08.04.07.29.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 07:29:21 -0700 (PDT) From: Ilya Khomyakov To: "Martin K . Petersen" Cc: "James E . J . Bottomley" , Sathya Prakash Veerichetty , Kashyap Desai , Sumit Saxena , Sreekanth Reddy , mpi3mr-linuxdrv.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Ilya Khomyakov Subject: [PATCH] scsi: mpi3mr: keep DevicePage0 SAS/SATA log on one line Date: Tue, 4 Aug 2026 17:29:01 +0300 Message-ID: <20260804142901.4406-1-khomyakovilya@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The DevicePage0 SAS/SATA diagnostic message contains an embedded newline inside a single ioc_info() format string. The first record receives the normal mpi3mr prefix, while the continuation starts directly with device_info. Consequently, common filtered captures such as dmesg | grep -i mpi3mr retain only the first part of the message and omit device_info, phy_num, attached_phy_id, and negotiated_link_rate. These fields are useful when diagnosing SAS discovery and negotiated link-rate problems. Before the change, a filtered capture stopped after: mpi3mr0: device_pg0: sas_sata: sas_address(0x5000cca2708a13c2),flags(0x0000), Remove the embedded newline and retain only the final newline so the entire message is emitted as one prefixed kernel log record. Also add the missing spaces after commas in the format string. After the change, the same device is reported in one record as: mpi3mr0: device_pg0: sas_sata: sas_address(0x5000cca2708a13c2), flags(0x0000), device_info(0x0101), phy_num(18), attached_phy_id(1), negotiated_link_rate(0x0b) The wrapping above is only for the changelog. The kernel emits the actual message on one line. The change was tested with an out-of-tree mpi3mr 8.17.1.0.4 build. All nine DevicePage0 SAS/SATA records retained every field in the output of `dmesg | grep -i mpi3mr`. This is a diagnostic-output-only change. It does not modify discovery, I/O, or link-management behavior. Signed-off-by: Ilya Khomyakov --- drivers/scsi/mpi3mr/mpi3mr_os.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c --- a/drivers/scsi/mpi3mr/mpi3mr_os.c +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c @@ -1290,8 +1290,9 @@ mpi3mr_debug_dump_devpg0(struct mpi3mr_ioc *mrioc, struct mpi3_device_page0 *dev struct mpi3_device0_sas_sata_format *sasinf = &dev_pg0->device_specific.sas_sata_format; ioc_info(mrioc, - "device_pg0: sas_sata: sas_address(0x%016llx),flags(0x%04x),\n" - "device_info(0x%04x), phy_num(%d), attached_phy_id(%d),negotiated_link_rate(0x%02x)\n", + "device_pg0: sas_sata: sas_address(0x%016llx), flags(0x%04x), " + "device_info(0x%04x), phy_num(%d), attached_phy_id(%d), " + "negotiated_link_rate(0x%02x)\n", le64_to_cpu(sasinf->sas_address), le16_to_cpu(sasinf->flags), le16_to_cpu(sasinf->device_info), sasinf->phy_num,