From: Sang-Heon Jeon <ekffu200098@gmail.com>
To: Mike Rapoport <rppt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH 4/4] mm/mm_init: clean up zone_spanned_pages_in_node()
Date: Tue, 4 Aug 2026 23:48:01 +0900 [thread overview]
Message-ID: <20260804144803.3290255-5-ekffu200098@gmail.com> (raw)
In-Reply-To: <20260804144803.3290255-1-ekffu200098@gmail.com>
Extract zone_movable_pfn[nid], which is used six times, into a local
variable, and return early to reduce the indentation level.
No functional change.
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
mm/mm_init.c | 48 ++++++++++++++++++++++++------------------------
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/mm/mm_init.c b/mm/mm_init.c
index 1190a27ed0fb..d544eed2f173 100644
--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@ -1240,41 +1240,41 @@ static unsigned long __init zone_spanned_pages_in_node(int nid,
{
unsigned long zone_low = arch_zone_lowest_possible_pfn[zone_type];
unsigned long zone_high = arch_zone_highest_possible_pfn[zone_type];
+ unsigned long movable_pfn = zone_movable_pfn[nid];
/* Get the start and end of the zone */
*zone_start_pfn = clamp(node_start_pfn, zone_low, zone_high);
*zone_end_pfn = clamp(node_end_pfn, zone_low, zone_high);
- /* Only adjust if ZONE_MOVABLE is on this node */
- if (zone_movable_pfn[nid]) {
- /* Size ZONE_MOVABLE */
- if (zone_type == ZONE_MOVABLE) {
- *zone_start_pfn = zone_movable_pfn[nid];
- *zone_end_pfn = min(node_end_pfn,
- arch_zone_highest_possible_pfn[movable_zone]);
+ /* Nothing to adjust if ZONE_MOVABLE is not on this node */
+ if (!movable_pfn)
+ goto out;
- /*
- * Check that this node has pages within the
- * zone's required range
- */
- if (*zone_end_pfn < node_start_pfn ||
- *zone_start_pfn > node_end_pfn)
- return 0;
+ /* Size ZONE_MOVABLE */
+ if (zone_type == ZONE_MOVABLE) {
+ *zone_start_pfn = movable_pfn;
+ *zone_end_pfn = min(node_end_pfn,
+ arch_zone_highest_possible_pfn[movable_zone]);
- /* Move the zone start inside the node if necessary */
- *zone_start_pfn = max(*zone_start_pfn, node_start_pfn);
+ /* Check that this node has pages within the zone's required range */
+ if (*zone_end_pfn < node_start_pfn ||
+ *zone_start_pfn > node_end_pfn)
+ return 0;
- /* Adjust for ZONE_MOVABLE starting within this range */
- } else if (!mirrored_kernelcore &&
- *zone_start_pfn < zone_movable_pfn[nid] &&
- *zone_end_pfn > zone_movable_pfn[nid]) {
- *zone_end_pfn = zone_movable_pfn[nid];
+ /* Move the zone start inside the node if necessary */
+ *zone_start_pfn = max(*zone_start_pfn, node_start_pfn);
- /* Check if this whole range is within ZONE_MOVABLE */
- } else if (*zone_start_pfn >= zone_movable_pfn[nid])
- *zone_start_pfn = *zone_end_pfn;
+ /* Adjust for ZONE_MOVABLE starting within this range */
+ } else if (!mirrored_kernelcore && *zone_start_pfn < movable_pfn &&
+ *zone_end_pfn > movable_pfn) {
+ *zone_end_pfn = movable_pfn;
+
+ /* Check if this whole range is within ZONE_MOVABLE */
+ } else if (*zone_start_pfn >= movable_pfn) {
+ *zone_start_pfn = *zone_end_pfn;
}
+out:
/* Return the spanned pages */
return *zone_end_pfn - *zone_start_pfn;
}
--
2.43.0
next prev parent reply other threads:[~2026-08-04 14:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 14:47 [PATCH 0/4] mm/mm_init: simplify zone_spanned_pages_in_node() Sang-Heon Jeon
2026-08-04 14:47 ` [PATCH 1/4] mm/mm_init: fold adjust_zone_range_for_zone_movable() into its sole caller Sang-Heon Jeon
2026-08-04 14:47 ` [PATCH 2/4] mm/mm_init: remove redundant clamping in zone_spanned_pages_in_node() Sang-Heon Jeon
2026-08-04 14:48 ` [PATCH 3/4] mm/mm_init: move the range check and clamping inside ZONE_MOVABLE branch Sang-Heon Jeon
2026-08-04 14:48 ` Sang-Heon Jeon [this message]
2026-08-06 14:41 ` [PATCH 0/4] mm/mm_init: simplify zone_spanned_pages_in_node() Sang-Heon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804144803.3290255-5-ekffu200098@gmail.com \
--to=ekffu200098@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox